[GitHub] [kafka] dadufour commented on a diff in pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

[GitBox <gi...@apache.org>]

dadufour commented on code in PR #11748:
URL: https://github.com/apache/kafka/pull/11748#discussion_r872036738


##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java:
##########
@@ -169,6 +172,7 @@ public String version() {
         return listConsumerGroupOffsets(group).entrySet().stream()
             .filter(x -> shouldCheckpointTopic(x.getKey().topic()))
             .map(x -> checkpoint(group, x.getKey(), x.getValue()))
+            .flatMap(o -> o.map(Stream::of).orElseGet(Stream::empty)) // do not emit checkpoints for partitions that don't have offset-syncs

Review Comment:
   I agree that having untranslated offsets from remote topics seems weird. Actually, I was believing that the checkpoint connector was doing the reverse-translation for offsets of remote topics. If it does not then I see it as a big limitation because once a consumer group has moved from a source topic to a remote topic, it will not be able to switch back to the source topic again (smartly resuming from where it stopped). So my question is: will this feature be handled separately?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org