You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/06/07 18:28:43 UTC
[GitHub] [arrow] zeroshade opened a new pull request, #35983: GH-35982: [Go] Fix go1.18 broken builds
zeroshade opened a new pull request, #35983:
URL: https://github.com/apache/arrow/pull/35983
### Rationale for this change
Fix usage of deprecated functions to fix the Go 1.18 builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35983: GH-35982: [Go] Fix go1.18 broken builds
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35983:
URL: https://github.com/apache/arrow/pull/35983#issuecomment-1581315453
:warning: GitHub issue #35982 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] candiduslynx commented on a diff in pull request #35983: GH-35982: [Go] Fix go1.18 broken builds
Posted by "candiduslynx (via GitHub)" <gi...@apache.org>.
candiduslynx commented on code in PR #35983:
URL: https://github.com/apache/arrow/pull/35983#discussion_r1222024655
##########
go/arrow/compute/exprs/types.go:
##########
@@ -623,7 +623,7 @@ func ToSubstraitType(dt arrow.DataType, nullable bool, ext ExtensionIDSet) (type
if err != nil {
return nil, err
}
- valueType, err := ToSubstraitType(dt.ValueType(), dt.ValueField().Nullable, ext)
+ valueType, err := ToSubstraitType(dt.Elem(), dt.ElemField().Nullable, ext)
Review Comment:
This is wrong, as the value here is a value in `key-value pair` sense, so it has to be `Item` in `arrow.MapType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35983: GH-35982: [Go] Fix go1.18 broken builds
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35983:
URL: https://github.com/apache/arrow/pull/35983#issuecomment-1583962175
Benchmark runs are scheduled for baseline = 9be7074f85d6057a92bc008766e8f30d58b30cf7 and contender = 08caf008b1bf2e93c70ae7db7531425bb9d4592e. 08caf008b1bf2e93c70ae7db7531425bb9d4592e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/809fd6b678e443428430112e3ac54e37...84116d530d074668b3d35a82af8bd118/)
[Finished :arrow_down:0.65% :arrow_up:0.09%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d80881575eee41aa9634bdf49960bc96...4fc72cac58ed4e5f8e741be404d560d2/)
[Finished :arrow_down:0.0% :arrow_up:0.33%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a4a568b61f6a4cb2a3737b893e567f6b...d944672d02a54fe4ab6a116fdc1b97b3/)
[Finished :arrow_down:0.12% :arrow_up:0.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ab7d75173a944cbba3a44a093755bfca...94ea66081c2f441b8bbd324b58e5c84d/)
Buildkite builds:
[Finished] [`08caf008` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/3003)
[Finished] [`08caf008` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3039)
[Finished] [`08caf008` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/3004)
[Finished] [`08caf008` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3029)
[Finished] [`9be7074f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/3002)
[Finished] [`9be7074f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3038)
[Finished] [`9be7074f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/3003)
[Finished] [`9be7074f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3028)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #35983: GH-35982: [Go] Fix go1.18 broken builds
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #35983:
URL: https://github.com/apache/arrow/pull/35983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] candiduslynx commented on a diff in pull request #35983: GH-35982: [Go] Fix go1.18 broken builds
Posted by "candiduslynx (via GitHub)" <gi...@apache.org>.
candiduslynx commented on code in PR #35983:
URL: https://github.com/apache/arrow/pull/35983#discussion_r1222024655
##########
go/arrow/compute/exprs/types.go:
##########
@@ -623,7 +623,7 @@ func ToSubstraitType(dt arrow.DataType, nullable bool, ext ExtensionIDSet) (type
if err != nil {
return nil, err
}
- valueType, err := ToSubstraitType(dt.ValueType(), dt.ValueField().Nullable, ext)
+ valueType, err := ToSubstraitType(dt.Elem(), dt.ElemField().Nullable, ext)
Review Comment:
@zeroshade This is wrong, as the value here is a value in `key-value pair` sense, so it has to be `Item` in `arrow.MapType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org