You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by PRAGYA MITTAL <mi...@gmail.com> on 2015/02/06 07:04:10 UTC
Review Request 30712: Fix PrismProcessScheduleTest in falcon
regression
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30712/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1011
https://issues.apache.org/jira/browse/FALCON-1011
Repository: falcon-git
Description
-------
Fixing failing test cases
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java c3dcf6e
Diff: https://reviews.apache.org/r/30712/diff/
Testing
-------
Done
Thanks,
PRAGYA MITTAL
Re: Review Request 30712: Fix PrismProcessScheduleTest in falcon
regression
Posted by PRAGYA MITTAL <mi...@gmail.com>.
> On Feb. 6, 2015, 12:59 p.m., Ruslan Ostafiychuk wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java, line 44
> > <https://reviews.apache.org/r/30712/diff/1/?file=852046#file852046line44>
> >
> > Why unused Logger is added?
Will remove this
- PRAGYA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30712/#review71419
-----------------------------------------------------------
On Feb. 6, 2015, 6:04 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30712/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2015, 6:04 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1011
> https://issues.apache.org/jira/browse/FALCON-1011
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Fixing failing test cases
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java c3dcf6e
>
> Diff: https://reviews.apache.org/r/30712/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 30712: Fix PrismProcessScheduleTest in falcon
regression
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30712/#review71419
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java
<https://reviews.apache.org/r/30712/#comment117176>
Why unused Logger is added?
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java
<https://reviews.apache.org/r/30712/#comment117177>
javadoc should be alsoo changed
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java
<https://reviews.apache.org/r/30712/#comment117178>
javadoc should be also changed
- Ruslan Ostafiychuk
On Feb. 6, 2015, 6:04 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30712/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2015, 6:04 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1011
> https://issues.apache.org/jira/browse/FALCON-1011
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Fixing failing test cases
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java c3dcf6e
>
> Diff: https://reviews.apache.org/r/30712/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 30712: Fix PrismProcessScheduleTest in falcon
regression
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30712/#review71421
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java
<https://reviews.apache.org/r/30712/#comment117180>
Lines were good without this change. New checkstyle bug is introduced here.
- Ruslan Ostafiychuk
On Feb. 6, 2015, 6:04 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30712/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2015, 6:04 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1011
> https://issues.apache.org/jira/browse/FALCON-1011
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Fixing failing test cases
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java c3dcf6e
>
> Diff: https://reviews.apache.org/r/30712/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 30712: Fix PrismProcessScheduleTest in falcon
regression
Posted by Karishma Gulati <gu...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30712/#review73767
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java
<https://reviews.apache.org/r/30712/#comment120148>
Same as above.
- Karishma Gulati
On Feb. 13, 2015, 9:18 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30712/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2015, 9:18 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1011
> https://issues.apache.org/jira/browse/FALCON-1011
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Fixing failing test cases
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java c3dcf6e
>
> Diff: https://reviews.apache.org/r/30712/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 30712: Fix PrismProcessScheduleTest in falcon
regression
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30712/#review75874
-----------------------------------------------------------
Ship it!
All seems good to me. +1
- Paul Isaychuk
On March 9, 2015, 2:24 p.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30712/
> -----------------------------------------------------------
>
> (Updated March 9, 2015, 2:24 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1011
> https://issues.apache.org/jira/browse/FALCON-1011
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Fixing failing test cases
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java ccf9e97
>
> Diff: https://reviews.apache.org/r/30712/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 30712: Fix PrismProcessScheduleTest in falcon
regression
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30712/
-----------------------------------------------------------
(Updated March 9, 2015, 2:24 p.m.)
Review request for Falcon.
Changes
-------
New patch
Bugs: FALCON-1011
https://issues.apache.org/jira/browse/FALCON-1011
Repository: falcon-git
Description
-------
Fixing failing test cases
Diffs (updated)
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java ccf9e97
Diff: https://reviews.apache.org/r/30712/diff/
Testing
-------
Done
Thanks,
PRAGYA MITTAL
Re: Review Request 30712: Fix PrismProcessScheduleTest in falcon
regression
Posted by PRAGYA MITTAL <mi...@gmail.com>.
> On Feb. 24, 2015, 7:28 a.m., Karishma Gulati wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java, line 208
> > <https://reviews.apache.org/r/30712/diff/2/?file=863110#file863110line208>
> >
> > Mentioned process should be running on colo-2 only, not colo-1.
Will change it in new patch
- PRAGYA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30712/#review73765
-----------------------------------------------------------
On Feb. 13, 2015, 9:18 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30712/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2015, 9:18 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1011
> https://issues.apache.org/jira/browse/FALCON-1011
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Fixing failing test cases
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java c3dcf6e
>
> Diff: https://reviews.apache.org/r/30712/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 30712: Fix PrismProcessScheduleTest in falcon
regression
Posted by Karishma Gulati <gu...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30712/#review73765
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java
<https://reviews.apache.org/r/30712/#comment120146>
Mentioned process should be running on colo-2 only, not colo-1.
- Karishma Gulati
On Feb. 13, 2015, 9:18 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30712/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2015, 9:18 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1011
> https://issues.apache.org/jira/browse/FALCON-1011
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Fixing failing test cases
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java c3dcf6e
>
> Diff: https://reviews.apache.org/r/30712/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 30712: Fix PrismProcessScheduleTest in falcon
regression
Posted by PRAGYA MITTAL <mi...@gmail.com>.
> On Feb. 24, 2015, 7:41 a.m., Karishma Gulati wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java, line 377
> > <https://reviews.apache.org/r/30712/diff/2/?file=863110#file863110line377>
> >
> > I think you can let these succeed, because if we look at the workflow for no input/output, the instances should technically succeed.
Will change it in new patch
- PRAGYA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30712/#review73766
-----------------------------------------------------------
On Feb. 13, 2015, 9:18 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30712/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2015, 9:18 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1011
> https://issues.apache.org/jira/browse/FALCON-1011
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Fixing failing test cases
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java c3dcf6e
>
> Diff: https://reviews.apache.org/r/30712/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 30712: Fix PrismProcessScheduleTest in falcon
regression
Posted by Karishma Gulati <gu...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30712/#review73766
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java
<https://reviews.apache.org/r/30712/#comment120147>
I think you can let these succeed, because if we look at the workflow for no input/output, the instances should technically succeed.
- Karishma Gulati
On Feb. 13, 2015, 9:18 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30712/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2015, 9:18 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1011
> https://issues.apache.org/jira/browse/FALCON-1011
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Fixing failing test cases
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java c3dcf6e
>
> Diff: https://reviews.apache.org/r/30712/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 30712: Fix PrismProcessScheduleTest in falcon
regression
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30712/
-----------------------------------------------------------
(Updated Feb. 13, 2015, 9:18 a.m.)
Review request for Falcon.
Bugs: FALCON-1011
https://issues.apache.org/jira/browse/FALCON-1011
Repository: falcon-git
Description
-------
Fixing failing test cases
Diffs (updated)
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java c3dcf6e
Diff: https://reviews.apache.org/r/30712/diff/
Testing
-------
Done
Thanks,
PRAGYA MITTAL