[jira] [Commented] (SENTRY-1936) Intern role names in Sentry APIs

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163946#comment-16163946 ] 

Hadoop QA commented on SENTRY-1936:
-----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12886742/SENTRY-1936.01.patch against master.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} all tests passed

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3283/console

This message is automatically generated.

> Intern role names in Sentry APIs
> --------------------------------
>
>                 Key: SENTRY-1936
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1936
>             Project: Sentry
>          Issue Type: Improvement
>          Components: Sentry
>    Affects Versions: 2.0.0
>            Reporter: Alexander Kolbasov
>            Assignee: Misha Dmitriev
>         Attachments: SENTRY-1936.01.patch
>
>
> HS2 often issues calls to list_sentry_roles_by_group which fetches the same set of roles and this causes duplicate strings since roles are the same. Role names should be interned to remove duplicates.
> [~misha@cloudera.com] found the problem by analyzing Sentry dumps



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)