You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/08/04 19:30:20 UTC
[GitHub] [netbeans] jlahoda opened a new pull request #2294: Adding support for clangd to cpplite
jlahoda opened a new pull request #2294:
URL: https://github.com/apache/netbeans/pull/2294
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #2294: Adding support for clangd to cpplite
Posted by GitBox <gi...@apache.org>.
vieiro commented on pull request #2294:
URL: https://github.com/apache/netbeans/pull/2294#issuecomment-670492575
@jlahoda Full speed ahead then!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2294: Adding support for clangd to cpplite
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2294:
URL: https://github.com/apache/netbeans/pull/2294#issuecomment-670516333
@jlahoda @matthiasblaesing fine with me! If it's working, feel free to merge so we can get in next beta - waiting for a fixed nb-javac anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda merged pull request #2294: Adding support for clangd to cpplite
Posted by GitBox <gi...@apache.org>.
jlahoda merged pull request #2294:
URL: https://github.com/apache/netbeans/pull/2294
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #2294: Adding support for clangd to cpplite
Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #2294:
URL: https://github.com/apache/netbeans/pull/2294#issuecomment-670343354
@matthiasblaesing - I wouldn't mind if this got to 12.1, but I can live with it not getting there. We can separate the fix for the NPE if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #2294: Adding support for clangd to cpplite
Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #2294:
URL: https://github.com/apache/netbeans/pull/2294#issuecomment-670343105
@vieiro
> Just a quick question (don't have to do a thorough review, I'm afraid). Do you think this static final is going to cause threading/memory problems?
>
> ` private static final TextDocumentSyncServerCapabilityHandler h = new TextDocumentSyncServerCapabilityHandler();`
> `
I hope not. The instance was no free-able anyway (it was added as a listener to EditorRegistry and never removed). And final fields should be safe to access from any thread (static fields are initialized under a classloading lock (non-static final fields are also accessible from anywhere after the constructor finishes, AFAIK)).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2294: Adding support for clangd to cpplite
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2294:
URL: https://github.com/apache/netbeans/pull/2294#issuecomment-670148732
A quick observation: I noticed that in the typescript editor the completion for paths in import statements did not work correctly for me. This manifested in the selector opening, but when I got on typing, I got a nullpointer exception. This is gone with this change, so if not anything else, this at least fixes a bug for me.
@jlahoda do you think this is stable enough to get into 12.1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2294: Adding support for clangd to cpplite
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2294:
URL: https://github.com/apache/netbeans/pull/2294#issuecomment-670844862
Added 12.1 milestone to help tracking. If you decide not to merge, please move to 12.2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists