You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "neilconway (via GitHub)" <gi...@apache.org> on 2026/09/12 12:43:23 UTC
[PR] fix: Correct `array_repeat` NULL handling [datafusion]
neilconway opened a new pull request, #25230:
URL: https://github.com/apache/datafusion/pull/25230
## Which issue does this PR close?
- Closes #25223.
## Rationale for this change
Arrow allows elements of a `ListArray` to be logically NULL (according to the validity buffer), but to have non-empty offset ranges. Such elements should be considered NULL.
`array_repeat` only considered the offsets and ignored the validity buffer, which resulted in mishandling such NULL values.
## What changes are included in this PR?
* Fix `array_repeat` bug
* Add unit test
* Add SLT
## What is the testing strategy for this PR?
Existing tests pass; new tests added. We add both a unit test and an SLT because the SLT depends on `nullif` creating such a NULL value, which might change in the future.
## Are there any user-facing changes?
Yes, bug fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Correct `array_repeat` NULL handling [datafusion]
Posted by "neilconway (via GitHub)" <gi...@apache.org>.
neilconway merged PR #25230:
URL: https://github.com/apache/datafusion/pull/25230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Correct `array_repeat` NULL handling [datafusion]
Posted by "neilconway (via GitHub)" <gi...@apache.org>.
neilconway commented on PR #25230:
URL: https://github.com/apache/datafusion/pull/25230#issuecomment-5648767381
@nuno-faria Thanks for the reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Correct `array_repeat` NULL handling [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #25230:
URL: https://github.com/apache/datafusion/pull/25230#issuecomment-5646077450
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/25230?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `96.66667%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 81.94%. Comparing base ([`bb21f51`](https://app.codecov.io/gh/apache/datafusion/commit/bb21f51013a3f476c5e510de745c77e194fcb584?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`95a0380`](https://app.codecov.io/gh/apache/datafusion/commit/95a0380e09ea02cce0341fdbca5c2f977b5f9843?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion/pull/25230?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [datafusion/functions-nested/src/repeat.rs](https://app.codecov.io/gh/apache/datafusion/pull/25230?src=pr&el=tree&filepath=datafusion%2Ffunctions-nested%2Fsrc%2Frepeat.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9mdW5jdGlvbnMtbmVzdGVkL3NyYy9yZXBlYXQucnM=) | 96.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/25230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #25230 +/- ##
========================================
Coverage 81.93% 81.94%
========================================
Files 1133 1133
Lines 423529 423829 +300
Branches 423529 423829 +300
========================================
+ Hits 347032 347313 +281
- Misses 55907 55922 +15
- Partials 20590 20594 +4
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/25230?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org