You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sean Hsuan-Yi Chu <hs...@usc.edu> on 2015/07/24 17:47:06 UTC
Review Request 36782: DRILL-3537: Empty Json file can potentially
result into wrong results
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36782/
-----------------------------------------------------------
Review request for drill, Hanifi Gunes and Parth Chandra.
Bugs: DRILL-3537
https://issues.apache.org/jira/browse/DRILL-3537
Repository: drill-git
Description
-------
Whe scanning files in ScanBatch, ignore all the empty files before reach a non-empty file
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java 6bf1280
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java 912a5f0
exec/java-exec/src/test/resources/store/json/jsonDirectoryWithEmpyFile/a.json PRE-CREATION
exec/java-exec/src/test/resources/store/json/jsonDirectoryWithEmpyFile/b.json PRE-CREATION
Diff: https://reviews.apache.org/r/36782/diff/
Testing
-------
Unit, tpch, (functional is down; will run again when it comes back)
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 36782: DRILL-3537: Empty Json file can potentially
result into wrong results
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36782/#review93184
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On July 27, 2015, 4:38 a.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36782/
> -----------------------------------------------------------
>
> (Updated July 27, 2015, 4:38 a.m.)
>
>
> Review request for drill, Hanifi Gunes and Parth Chandra.
>
>
> Bugs: DRILL-3537
> https://issues.apache.org/jira/browse/DRILL-3537
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Whe scanning files in ScanBatch, ignore all the empty files before reach a non-empty file
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java 6bf1280
> exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java 912a5f0
> exec/java-exec/src/test/resources/store/json/jsonDirectoryWithEmpyFile/a.json PRE-CREATION
> exec/java-exec/src/test/resources/store/json/jsonDirectoryWithEmpyFile/b.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36782/diff/
>
>
> Testing
> -------
>
> Unit, tpch, functional all passed
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 36782: DRILL-3537: Empty Json file can potentially
result into wrong results
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36782/
-----------------------------------------------------------
(Updated July 27, 2015, 4:38 a.m.)
Review request for drill, Hanifi Gunes and Parth Chandra.
Changes
-------
Update the description
Bugs: DRILL-3537
https://issues.apache.org/jira/browse/DRILL-3537
Repository: drill-git
Description
-------
Whe scanning files in ScanBatch, ignore all the empty files before reach a non-empty file
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java 6bf1280
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java 912a5f0
exec/java-exec/src/test/resources/store/json/jsonDirectoryWithEmpyFile/a.json PRE-CREATION
exec/java-exec/src/test/resources/store/json/jsonDirectoryWithEmpyFile/b.json PRE-CREATION
Diff: https://reviews.apache.org/r/36782/diff/
Testing (updated)
-------
Unit, tpch, functional all passed
Thanks,
Sean Hsuan-Yi Chu