You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "slavanorm (via GitHub)" <gi...@apache.org> on 2023/06/13 06:19:57 UTC

[GitHub] [superset] slavanorm opened a new issue, #24374: Line chart. Event annotation not work

slavanorm opened a new issue, #24374:
URL: https://github.com/apache/superset/issues/24374

   Line chart. Event annotation not work.
   error raised from python (raises every time):
   ![telegram-cloud-photo-size-4-5769422933448572157-y](https://github.com/apache/superset/assets/48209342/2be25cd6-fdeb-4c86-b655-547458d220b3)
   
   
   #### How to reproduce the bug
   
   1. create a line chart
   2. add Event annotation
   3. click apply/ok and get the error
   
   #### Screenshots
   <img width="1379" alt="Screenshot 2023-06-13 at 10 17 06" src="https://github.com/apache/superset/assets/48209342/60992ffc-0f38-4949-a83d-402af4871b7a">
   
   
   ### Environment
   
   (please complete the following information):
   
   - browser type and version: chrome v 114.0.5375
   - superset version: `2.1.0`
   - python version: `3.10`
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [v] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [v] I have reproduced the issue with at least the latest released version of superset.
   - [v] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   SQL server: psql 14
   failed annotation with "superset annotation" and "table", same error.
   
   works on 1.5.3, so feels like recent changes are breaking
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Line chart. Event annotation not work [superset]

Posted by "aagorelik (via GitHub)" <gi...@apache.org>.
aagorelik commented on issue #24374:
URL: https://github.com/apache/superset/issues/24374#issuecomment-1899410972

   The issue still persists (helm version `0.11.2`), even when using Superset own Annotations Layer and Time Grain removed from the chart:
   
   ![image](https://github.com/apache/superset/assets/1843995/fc0aad12-0a4f-4e33-8fc2-a17a5e0fe0d0)
   
   Or when used own table (with, or without `P1D` field added; and with, or without Time Grain):
   
   ![image](https://github.com/apache/superset/assets/1843995/261c165b-6d34-42c5-b58e-3ec7aba9d7c1)
   
   ![image](https://github.com/apache/superset/assets/1843995/beac013a-781f-4548-982c-ee4f0af1d7e8)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Line chart. Event annotation not work [superset]

Posted by "konvica (via GitHub)" <gi...@apache.org>.
konvica commented on issue #24374:
URL: https://github.com/apache/superset/issues/24374#issuecomment-1971521804

   Same issue. What solved it for me, was to recreate the annotations table outside of any dashboard and set time grain in the annotation table to "minute".  For the line chart I use time grain "hour" or "minute". 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] padbk commented on issue #24374: Line chart. Event annotation not work

Posted by "padbk (via GitHub)" <gi...@apache.org>.
padbk commented on issue #24374:
URL: https://github.com/apache/superset/issues/24374#issuecomment-1588860724

   We have had the same error on 2.1.0 when adding interval annotations too:
   
   `column p1d does not exist`
   
   To fix, I had to add a column to the dataset called `p1d` that was the same as the time series column and that seems to allow the annotation layer to be rendered.
   
   It shouldn't need that though, so this is very likely to be a bug.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Line chart. Event annotation not work [superset]

Posted by "Mavyre (via GitHub)" <gi...@apache.org>.
Mavyre commented on issue #24374:
URL: https://github.com/apache/superset/issues/24374#issuecomment-1804781702

   Same here but with 'P1M' column. Event Annotation on Mixed Chart.
   I can't understand what's going on, and sometimes it start to magically work


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] slavanorm commented on issue #24374: Line chart. Event annotation not work

Posted by "slavanorm (via GitHub)" <gi...@apache.org>.
slavanorm commented on issue #24374:
URL: https://github.com/apache/superset/issues/24374#issuecomment-1598873344

   idk.. i created p1d and P1D cols and it still not working


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Line chart. Event annotation not work [superset]

Posted by "azamrik (via GitHub)" <gi...@apache.org>.
azamrik commented on issue #24374:
URL: https://github.com/apache/superset/issues/24374#issuecomment-1808176450

   This issue seems to happen when adding annotations to a chart when:
   
   - It has time grain (p1d is daily grain, p1w is weekly, p1m is monthly, ...etc)
   - The chart is already part of a dashboard
   
   
   A work around that worked for me is to recreate the chart with the annotation and then add it to the dashboard.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Line chart. Event annotation not work [superset]

Posted by "Mavyre (via GitHub)" <gi...@apache.org>.
Mavyre commented on issue #24374:
URL: https://github.com/apache/superset/issues/24374#issuecomment-1808212552

   > This issue seems to happen when adding annotations to a chart when:
   > 
   > * It has time grain (p1d is daily grain, p1w is weekly, p1m is monthly, ...etc)
   > * The chart is already part of a dashboard
   > 
   > A work around that worked for me is to recreate the chart with the annotation and then add it to the dashboard.
   
   Thanks for the comment. Gave me an idea that actually works: Checking "Override Time Grain" does the job for me, even if the chart already is part of a dashboard!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Line chart. Event annotation not work [superset]

Posted by "oliverlambson (via GitHub)" <gi...@apache.org>.
oliverlambson commented on issue #24374:
URL: https://github.com/apache/superset/issues/24374#issuecomment-1905980881

   Same issue here 🤚 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org