You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/17 19:50:37 UTC

[GitHub] [beam] kennknowles commented on a change in pull request #14001: [BEAM-11824] Set merge status in WindowingStrategyTranslation

kennknowles commented on a change in pull request #14001:
URL: https://github.com/apache/beam/pull/14001#discussion_r577899082



##########
File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/WindowingStrategyTranslation.java
##########
@@ -295,10 +299,17 @@ public static FunctionSpec toProto(WindowFn<?, ?> windowFn, SdkComponents compon
             .setAllowedLateness(windowingStrategy.getAllowedLateness().getMillis())
             .setTrigger(TriggerTranslation.toProto(windowingStrategy.getTrigger()))
             .setWindowFn(windowFnSpec)
-            .setAssignsToOneWindow(windowingStrategy.getWindowFn().assignsToOneWindow())
+            .setAssignsToOneWindow(windowFn.assignsToOneWindow())
+            .setMergeStatus(
+                windowFn instanceof InvalidWindows
+                    ? (((InvalidWindows) windowFn).getOriginalWindowFn().isNonMerging()

Review comment:
       It is a good question. I think the original WindowFn is just for giving a good error message. It is also used to check compatibility of `Flatten` of two PCollections.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org