You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/06/19 14:11:59 UTC
Review Request 35647: Fix logic for calling erase inside loop.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35647/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Ben Mahler, and Till Toenshoff.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b
Diff: https://reviews.apache.org/r/35647/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 35647: Fix logic for calling erase inside loop.
Posted by Michael Park <mc...@gmail.com>.
> On June 19, 2015, 12:28 p.m., Alexander Rukletsov wrote:
> > Why should we care about that if we `break` right after `erase()`?
Oh! I totally missed that! Discarding.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35647/#review88532
-----------------------------------------------------------
On June 19, 2015, 12:24 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35647/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 12:24 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Ben Mahler, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b
>
> Diff: https://reviews.apache.org/r/35647/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35647: Fix logic for calling erase inside loop.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35647/#review88532
-----------------------------------------------------------
Why should we care about that if we `break` right after `erase()`?
- Alexander Rukletsov
On June 19, 2015, 12:24 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35647/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 12:24 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Ben Mahler, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b
>
> Diff: https://reviews.apache.org/r/35647/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35647: Fix logic for calling erase inside loop.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35647/
-----------------------------------------------------------
(Updated June 19, 2015, 12:24 p.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Ben Mahler, and Till Toenshoff.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b
Diff: https://reviews.apache.org/r/35647/diff/
Testing
-------
`make check`
Thanks,
Michael Park