You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/23 13:22:37 UTC

[GitHub] [flink] azagrebin commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API

azagrebin commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#discussion_r286939202
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
 ##########
 @@ -388,10 +378,12 @@ public Task(
 			this,
 			inputGateDeploymentDescriptors,
 			metrics.getIOMetricGroup(),
-			inputGroup,
-			buffersGroup,
 			metrics.getIOMetricGroup().getNumBytesInCounter());
 
+		// we will have to check type of shuffle service later whether it is NetworkEnvironment
+		//noinspection deprecation
 
 Review comment:
   it does not work for statements, at least in Idea. that is why Idea has this special extra comment, I guess.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services