Bug 32897

[Kevin Jackson <fo...@gmail.com>]

http://issues.apache.org/bugzilla/show_bug.cgi?id=32897

Hi all,

Is there a reason why this was not considered for inclusion at all?
It from 2004, but the overall idea is quite useful (I've personally
needed something like this recently when digging through a rats nest
of build files).

I don't think adding something like this should be done now for 1.7,
but for 1.8 I'd like to know if anyone would -1 this being included
post 1.7 timeframe?

Thanks,
Kev

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org

Re: Bug 32897

[Dominique Devienne <dd...@gmail.com>]

> I was unaware of this bug report, I had never read it.
>
> Since this LocationLogger extends DefaultLogger but does not change it,
> it could still be included in 1.7, I view this as uncritical.

> Kevin Jackson wrote:
> > http://issues.apache.org/bugzilla/show_bug.cgi?id=32897
> > Is there a reason why this was not considered for inclusion at all?
> > It from 2004, but the overall idea is quite useful (I've personally
> > needed something like this recently when digging through a rats nest
> > of build files).

Interesting. I must have missed this PR. In Apr 1003, I created
NoBannerSubBuildLogger.java which instead of reporting the Location,
reported the series of build <project> names that ended up calling a
given target (by tracking the Project associated to each log event),
but Conor had concerns about the impl in the face of <parallel>, but
this patch is safer, since the location is always valid.

The problem with loggers and listeners is that it's a pita to specify
them on the CLI, or to configure them using properties. But that's an
old rant ;-)

For this particular case, maybe this location-logging feature would be
better as a BuildListener rather than a Logger. My $.02. --DD

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org

Re: Bug 32897

[Antoine Levy-Lambert <an...@gmx.de>]

Hello Kevin,

I was unaware of this bug report, I had never read it.

Since this LocationLogger extends DefaultLogger but does not change it,
it could still be included in 1.7, I view this as uncritical.

Regards,

Antoine

Kevin Jackson wrote:
> http://issues.apache.org/bugzilla/show_bug.cgi?id=32897
>
> Hi all,
>
> Is there a reason why this was not considered for inclusion at all?
> It from 2004, but the overall idea is quite useful (I've personally
> needed something like this recently when digging through a rats nest
> of build files).
>
> I don't think adding something like this should be done now for 1.7,
> but for 1.8 I'd like to know if anyone would -1 this being included
> post 1.7 timeframe?
>
> Thanks,
> Kev
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org