You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "balashashanka (via GitHub)" <gi...@apache.org> on 2024/04/19 15:20:47 UTC

[PR] [Mahout-1958] Change the variable type to long to avoid overflow [mahout]

balashashanka opened a new pull request, #444:
URL: https://github.com/apache/mahout/pull/444

   ### Purpose of PR:
   Please give a short description of what this PR is for.
   
   
   ### Important ToDos
   Please mark each with an "x"
   - [ ] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/]
   - [ ] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
   - [ ] Created unit tests where appropriate
   - [ ] Added licenses correct on newly added files
   - [ ] Assigned JIRA to self
   - [ ] Added documentation in scala docs/java docs, and to website
   - [ ] Successfully built and ran all unit tests, verified that all tests pass locally.
   
   If all of these things aren't complete, but you still feel it is
   appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
   descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"
   
   Does this change break earlier versions?
   
   Is this the beginning of a larger project for which a feature branch should be made?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Mahout-1958] Change the variable type to long to avoid overflow [mahout]

Posted by "andrewmusselman (via GitHub)" <gi...@apache.org>.
andrewmusselman closed pull request #444: [Mahout-1958] Change the variable type to long to avoid overflow
URL: https://github.com/apache/mahout/pull/444


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Mahout-1958] Change the variable type to long to avoid overflow [mahout]

Posted by "andrewmusselman (via GitHub)" <gi...@apache.org>.
andrewmusselman commented on PR #444:
URL: https://github.com/apache/mahout/pull/444#issuecomment-2093499113

   We can merge if this is looking good @balashashanka , did it build for you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Mahout-1958] Change the variable type to long to avoid overflow [mahout]

Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on PR #444:
URL: https://github.com/apache/mahout/pull/444#issuecomment-2073431404

   Thanks for the contrib @balashashanka 
   > Successfully built and ran all unit tests, verified that all tests pass locally.
   
   Did `mvn clean install` build without failures?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org