[GitHub] [rocketmq] cserwen commented on pull request #6801: [ISSUE #6800] fix: wrong setter for config isEnableBatchPush

["cserwen (via GitHub)" <gi...@apache.org>]

cserwen commented on PR #6801:
URL: https://github.com/apache/rocketmq/pull/6801#issuecomment-1562970020

   我们现在在配置文件中通过 enableBatchPush 来设置这个配置，因此你不能修改set的方法，那样会导致配置项的不兼容，一个更好的方式是修改变量名称为enableBatchPush，并修改isEnableBatchPush() 为enableBatchPush()在 2023年5月25日，21:59，Vincent Lee ***@***.***> 写道：
   @absolute8511 commented on this pull request.
   
   
   
   In store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java:
   > @@ -1129,7 +1129,7 @@ public boolean isEnableBatchPush() {
            return isEnableBatchPush;
        }
    
   -    public void setEnableBatchPush(boolean enableBatchPush) {
   +    public void setIsEnableBatchPush(boolean enableBatchPush) {
            isEnableBatchPush = enableBatchPush;
   
   But getBrokerConfig will use isEnableBatchPush, which is inconsistence. I think maybe we need make it the same as other config name
   
   —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org