You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/04 01:18:53 UTC

[GitHub] [incubator-druid] ccaominh opened a new pull request #8023: Add round support for DS-HLL

ccaominh opened a new pull request #8023: Add round support for DS-HLL
URL: https://github.com/apache/incubator-druid/pull/8023
 
 
   ### Description
   
   Since the Cardinality aggregator has a "round" option to round off estimated
   values generated from the HyperLogLog algorithm, add the same "round" option to
   the DataSketches HLL Sketch module aggregators to be consistent.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [x] added unit tests or modified existing tests to cover new code paths.
   
   <hr>
   
   For reviewers: the key changed/added classes in this PR are `HllSketchAggregatorFactory`, `HllSketchBuildAggregatorFactory`, `HllSketchMergeAggregatorFactory`, and `HllSketchAggregatorTest`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org