You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/03/27 16:06:28 UTC
[GitHub] [ignite] alamar commented on a change in pull request #6349:
IGNITE-11634 SQL delete query failed to deserialize entryModifier
alamar commented on a change in pull request #6349: IGNITE-11634 SQL delete query failed to deserialize entryModifier
URL: https://github.com/apache/ignite/pull/6349#discussion_r269643518
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/DmlStatementsProcessorTest.java
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.h2;
+
+import javax.cache.processor.MutableEntry;
+import org.apache.ignite.lang.IgniteInClosure;
+import org.junit.Assert;
+import org.junit.Test;
+
+/**
+ * Ensures that abstart classes of entry modifiers are compatible with old versions.
+ */
+public class DmlStatementsProcessorTest {
+ /**
+ * Checks that remove-closure is available by anonymous class position (4).
+ * This is required for compatibility with versions < 2.7.0.
+ *
+ * @throws Exception If failed.
+ */
+ @Test
+ public void testRemoveEntryModifierCompatibilityOld() throws Exception {
+ checkRemoveClosureByAnonymousPosition(4);
+ }
+
+ /**
+ * Checks that remove-closure is available by anonymous class position (5).
+ * This is required for compatibility with versions >= 2.7.0.
+ *
+ * @throws Exception If failed.
+ */
+ @Test
+ public void testRemoveEntryModifierCompatibilityNew() throws Exception {
Review comment:
can you please add a negative case (i.e. that 3 or 6 would not work)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services