You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2009/01/19 15:29:29 UTC
[Bug 6045] New: masses/bayes-testing/benchmark fixes and
enhancements
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6045
Summary: masses/bayes-testing/benchmark fixes and enhancements
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: All
OS/Version: All
Status: NEW
Severity: minor
Priority: P5
Component: Masses
AssignedTo: dev@spamassassin.apache.org
ReportedBy: mdorman@ironicdesign.com
As part of the process of developing a new BayesStore implementation, I found
myself cleaning up and updating various bits of the bayes benchmark scripts.
These are those changes.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6045] masses/bayes-testing/benchmark fixes and enhancements
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6045
--- Comment #6 from Michael Alan Dorman <md...@ironicdesign.com> 2009-01-19 06:37:32 PST ---
Created an attachment (id=4420)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4420)
Don't presume as to the location of mysql binaries
ISTM that it's much more sensible to use path-less calls to binaries and depend
on the user to set the path properly before running the benchmarking script.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6045] masses/bayes-testing/benchmark fixes and enhancements
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6045
--- Comment #11 from Michael Alan Dorman <md...@ironicdesign.com> 2009-01-19 07:16:14 PST ---
I should add that this patch my require manual application; nothing _hard_, but
patch doesn't know about renames, obviously, so it would be necessary to first
'mv run-bench.driver run-bench', then apply the patch.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6045] masses/bayes-testing/benchmark fixes and enhancements
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6045
--- Comment #1 from Michael Alan Dorman <md...@ironicdesign.com> 2009-01-19 06:30:49 PST ---
Created an attachment (id=4415)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4415)
Update init.pre files to include plugins implementing the check routine.
Without this, with recent versions of SA the whole business simply errors out.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6045] masses/bayes-testing/benchmark fixes and enhancements
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6045
--- Comment #8 from Michael Alan Dorman <md...@ironicdesign.com> 2009-01-19 06:42:23 PST ---
Created an attachment (id=4422)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4422)
Replace run-bench with a modified run-bench.driver
The run-bench script seemed totally superfluous, so I removed it and renamed
the run-bench.driver script to run-bench, and cleaned it up and made it a
little more verbose in what it was doing.
I can see this being a more controversial change; I felt like it made things
clearer by removing some unnecessary indirection and making things a little
more consistent in how they're run. I suspect it could still use further
cleanup, but this was enough to get me to the point of being able to reliably
benchmark all of the backends.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6045] masses/bayes-testing/benchmark fixes and enhancements
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6045
--- Comment #7 from Michael Alan Dorman <md...@ironicdesign.com> 2009-01-19 06:38:31 PST ---
Created an attachment (id=4421)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4421)
Don't presume as to the location of psql binaries
Same as above.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6045] masses/bayes-testing/benchmark fixes and enhancements
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6045
--- Comment #2 from Michael Alan Dorman <md...@ironicdesign.com> 2009-01-19 06:32:17 PST ---
Created an attachment (id=4416)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4416)
Rewrite runmbox.pl to use ArchiveIterator
This frees the benchmark code from one of its external dependencies.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6045] masses/bayes-testing/benchmark fixes and enhancements
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6045
--- Comment #9 from Justin Mason <jm...@jmason.org> 2009-01-19 06:58:44 PST ---
Michael, did you write the originals of these? any chance you could take a
look over these changes?
They look good to me, at a quick glance...
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6045] masses/bayes-testing/benchmark fixes and enhancements
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6045
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #12 from Justin Mason <jm...@jmason.org> 2009-06-30 14:34:42 PST ---
cool. better late than never!
: 300...; svn commit -m "bug 6045: lots of fixes and cleanup for the Bayes
benchmarking scripts, thanks to Michael Alan Dorman" masses/bayes-testing/
Sending masses/bayes-testing/benchmark/helper/db_file/dbsize
Sending masses/bayes-testing/benchmark/helper/db_file/setup
Sending masses/bayes-testing/benchmark/helper/mysql/cleardb
Sending masses/bayes-testing/benchmark/helper/mysql/dbsize
Sending masses/bayes-testing/benchmark/helper/pgsql/cleardb
Sending masses/bayes-testing/benchmark/helper/pgsql/dbsize
Sending masses/bayes-testing/benchmark/run-bench
Deleting masses/bayes-testing/benchmark/run-bench.driver
Sending masses/bayes-testing/benchmark/runmbox.pl
Sending masses/bayes-testing/benchmark/runmulti.pl
Sending masses/bayes-testing/benchmark/tests/db_file/site/init.pre
Sending masses/bayes-testing/benchmark/tests/mysql/site/init.pre
Sending masses/bayes-testing/benchmark/tests/pgsql/site/init.pre
Sending masses/bayes-testing/benchmark/tests/sdbm/site/init.pre
Transmitting file data .............
Committed revision 789964 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=789964 ).
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6045] masses/bayes-testing/benchmark fixes and enhancements
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6045
--- Comment #3 from Michael Alan Dorman <md...@ironicdesign.com> 2009-01-19 06:34:02 PST ---
Created an attachment (id=4417)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4417)
Allow runmulti.pl to run more jobs concurrently
Since performance in concurrent situations is a bit component of bayes
performance, allow runmulti.pl to test with more than two concurrent jobs.
Also, make the output a little more useful, IMHO.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6045] masses/bayes-testing/benchmark fixes and enhancements
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6045
--- Comment #4 from Michael Alan Dorman <md...@ironicdesign.com> 2009-01-19 06:34:45 PST ---
Created an attachment (id=4418)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4418)
Make sure the bayes directory exists for db_file
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6045] masses/bayes-testing/benchmark fixes and enhancements
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6045
--- Comment #5 from Michael Alan Dorman <md...@ironicdesign.com> 2009-01-19 06:36:21 PST ---
Created an attachment (id=4419)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4419)
Give the full directory size instead of individual file sizes
This is perhaps more de gustibus, but I think showing the total file size for
all bayes files is more useful than showing individual file sizes.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6045] masses/bayes-testing/benchmark fixes and enhancements
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6045
--- Comment #10 from Justin Mason <jm...@jmason.org> 2009-01-19 06:59:09 PST ---
(er, that's Michael Parker, not Michael Dorman ;)
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.