You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2019/08/21 09:24:05 UTC

[groovy] 05/11: Use Objects.equals to compare Boolean

This is an automated email from the ASF dual-hosted git repository.

sunlan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git

commit eb23c90ea303abf96c71a6bd617e95b93ee939a1
Author: Bo Zhang <zh...@gmail.com>
AuthorDate: Sat Aug 17 19:21:58 2019 +0800

    Use Objects.equals to compare Boolean
---
 src/main/java/groovy/lang/MetaClassImpl.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/main/java/groovy/lang/MetaClassImpl.java b/src/main/java/groovy/lang/MetaClassImpl.java
index 9d68d1c..c7ad553 100644
--- a/src/main/java/groovy/lang/MetaClassImpl.java
+++ b/src/main/java/groovy/lang/MetaClassImpl.java
@@ -107,6 +107,7 @@ import java.util.LinkedHashSet;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ConcurrentMap;
@@ -3200,7 +3201,7 @@ public class MetaClassImpl implements MetaClass, MutableMetaClass {
             MetaMethod aMethod = (MetaMethod) data[j];
             Boolean match = getMatchKindForCategory(aMethod, method);
             // true == replace
-            if (match == Boolean.TRUE) {
+            if (Objects.equals(match, Boolean.TRUE)) {
                 list.set(j, method);
                 return;
                 // null == ignore (we have a better method already)