You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "zwangsheng (via GitHub)" <gi...@apache.org> on 2023/06/02 06:57:37 UTC
[GitHub] [incubator-celeborn] zwangsheng opened a new pull request, #1535: [CELEBORN-628] Seperate Mount & Volumes Path On Kubernete Case
zwangsheng opened a new pull request, #1535:
URL: https://github.com/apache/incubator-celeborn/pull/1535
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Seperate Mount & Volumes Path On Kubernete Case
### Why are the changes needed?
See detail in https://github.com/apache/incubator-celeborn/pull/1508#discussion_r1208803085
### Does this PR introduce _any_ user-facing change?
Yes
### How was this patch tested?
Local Test
> Values.yaml
```yaml
volumes:
master:
- path: /mnt/rss_ratis
mountPath: /spark/data1
type: hostPath
size: 1Gi
worker:
- path: /mnt/disk1
mountPath: /spark/data1
type: hostPath
size: 1Gi
- path: /mnt/disk2
mountPath: /spark/data2
type: hostPath
size: 1Gi
```
>Celeborn Worker Pod
```yaml
containers:
volumeMounts:
- mountPath: /mnt/disk1
name: celeborn-worker-vol-0
- mountPath: /mnt/disk2
name: celeborn-worker-vol-1
volumes:
- hostPath:
path: /spark/data1/worker
type: DirectoryOrCreate
name: celeborn-worker-vol-0
- hostPath:
path: /spark/data2/worker
type: DirectoryOrCreate
name: celeborn-worker-vol-1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1535: [CELEBORN-628] Seperate Mount & Volumes Path On Kubernete Case
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #1535:
URL: https://github.com/apache/incubator-celeborn/pull/1535#discussion_r1214077173
##########
charts/celeborn/values.yaml:
##########
@@ -42,23 +42,29 @@ securityContext:
# - emptyDir
# - hostPath
# Note: size only works in emptyDir type
+# mountPath works in hostPath type using to set `volumes hostPath path`
# Celeborn Master will pick first volumes for store raft log
volumes:
master:
- path: /mnt/rss_ratis
+ volumePath: /mnt/rss_ratis
type: hostPath
size: 1Gi
worker:
- path: /mnt/disk1
+ volumePath: /mnt/rss_ratis
Review Comment:
LGTM, we may can change volumePath: /mnt/rss_ratis to another name such as /mnt/volume.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1535: [CELEBORN-628] Seperate Mount & Volumes Path On Kubernete Case
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1535:
URL: https://github.com/apache/incubator-celeborn/pull/1535#issuecomment-1573259681
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1535?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1535](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1535?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (62ecff8) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/4f1ca8c960eba453d6abd64a1a2beaeb28a8ecf2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4f1ca8c) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 62ecff8 differs from pull request most recent head 9354b6d. Consider uploading reports for the commit 9354b6d to get more accurate results
```diff
@@ Coverage Diff @@
## main #1535 +/- ##
=======================================
Coverage 45.91% 45.91%
=======================================
Files 158 158
Lines 9888 9888
Branches 967 967
=======================================
Hits 4539 4539
Misses 5048 5048
Partials 301 301
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zwangsheng commented on a diff in pull request #1535: [CELEBORN-628] Seperate Mount & Volumes Path On Kubernete Case
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on code in PR #1535:
URL: https://github.com/apache/incubator-celeborn/pull/1535#discussion_r1214194824
##########
charts/celeborn/values.yaml:
##########
@@ -42,23 +42,29 @@ securityContext:
# - emptyDir
# - hostPath
# Note: size only works in emptyDir type
+# mountPath works in hostPath type using to set `volumes hostPath path`
# Celeborn Master will pick first volumes for store raft log
volumes:
master:
- path: /mnt/rss_ratis
+ volumePath: /mnt/rss_ratis
type: hostPath
size: 1Gi
worker:
- path: /mnt/disk1
+ volumePath: /mnt/rss_ratis
Review Comment:
Sure, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1535: [CELEBORN-628][HELM] Separate mount & host path on hostPath case
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1535:
URL: https://github.com/apache/incubator-celeborn/pull/1535#issuecomment-1573607389
Thanks, merged to main/0.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 closed pull request #1535: [CELEBORN-628][HELM] Separate mount & host path on hostPath case
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #1535: [CELEBORN-628][HELM] Separate mount & host path on hostPath case
URL: https://github.com/apache/incubator-celeborn/pull/1535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1535: [CELEBORN-628] Seperate Mount & Volumes Path On Kubernete Case
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1535:
URL: https://github.com/apache/incubator-celeborn/pull/1535#discussion_r1214136951
##########
charts/celeborn/values.yaml:
##########
@@ -42,23 +42,29 @@ securityContext:
# - emptyDir
# - hostPath
# Note: size only works in emptyDir type
+# mountPath works in hostPath type using to set `volumes hostPath path`
# Celeborn Master will pick first volumes for store raft log
volumes:
master:
- path: /mnt/rss_ratis
+ volumePath: /mnt/rss_ratis
type: hostPath
size: 1Gi
worker:
- path: /mnt/disk1
+ volumePath: /mnt/rss_ratis
Review Comment:
can we rename use `mountPath` and `hostPath`?
##########
charts/celeborn/values.yaml:
##########
@@ -42,23 +42,29 @@ securityContext:
# - emptyDir
# - hostPath
# Note: size only works in emptyDir type
+# mountPath works in hostPath type using to set `volumes hostPath path`
# Celeborn Master will pick first volumes for store raft log
volumes:
master:
- path: /mnt/rss_ratis
+ volumePath: /mnt/rss_ratis
type: hostPath
size: 1Gi
worker:
- path: /mnt/disk1
+ volumePath: /mnt/rss_ratis
Review Comment:
can we use `mountPath` and `hostPath`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org