[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1188: MINIFICPP-1651: Added DefragmentText processor

[GitBox <gi...@apache.org>]

adamdebreceni commented on a change in pull request #1188:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1188#discussion_r730947360



##########
File path: extensions/standard-processors/processors/DefragmentText.cpp
##########
@@ -26,38 +26,38 @@
 
 namespace org::apache::nifi::minifi::processors {
 
-const core::Relationship DefragTextFlowFiles::Success("success", "Flowfiles that have no fragmented messages in them");
-const core::Relationship DefragTextFlowFiles::Failure("failure", "Flowfiles that failed the defragmentation process");
-const core::Relationship DefragTextFlowFiles::Self("__self__", "Marks the FlowFile to be owned by this processor");
+const core::Relationship DefragmentText::Success("success", "Flowfiles that have no fragmented messages in them");
+const core::Relationship DefragmentText::Failure("failure", "Flowfiles that failed the defragmentation process");
+const core::Relationship DefragmentText::Self("__self__", "Marks the FlowFile to be owned by this processor");
 
-const core::Property DefragTextFlowFiles::Pattern(
+const core::Property DefragmentText::Pattern(
     core::PropertyBuilder::createProperty("Pattern")
         ->withDescription("A regular expression to match at the start or end of messages.")
         ->withDefaultValue("")->isRequired(true)->build());
 
-const core::Property DefragTextFlowFiles::PatternLoc(
+const core::Property DefragmentText::PatternLoc(
     core::PropertyBuilder::createProperty("Pattern Location")->withDescription("Where to look for the pattern.")
         ->withAllowableValues(PatternLocation::values())
         ->withDefaultValue(toString(PatternLocation::START_OF_MESSAGE))->build());
 
 
-const core::Property DefragTextFlowFiles::MaxBufferSize(
+const core::Property DefragmentText::MaxBufferSize(
     core::PropertyBuilder::createProperty("Max Buffer Size")
         ->withDescription("The maximum buffer size, if the buffer exceeds this, it will be transferred to failure. Expected format is <size> <data unit>")
         ->withType(core::StandardValidators::get().DATA_SIZE_VALIDATOR)->build());
 
-const core::Property DefragTextFlowFiles::MaxBufferAge(
+const core::Property DefragmentText::MaxBufferAge(
     core::PropertyBuilder::createProperty("Max Buffer Age")->
         withDescription("The maximum age of a buffer after which the buffer will be transferred to failure. Expected format is <duration> <time unit>")->build());
 
-void DefragTextFlowFiles::initialize() {
+void DefragmentText::initialize() {
   std::lock_guard<std::mutex> defrag_lock(defrag_mutex_);
 
   setSupportedRelationships({Success, Failure});
   setSupportedProperties({Pattern, PatternLoc, MaxBufferAge, MaxBufferSize});
 }
 
-void DefragTextFlowFiles::onSchedule(core::ProcessContext* context, core::ProcessSessionFactory*) {
+void DefragmentText::onSchedule(core::ProcessContext* context, core::ProcessSessionFactory*) {
   gsl_Expects(context);
   std::lock_guard<std::mutex> defrag_lock(defrag_mutex_);

Review comment:
       why lock in `onSchedule` and `initialize`? at a quick glance I couldn't find another processor that does so




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org