You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/02/24 15:01:23 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #4314: HDDS-8026. Replace import from shaded Guava
adoroszlai opened a new pull request, #4314:
URL: https://github.com/apache/ozone/pull/4314
## What changes were proposed in this pull request?
Directly use Guava classes instead of the shaded ones from `ratis-thirdparty`.
https://issues.apache.org/jira/browse/HDDS-8026
## How was this patch tested?
```
rg --glob '*.java' org.apache.ratis.thirdparty.com.google.common | wc -l
```
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4262730397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #4314: HDDS-8026. Replace import from shaded Guava
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4314:
URL: https://github.com/apache/ozone/pull/4314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4314: HDDS-8026. Replace import from shaded Guava
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4314:
URL: https://github.com/apache/ozone/pull/4314#issuecomment-1444014922
Thanks @ayushtkn for the suggestion, added the restriction.
Without the import replacements:
```
[ERROR] Rule 1: org.apache.maven.plugins.enforcer.RestrictImports failed with message:
[ERROR]
[ERROR] Banned imports detected:
[ERROR]
[ERROR] Reason: Use directly from Guava
[ERROR] in file: org/apache/hadoop/hdds/utils/db/RDBStore.java
[ERROR] org.apache.ratis.thirdparty.com.google.common.annotations.VisibleForTesting (Line: 45, Matched by: org.apache.ratis.thirdparty.com.google.common.**)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4314: HDDS-8026. Replace import from shaded Guava
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4314:
URL: https://github.com/apache/ozone/pull/4314#issuecomment-1444575446
Thanks @ayushtkn, @kerneltime for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org