You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2013/03/16 01:24:12 UTC
[jira] [Commented] (HBASE-8125) hbase-7435 broke upgrade from
0.94.2. 0.94.3 on hadoop < 1.0.x
[ https://issues.apache.org/jira/browse/HBASE-8125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604033#comment-13604033 ]
Ted Yu commented on HBASE-8125:
-------------------------------
One solution is to call decompressor.getClass().getAnnotations() instead of calling isAnnotationPresent().
We can iterate through the Annotations returned and see if DoNotPool is present.
I can put up a patch if the above approach is accepted.
> hbase-7435 broke upgrade from 0.94.2. 0.94.3 on hadoop < 1.0.x
> --------------------------------------------------------------
>
> Key: HBASE-8125
> URL: https://issues.apache.org/jira/browse/HBASE-8125
> Project: HBase
> Issue Type: Bug
> Reporter: stack
>
> From some friends of ours at dropbox:
> Index: src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java
> ===================================================================
> --- src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java (revision 1425723)
> +++ src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java (working copy)
> @@ -33,6 +33,7 @@
> import org.apache.hadoop.io.compress.CompressionOutputStream;
> import org.apache.hadoop.io.compress.Compressor;
> import org.apache.hadoop.io.compress.Decompressor;
> +import org.apache.hadoop.io.compress.DoNotPool;
> import org.apache.hadoop.io.compress.GzipCodec;
> import org.apache.hadoop.io.compress.DefaultCodec;
> import org.apache.hadoop.util.ReflectionUtils;
> @@ -308,6 +309,9 @@
> public void returnDecompressor(Decompressor decompressor) {
> if (decompressor != null) {
> CodecPool.returnDecompressor(decompressor);
> + if (decompressor.getClass().isAnnotationPresent(DoNotPool.class)) {
> + decompressor.end();
> + }
> }
> }
> breaks compatibility with hadoop-0.20.2-cdh3u2.
> +import org.apache.hadoop.io.compress.DoNotPool;
> does not exist in that version of hadoop.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira