You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/10/14 18:17:16 UTC

[GitHub] [samza] atoomula commented on a change in pull request #1186: SAMZA-2347: Samza Sql - Fix AvroTypeFactoryImpl to properly denote a field as optional and nullable.

atoomula commented on a change in pull request #1186: SAMZA-2347: Samza Sql - Fix AvroTypeFactoryImpl to properly denote a field as optional and nullable.
URL: https://github.com/apache/samza/pull/1186#discussion_r334604821
 
 

 ##########
 File path: samza-sql/src/test/java/org/apache/samza/sql/avro/schemas/ComplexRecord.avsc
 ##########
 @@ -31,13 +31,13 @@
         {
             "name": "bool_value",
             "doc": "Boolean Value.",
-            "type": ["null", "boolean"]
+            "type": "boolean",
+            "default": null
 
 Review comment:
   That's a good catch. For primitive types, the default cannot be null unless it is of type union. I have changed the default to false.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services