You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2011/03/28 10:10:01 UTC
[vote] release wicket 1.4.17
On behalf of Igor Vaynberg:
This vote is to release wicket 1.4.17. This is a bugfix release on the
1.4.x (stable) branch.
Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.17/
Artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.17/dist
Maven repo:
https://repository.apache.org/content/repositories/orgapachewicket-045/
Changelog:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316219
This vote ends Thursday, March 31st at 1:00am (GMT-8)
Please test the release and offer your vote.
The Wicket team
Re: [vote] release wicket 1.4.17
Posted by Martin Grigorov <mg...@apache.org>.
+1
On Mon, Mar 28, 2011 at 11:10 AM, Martin Grigorov <mg...@apache.org>wrote:
> On behalf of Igor Vaynberg:
>
> This vote is to release wicket 1.4.17. This is a bugfix release on the
> 1.4.x (stable) branch.
>
> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.17/
> Artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.17/dist
> Maven repo:
> https://repository.apache.org/content/repositories/orgapachewicket-045/
> Changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316219
>
> This vote ends Thursday, March 31st at 1:00am (GMT-8)
>
> Please test the release and offer your vote.
>
> The Wicket team
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com <http://jweekend.com/>
Re: [vote] release wicket 1.4.17
Posted by Martin Grigorov <mg...@apache.org>.
Can you please create a ticket for this?
Thanks!
On Fri, Apr 1, 2011 at 1:47 AM, tetsuo <ro...@gmail.com> wrote:
> -1 (?)
>
> I've just found a bug in the new inline enclosure feature. It's not a
> showstopper, but probably is trivial enough to get corrected before
> the release.
>
> If you setup a IComponentInstantiationListener that calls
> setOutputMarkupId(true) to every component, the tags with the
> enclosure attribute don't get re-rendered on ajax requests, because
> the generated IDs from the HTML placeholder and the Ajax response
> don't match.
>
> Code:
>
> public class App extends WebApplication {
>
> @Override
> protected void init() {
> addComponentInstantiationListener(new
> IComponentInstantiationListener() {
> public void onInstantiation(Component component) {
> component.setOutputMarkupId(true);
> }
> });
> }
>
> @Override
> public Class<? extends Page> getHomePage() {
> return HomePage.class;
> }
>
> }
>
>
> public class HomePage extends WebPage {
> public HomePage() {
> final Label label = new Label("label", "VISIBLE!");
> add(label.setVisible(false).setOutputMarkupId(true));
>
> add(new AjaxLink<Void>("link") {
> @Override
> public void onClick(AjaxRequestTarget target) {
> label.setVisible(!label.isVisible());
> target.addComponent(label);
> }
> });
> }
> }
>
> <html xmlns:wicket="http://wicket.apache.org">
> <body>
> <a wicket:id="link">Clique!</a>
> <div wicket:enclosure="label">
> <hr/>
> <h1 wicket:id="label"></h1>
> <hr/>
> </div>
> </body>
> </html>
>
> On Thu, Mar 31, 2011 at 4:54 AM, Martijn Dashorst
> <ma...@gmail.com> wrote:
> > +1
> >
> > On Wed, Mar 30, 2011 at 9:11 PM, Juergen Donnerstag
> > <ju...@gmail.com> wrote:
> >> +1
> >>
> >> Juergen
> >>
> >> On Wed, Mar 30, 2011 at 6:40 PM, Jan Kriesten
> >> <kr...@mail.footprint.de> wrote:
> >>>
> >>>
> >>>> This vote is to release wicket 1.4.17. This is a bugfix release on the
> >>>> 1.4.x (stable) branch.
> >>>
> >>> +1
> >>>
> >>> Best regards, --- Jan.
> >>>
> >>>
> >>
> >
> >
> >
> > --
> > Become a Wicket expert, learn from the best: http://wicketinaction.com
> >
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com <http://jweekend.com/>
Re: [vote] release wicket 1.4.17
Posted by tetsuo <ro...@gmail.com>.
-1 (?)
I've just found a bug in the new inline enclosure feature. It's not a
showstopper, but probably is trivial enough to get corrected before
the release.
If you setup a IComponentInstantiationListener that calls
setOutputMarkupId(true) to every component, the tags with the
enclosure attribute don't get re-rendered on ajax requests, because
the generated IDs from the HTML placeholder and the Ajax response
don't match.
Code:
public class App extends WebApplication {
@Override
protected void init() {
addComponentInstantiationListener(new
IComponentInstantiationListener() {
public void onInstantiation(Component component) {
component.setOutputMarkupId(true);
}
});
}
@Override
public Class<? extends Page> getHomePage() {
return HomePage.class;
}
}
public class HomePage extends WebPage {
public HomePage() {
final Label label = new Label("label", "VISIBLE!");
add(label.setVisible(false).setOutputMarkupId(true));
add(new AjaxLink<Void>("link") {
@Override
public void onClick(AjaxRequestTarget target) {
label.setVisible(!label.isVisible());
target.addComponent(label);
}
});
}
}
<html xmlns:wicket="http://wicket.apache.org">
<body>
<a wicket:id="link">Clique!</a>
<div wicket:enclosure="label">
<hr/>
<h1 wicket:id="label"></h1>
<hr/>
</div>
</body>
</html>
On Thu, Mar 31, 2011 at 4:54 AM, Martijn Dashorst
<ma...@gmail.com> wrote:
> +1
>
> On Wed, Mar 30, 2011 at 9:11 PM, Juergen Donnerstag
> <ju...@gmail.com> wrote:
>> +1
>>
>> Juergen
>>
>> On Wed, Mar 30, 2011 at 6:40 PM, Jan Kriesten
>> <kr...@mail.footprint.de> wrote:
>>>
>>>
>>>> This vote is to release wicket 1.4.17. This is a bugfix release on the
>>>> 1.4.x (stable) branch.
>>>
>>> +1
>>>
>>> Best regards, --- Jan.
>>>
>>>
>>
>
>
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com
>
Re: [vote] release wicket 1.4.17
Posted by Martijn Dashorst <ma...@gmail.com>.
+1
On Wed, Mar 30, 2011 at 9:11 PM, Juergen Donnerstag
<ju...@gmail.com> wrote:
> +1
>
> Juergen
>
> On Wed, Mar 30, 2011 at 6:40 PM, Jan Kriesten
> <kr...@mail.footprint.de> wrote:
>>
>>
>>> This vote is to release wicket 1.4.17. This is a bugfix release on the
>>> 1.4.x (stable) branch.
>>
>> +1
>>
>> Best regards, --- Jan.
>>
>>
>
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: [vote] release wicket 1.4.17
Posted by Juergen Donnerstag <ju...@gmail.com>.
+1
Juergen
On Wed, Mar 30, 2011 at 6:40 PM, Jan Kriesten
<kr...@mail.footprint.de> wrote:
>
>
>> This vote is to release wicket 1.4.17. This is a bugfix release on the
>> 1.4.x (stable) branch.
>
> +1
>
> Best regards, --- Jan.
>
>
Re: [vote] release wicket 1.4.17
Posted by Jan Kriesten <kr...@mail.footprint.de>.
> This vote is to release wicket 1.4.17. This is a bugfix release on the
> 1.4.x (stable) branch.
+1
Best regards, --- Jan.
Re: [vote] release wicket 1.4.17
Posted by Martin Grigorov <mg...@apache.org>.
On Mon, Mar 28, 2011 at 6:59 PM, Pedro Santos <pe...@gmail.com> wrote:
> +1 just compiled the branch, played on wicket-examples, it is all fine.
> As a side note, I played a bit at wicket-examples on wicket stuff also and
> some repeater examples are not working. e.g. OrderedRepeatingView example
> at http://wicketstuff.org/wicket14/repeater/ After the 1.4.17 being
> released
> I will test it again.
>
> I think wicketstuff.org/wicket14 is not updated since a while.
I try to keep wicket-library.com/wicket updated with 1.5.x releases, but I
think Johan is not doing this for wicketstuff.org.
>
> On Mon, Mar 28, 2011 at 5:10 AM, Martin Grigorov <mgrigorov@apache.org
> >wrote:
>
> > On behalf of Igor Vaynberg:
> >
> > This vote is to release wicket 1.4.17. This is a bugfix release on the
> > 1.4.x (stable) branch.
> >
> > Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.17/
> > Artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.17/dist
> > Maven repo:
> > https://repository.apache.org/content/repositories/orgapachewicket-045/
> > Changelog:
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316219
> >
> > This vote ends Thursday, March 31st at 1:00am (GMT-8)
> >
> > Please test the release and offer your vote.
> >
> > The Wicket team
> >
>
>
>
> --
> Pedro Henrique Oliveira dos Santos
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com <http://jweekend.com/>
Re: [vote] release wicket 1.4.17
Posted by Pedro Santos <pe...@gmail.com>.
+1 just compiled the branch, played on wicket-examples, it is all fine.
As a side note, I played a bit at wicket-examples on wicket stuff also and
some repeater examples are not working. e.g. OrderedRepeatingView example
at http://wicketstuff.org/wicket14/repeater/ After the 1.4.17 being released
I will test it again.
On Mon, Mar 28, 2011 at 5:10 AM, Martin Grigorov <mg...@apache.org>wrote:
> On behalf of Igor Vaynberg:
>
> This vote is to release wicket 1.4.17. This is a bugfix release on the
> 1.4.x (stable) branch.
>
> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.17/
> Artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.17/dist
> Maven repo:
> https://repository.apache.org/content/repositories/orgapachewicket-045/
> Changelog:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316219
>
> This vote ends Thursday, March 31st at 1:00am (GMT-8)
>
> Please test the release and offer your vote.
>
> The Wicket team
>
--
Pedro Henrique Oliveira dos Santos
Re: [vote] release wicket 1.4.17
Posted by Johan Compagner <jc...@gmail.com>.
+1 release
On Mon, Mar 28, 2011 at 10:10, Martin Grigorov <mg...@apache.org> wrote:
> On behalf of Igor Vaynberg:
>
> This vote is to release wicket 1.4.17. This is a bugfix release on the
> 1.4.x (stable) branch.
>
> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.17/
> Artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.17/dist
> Maven repo:
> https://repository.apache.org/content/repositories/orgapachewicket-045/
> Changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316219
>
> This vote ends Thursday, March 31st at 1:00am (GMT-8)
>
> Please test the release and offer your vote.
>
> The Wicket team
>
Re: [vote] release wicket 1.4.17
Posted by Igor Vaynberg <ig...@gmail.com>.
+1 to release
-igor
On Mon, Mar 28, 2011 at 1:10 AM, Martin Grigorov <mg...@apache.org> wrote:
> On behalf of Igor Vaynberg:
>
> This vote is to release wicket 1.4.17. This is a bugfix release on the
> 1.4.x (stable) branch.
>
> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.17/
> Artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.17/dist
> Maven repo:
> https://repository.apache.org/content/repositories/orgapachewicket-045/
> Changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316219
>
> This vote ends Thursday, March 31st at 1:00am (GMT-8)
>
> Please test the release and offer your vote.
>
> The Wicket team
>
Re: [vote] release wicket 1.4.17
Posted by Igor Vaynberg <ig...@gmail.com>.
Vote is now closed and has passed with 7 binding +1 and one nonbinding
-1 vote. Ive already started the process of uploading to mirrors, so
the fix for the problem tetsuo found will have to go into the next
release.
-igor
On Mon, Mar 28, 2011 at 1:10 AM, Martin Grigorov <mg...@apache.org> wrote:
> On behalf of Igor Vaynberg:
>
> This vote is to release wicket 1.4.17. This is a bugfix release on the
> 1.4.x (stable) branch.
>
> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.17/
> Artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.17/dist
> Maven repo:
> https://repository.apache.org/content/repositories/orgapachewicket-045/
> Changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316219
>
> This vote ends Thursday, March 31st at 1:00am (GMT-8)
>
> Please test the release and offer your vote.
>
> The Wicket team
>