You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/15 14:34:15 UTC

[GitHub] [incubator-mxnet] leezu opened a new pull request #17326: Fix IOT Devices section of Get Started page

leezu opened a new pull request #17326: Fix IOT Devices section of Get Started page
URL: https://github.com/apache/incubator-mxnet/pull/17326
 
 
   ## Description ##
   - Add missing iot urlParam
   - Fix use of potentially undefined variables. For example, the &iot=
     url parameter is typically unspecified, causing use of undefined
     variable javascript error leading to an empty page.
   
   Example of broken IOT Devices section (Devices can't be selected)
   
   ![image](https://user-images.githubusercontent.com/946903/72442167-492fe680-37ac-11ea-8af2-dca3e05113ae.png)
   
   ### Changes ###
   - [X] Fix IOT Devices section of Get Started page

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] szha merged pull request #17326: Fix IOT Devices section of Get Started page

Posted by GitBox <gi...@apache.org>.
szha merged pull request #17326: Fix IOT Devices section of Get Started page
URL: https://github.com/apache/incubator-mxnet/pull/17326
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] codecov-io commented on issue #17326: Fix IOT Devices section of Get Started page

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #17326: Fix IOT Devices section of Get Started page
URL: https://github.com/apache/incubator-mxnet/pull/17326#issuecomment-575277424
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-mxnet/pull/17326?src=pr&el=h1) Report
   > Merging [#17326](https://codecov.io/gh/apache/incubator-mxnet/pull/17326?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-mxnet/commit/e58623ce34bee79d4cde1c83ea2140c313f6a93a?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-mxnet/pull/17326/graphs/tree.svg?width=650&token=7GtR5LCDtb&height=150&src=pr)](https://codecov.io/gh/apache/incubator-mxnet/pull/17326?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #17326   +/-   ##
   =======================================
     Coverage    67.5%    67.5%           
   =======================================
     Files         275      275           
     Lines       31227    31227           
     Branches     4721     4721           
   =======================================
     Hits        21080    21080           
     Misses       8780     8780           
     Partials     1367     1367
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-mxnet/pull/17326?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-mxnet/pull/17326?src=pr&el=footer). Last update [e58623c...4cfeff5](https://codecov.io/gh/apache/incubator-mxnet/pull/17326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services