You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nuttx.apache.org by Sebastien Lorquet <se...@lorquet.fr> on 2023/03/08 11:58:07 UTC
DISCUSSION - Usage of mailing lists for apache projects
Apache projects are required to use mailing lists for long term archival
purposes.
It seems to me that this project is avoiding that rule and moved all
development to github
This is in contradiction with the Apache project rules.
I request clarification on this situation and requirement (instead of
just asserting it), including a review by the apache boards.
If it is proved that development happens primarily in github and not
here I will request the following:
-every people committing patches and submitting pull request to be
registered on the mailing list so they are able to reply to questions
-forwarding of all pull requests traffic to the mailing list
For two reasons: (1) Archival purposes, and (2) open discussions with
members that follow Apache Foundation mailing list rules and do not take
part in github.
Thank you
Sebastien
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Gregory Nutt <sp...@gmail.com>.
On 3/8/2023 9:17 AM, Gregory Nutt wrote:
>
>> ``There's a saying here that "if it didn't happen on list, it didn't
>> happen." '' (yes, probably from someone that develops or sales a
>> mailing list software) Hehehe
>
> No. That is official ASF policy summarized as a motto:
>
> https://community.apache.org/newbiefaq.html#NewbieFAQ-IsthereaCodeofConductforApacheprojects?
>
>
>
Better reference: https://incubator.apache.org/guides/committer.html
Mailing Lists
Everything inside the Apache world needs to occur /asynchronously /and
be archived. Email is currently the best platform for this. As some
people say, 'If it isn’t on the mailing list, it didn’t happen.'
/Decisions only get made on public Apache email lists, not anywhere
offlist/ such as IRC, IM, or private emails. If a PMC or Apache
committee makes decisions elsewhere, they need to bring the decision
back to the appropriate email list.
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Gregory Nutt <sp...@gmail.com>.
> ``There's a saying here that "if it didn't happen on list, it didn't
> happen." '' (yes, probably from someone that develops or sales a
> mailing list software) Hehehe
No. That is official ASF policy summarized as a motto:
https://community.apache.org/newbiefaq.html#NewbieFAQ-IsthereaCodeofConductforApacheprojects?
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by "Alan C. Assis" <ac...@gmail.com>.
Hi Nathan,
``There's a saying here that "if it didn't happen on list, it didn't
happen." '' (yes, probably from someone that develops or sales a
mailing list software) Hehehe
I think we need to have a middle ground, if every single commit needs
to "happen on list, to be considered as happen", it will be very
counter productive, counter intuitive.
Some discussion should happen here in the mailing list before
appearing on GitHub, mostly breaking change features for example.
BTW, anyone is invited to review the PRs on GitHub and if he/she think
it is relevant, then start a discussion here.
BR,
Alan
On 3/8/23, Nathan Hartman <ha...@gmail.com> wrote:
> I do think that as a project community, this is an important discussion to
> have.
>
> There are significant changes taking place regularly. I am in favor of
> improving the code, improving our POSIX-like / Linux-like / Unix-like
> compliance as much as is feasible while supporting deeply embedded and
> small MCU architectures.
>
> But I, too, think we should have more technical discussions on the
> dev@ mailing list where NuttX users can participate and give their
> insights, too.
>
> I appreciate the work everyone is doing here. That includes Xiaomi of
> course, who are doing a TON of work. Now, I have a feeling that Xiaomi
> developers are probably discussing/coordinating their work, but that
> isn't happening on list, in public, which is an important part of The
> Apache Way. There's a saying here that "if it didn't happen on list,
> it didn't happen." Moving such discussions to the dev@ list will
> benefit NuttX and Xiaomi and the whole community mutually. I don't
> want to single out Xiaomi here; all companies that are having internal
> discussions about their NuttX development should have those
> discussions on list.
>
> At an absolute minimum, there should be a discussion on-list when a
> proposed change will make backwards-incompatible changes, break builds
> for out-of-tree boards, change the scripting interface to the build
> system, or require other mitigations by users that create nasty
> surprises. In the email, please add a link to the PR if the code is
> already written, to increase eyeballs looking at it.
>
> Cheers
> Nathan
>
> On Wed, Mar 8, 2023 at 9:04 AM Sebastien Lorquet <se...@lorquet.fr>
> wrote:
>>
>> I dont think your point of view is very realistic. You seem to be
>> turning the situation into something that pleases you but is not really
>> compatible with what can be observed from outside.
>>
>> In the archive for 2023 there are 2035 topics, I just overlooked more
>> than 600 of them and ALL of them are just copies of github messages. And
>> this is normal, because this is unusable.
>>
>> Also, I cannot actively review ALL the hundreds of pull requests that
>> are regularly sent by large companies.
>>
>> I am primarily a user, that sometimes sends small contributions.
>>
>> And I am unhappy when I see that other people were careless with nice
>> code and do whatever they want for their own agenda without any
>> consideration for other users.
>>
>> To be honest I dont fully understand why SO MANY changes are required to
>> core OS features that should be stable.
>>
>> There need to be some triage when a new pull request is sent, its
>> severity evaluated by someone who is NOT in the company of the original
>> contributor, and if severe, it has to be approved on the mailing list. I
>> cannot do that alone, even if I try.
>>
>> At this point do you realize that more than !~90ish% of changes seem to
>> come from xiaomi developers and most of these are approved by xiaoxiang
>> alone?
>>
>> Because this HAS to be said. They send overwhelming numbers
>> contributions that cannot be possibly understood as a whole, there is no
>> clear agenda, they add whatever they like with no roadmap and no review
>> from other users that may have other uses.
>>
>> This has to be under control somehow. I believe even you Alan are not
>> aware of the amount of code that enters nuttx. No one can be now.
>>
>> Sebastien
>>
>>
>> Le 08/03/2023 à 14:39, Alan C. Assis a écrit :
>> > Hi Sebastien,
>> >
>> > Yes, that commit list is mostly for people who don't want to use
>> > github but still wanting to see what is going on.
>> >
>> > Sometimes when a very important PR raises some concern on GitHub PR,
>> > people post their concern he, it already happened many times.
>> >
>> > But again: the best way to guarantee that current changes please you
>> > is to keep actively reviewing the PRs and contributing to the project.
>> >
>> > BR,
>> >
>> > Alan
>> >
>> > On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>> >> Hi,
>> >>
>> >> I had a look and this mailing list is not made for human consumption.
>> >>
>> >> No one has ever sent a message on it manually, right?
>> >>
>> >> In practice, important changes are still NOT discussed on the DEV
>> >> mailing list.
>> >>
>> >> You said yourself that "all development has moved to github".
>> >>
>> >> As soon as automated tests are passed, every commit is considered with
>> >> a
>> >> similar level of importance, however this is clearly not the case.
>> >>
>> >> Sebastien
>> >>
>> >> Le 08/03/2023 à 13:21, Alan C. Assis a écrit :
>> >>> HI Sebastien,
>> >>>
>> >>> It is already done, you just need to subscribe to
>> >>> https://lists.apache.org/list.html?commits@nuttx.apache.org to
>> >>> receive
>> >>> all commits messages and discussions.
>> >>>
>> >>> Everything is archived on apache side!
>> >>>
>> >>> BR,
>> >>>
>> >>> Alan
>> >>>
>> >>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>> >>>> Apache projects are required to use mailing lists for long term
>> >>>> archival
>> >>>> purposes.
>> >>>>
>> >>>> It seems to me that this project is avoiding that rule and moved all
>> >>>> development to github
>> >>>>
>> >>>> This is in contradiction with the Apache project rules.
>> >>>>
>> >>>>
>> >>>> I request clarification on this situation and requirement (instead
>> >>>> of
>> >>>> just asserting it), including a review by the apache boards.
>> >>>>
>> >>>>
>> >>>> If it is proved that development happens primarily in github and not
>> >>>> here I will request the following:
>> >>>>
>> >>>> -every people committing patches and submitting pull request to be
>> >>>> registered on the mailing list so they are able to reply to
>> >>>> questions
>> >>>>
>> >>>> -forwarding of all pull requests traffic to the mailing list
>> >>>>
>> >>>> For two reasons: (1) Archival purposes, and (2) open discussions
>> >>>> with
>> >>>> members that follow Apache Foundation mailing list rules and do not
>> >>>> take
>> >>>> part in github.
>> >>>>
>> >>>>
>> >>>> Thank you
>> >>>>
>> >>>> Sebastien
>> >>>>
>> >>>>
>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Nathan Hartman <ha...@gmail.com>.
I do think that as a project community, this is an important discussion to have.
There are significant changes taking place regularly. I am in favor of
improving the code, improving our POSIX-like / Linux-like / Unix-like
compliance as much as is feasible while supporting deeply embedded and
small MCU architectures.
But I, too, think we should have more technical discussions on the
dev@ mailing list where NuttX users can participate and give their
insights, too.
I appreciate the work everyone is doing here. That includes Xiaomi of
course, who are doing a TON of work. Now, I have a feeling that Xiaomi
developers are probably discussing/coordinating their work, but that
isn't happening on list, in public, which is an important part of The
Apache Way. There's a saying here that "if it didn't happen on list,
it didn't happen." Moving such discussions to the dev@ list will
benefit NuttX and Xiaomi and the whole community mutually. I don't
want to single out Xiaomi here; all companies that are having internal
discussions about their NuttX development should have those
discussions on list.
At an absolute minimum, there should be a discussion on-list when a
proposed change will make backwards-incompatible changes, break builds
for out-of-tree boards, change the scripting interface to the build
system, or require other mitigations by users that create nasty
surprises. In the email, please add a link to the PR if the code is
already written, to increase eyeballs looking at it.
Cheers
Nathan
On Wed, Mar 8, 2023 at 9:04 AM Sebastien Lorquet <se...@lorquet.fr> wrote:
>
> I dont think your point of view is very realistic. You seem to be
> turning the situation into something that pleases you but is not really
> compatible with what can be observed from outside.
>
> In the archive for 2023 there are 2035 topics, I just overlooked more
> than 600 of them and ALL of them are just copies of github messages. And
> this is normal, because this is unusable.
>
> Also, I cannot actively review ALL the hundreds of pull requests that
> are regularly sent by large companies.
>
> I am primarily a user, that sometimes sends small contributions.
>
> And I am unhappy when I see that other people were careless with nice
> code and do whatever they want for their own agenda without any
> consideration for other users.
>
> To be honest I dont fully understand why SO MANY changes are required to
> core OS features that should be stable.
>
> There need to be some triage when a new pull request is sent, its
> severity evaluated by someone who is NOT in the company of the original
> contributor, and if severe, it has to be approved on the mailing list. I
> cannot do that alone, even if I try.
>
> At this point do you realize that more than !~90ish% of changes seem to
> come from xiaomi developers and most of these are approved by xiaoxiang
> alone?
>
> Because this HAS to be said. They send overwhelming numbers
> contributions that cannot be possibly understood as a whole, there is no
> clear agenda, they add whatever they like with no roadmap and no review
> from other users that may have other uses.
>
> This has to be under control somehow. I believe even you Alan are not
> aware of the amount of code that enters nuttx. No one can be now.
>
> Sebastien
>
>
> Le 08/03/2023 à 14:39, Alan C. Assis a écrit :
> > Hi Sebastien,
> >
> > Yes, that commit list is mostly for people who don't want to use
> > github but still wanting to see what is going on.
> >
> > Sometimes when a very important PR raises some concern on GitHub PR,
> > people post their concern he, it already happened many times.
> >
> > But again: the best way to guarantee that current changes please you
> > is to keep actively reviewing the PRs and contributing to the project.
> >
> > BR,
> >
> > Alan
> >
> > On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
> >> Hi,
> >>
> >> I had a look and this mailing list is not made for human consumption.
> >>
> >> No one has ever sent a message on it manually, right?
> >>
> >> In practice, important changes are still NOT discussed on the DEV
> >> mailing list.
> >>
> >> You said yourself that "all development has moved to github".
> >>
> >> As soon as automated tests are passed, every commit is considered with a
> >> similar level of importance, however this is clearly not the case.
> >>
> >> Sebastien
> >>
> >> Le 08/03/2023 à 13:21, Alan C. Assis a écrit :
> >>> HI Sebastien,
> >>>
> >>> It is already done, you just need to subscribe to
> >>> https://lists.apache.org/list.html?commits@nuttx.apache.org to receive
> >>> all commits messages and discussions.
> >>>
> >>> Everything is archived on apache side!
> >>>
> >>> BR,
> >>>
> >>> Alan
> >>>
> >>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
> >>>> Apache projects are required to use mailing lists for long term archival
> >>>> purposes.
> >>>>
> >>>> It seems to me that this project is avoiding that rule and moved all
> >>>> development to github
> >>>>
> >>>> This is in contradiction with the Apache project rules.
> >>>>
> >>>>
> >>>> I request clarification on this situation and requirement (instead of
> >>>> just asserting it), including a review by the apache boards.
> >>>>
> >>>>
> >>>> If it is proved that development happens primarily in github and not
> >>>> here I will request the following:
> >>>>
> >>>> -every people committing patches and submitting pull request to be
> >>>> registered on the mailing list so they are able to reply to questions
> >>>>
> >>>> -forwarding of all pull requests traffic to the mailing list
> >>>>
> >>>> For two reasons: (1) Archival purposes, and (2) open discussions with
> >>>> members that follow Apache Foundation mailing list rules and do not take
> >>>> part in github.
> >>>>
> >>>>
> >>>> Thank you
> >>>>
> >>>> Sebastien
> >>>>
> >>>>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Xiang Xiao <xi...@gmail.com>.
On Wed, Mar 8, 2023 at 10:05 PM Sebastien Lorquet <se...@lorquet.fr>
wrote:
> I dont think your point of view is very realistic. You seem to be
> turning the situation into something that pleases you but is not really
> compatible with what can be observed from outside.
>
> In the archive for 2023 there are 2035 topics, I just overlooked more
> than 600 of them and ALL of them are just copies of github messages. And
> this is normal, because this is unusable.
>
> Also, I cannot actively review ALL the hundreds of pull requests that
> are regularly sent by large companies.
>
> I am primarily a user, that sometimes sends small contributions.
>
> And I am unhappy when I see that other people were careless with nice
> code and do whatever they want for their own agenda without any
> consideration for other users.
>
> To be honest I dont fully understand why SO MANY changes are required to
> core OS features that should be stable.
>
>
Here is the commit summary for nuttx and zephyr:
https://github.com/apache/nuttx/graphs/contributors
https://github.com/zephyrproject-rtos/zephyr/graphs/contributors
You can see that nuttx is far behind than zephyr.
> There need to be some triage when a new pull request is sent, its
> severity evaluated by someone who is NOT in the company of the original
> contributor, and if severe, it has to be approved on the mailing list. I
> cannot do that alone, even if I try.
>
>
There is no real difference whether you review the change from email or
github. The important thing is that you have to take the time to review and
approve/reject the change, So, I would suggest that you spend half an hour
every day reviewing and commenting on the patch.
> At this point do you realize that more than !~90ish% of changes seem to
> come from xiaomi developers and most of these are approved by xiaoxiang
> alone?
>
Here is a summary Alan collected recently:
https://www.mail-archive.com/dev@nuttx.apache.org/msg08967.html
Xiaomi makes around 50% contrution, not 90%.
Because this HAS to be said. They send overwhelming numbers
> contributions that cannot be possibly understood as a whole, there is no
> clear agenda, they add whatever they like with no roadmap and no review
> from other users that may have other uses.
>
> This has to be under control somehow. I believe even you Alan are not
> aware of the amount of code that enters nuttx. No one can be now.
>
>
First, most of my changes are reviewed and merged by non-xiaomi committers.
Other patches from xiaomi normally are reviewed and merged by non-xiaomi
committers.
In rare cases, I may review and merge the patch if it is a trivial fix or
not be reviewed for more than three days.
But I will review carefully regardless the patch come from xiaomi or
others, Here is one example:
https://github.com/apache/nuttx/pull/8619
> Sebastien
>
>
> Le 08/03/2023 à 14:39, Alan C. Assis a écrit :
> > Hi Sebastien,
> >
> > Yes, that commit list is mostly for people who don't want to use
> > github but still wanting to see what is going on.
> >
> > Sometimes when a very important PR raises some concern on GitHub PR,
> > people post their concern he, it already happened many times.
> >
> > But again: the best way to guarantee that current changes please you
> > is to keep actively reviewing the PRs and contributing to the project.
> >
> > BR,
> >
> > Alan
> >
> > On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
> >> Hi,
> >>
> >> I had a look and this mailing list is not made for human consumption.
> >>
> >> No one has ever sent a message on it manually, right?
> >>
> >> In practice, important changes are still NOT discussed on the DEV
> >> mailing list.
> >>
> >> You said yourself that "all development has moved to github".
> >>
> >> As soon as automated tests are passed, every commit is considered with a
> >> similar level of importance, however this is clearly not the case.
> >>
> >> Sebastien
> >>
> >> Le 08/03/2023 à 13:21, Alan C. Assis a écrit :
> >>> HI Sebastien,
> >>>
> >>> It is already done, you just need to subscribe to
> >>> https://lists.apache.org/list.html?commits@nuttx.apache.org to receive
> >>> all commits messages and discussions.
> >>>
> >>> Everything is archived on apache side!
> >>>
> >>> BR,
> >>>
> >>> Alan
> >>>
> >>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
> >>>> Apache projects are required to use mailing lists for long term
> archival
> >>>> purposes.
> >>>>
> >>>> It seems to me that this project is avoiding that rule and moved all
> >>>> development to github
> >>>>
> >>>> This is in contradiction with the Apache project rules.
> >>>>
> >>>>
> >>>> I request clarification on this situation and requirement (instead of
> >>>> just asserting it), including a review by the apache boards.
> >>>>
> >>>>
> >>>> If it is proved that development happens primarily in github and not
> >>>> here I will request the following:
> >>>>
> >>>> -every people committing patches and submitting pull request to be
> >>>> registered on the mailing list so they are able to reply to questions
> >>>>
> >>>> -forwarding of all pull requests traffic to the mailing list
> >>>>
> >>>> For two reasons: (1) Archival purposes, and (2) open discussions with
> >>>> members that follow Apache Foundation mailing list rules and do not
> take
> >>>> part in github.
> >>>>
> >>>>
> >>>> Thank you
> >>>>
> >>>> Sebastien
> >>>>
> >>>>
>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Sebastien Lorquet <se...@lorquet.fr>.
Hi,
I am really certain "people" have the best intention, but it would be
even better if they shared these with the rest of the community.
And I am not talking about code review.
You cant review code if you dont know there IS serious code to review.
And we dont need to review every typo.
I am talking in decisions that will have a long lasting effect on
everyone and will render current doc obsolete.
Like, it would have been great to read a thread like this:
---
Hi,
We believe the make output is too verbose and we have this PR to make it
silent.
What do you think about this and how should we integrate this feature?
We plan to use V=0 to keep the previous behaviour, do you think we
should use a config setting instead?
Please tell us what you think, the pr link is here: <url>.
Best regards etc
---
This is not code review. This is not issues.
It's not tools either, it's people.
I do not want a "mailing list experience". I want shared discussion
about project design and topics we all care about, not just as coding
machines typing faster than light.
It is evident that the commit mailing list is just unusable for any of this.
Code changes should be more than "I request code, please pull kthxbye,
approved, done"
I hope this discussion gets positive contributions so we come up with
something better than today.
Again this is not just about more automated tools and processes.
Sebastien.
Le 08/03/2023 à 17:30, Brennan Ashton a écrit :
> This whole thread really bums me out. We really should be assuming people
> are acting with best intentions, rather than accusing of ulterior motives.
> If there are changes that you have concerns about people tend to be very
> reasonable about explaining and if we need to revert something or change
> something, that's fine too.
>
> Tossing around ideas on the mailing list is totally fine, but when it comes
> to reviewing code I don't see anything wrong with that happening in PR
> reviews next to the code. And to be honest using Issues is also a much much
> more pleasant experience.
>
> If you want the mailing list experience you can still get that by clicking
> subscribe (which is what I do to get the open flood gates of content).
> There is also the commit mailing list that does archive all of that
> content.
>
> People have been better about tagging things that may be breaking changes,
> but things do slip though. This was even the case when Greg reviewed all
> code. And sometimes things were reverted, sometimes not.
>
> What I would like to see is that people put a little bit of though into the
> testing box. For example Lup does an excellent job with this
>
> https://github.com/apache/nuttx/pull/7944
>
> We are still growing as a project and people being more active in the
> review process will go a long way, but we need the people to do that. While
> I have not committed much code in sometime, I still try to scan through the
> PRs in my inbox for content of interest.
>
> --Brennan
>
> On Wed, Mar 8, 2023, 7:54 AM Sebastien Lorquet <se...@lorquet.fr> wrote:
>
>> I tend to disagree.
>>
>>
>> You have extreme views that all commits need to be discussed. That is
>> false.
>>
>> What need to be discussed is much subtle.
>>
>> We need to have discussion whenever ANYONE has a doubt about something
>> that is happening on github BEFORE this is committed.
>>
>> Xiaomi (and other companies, but xiaomi is very representative of this)
>> would have more reviewers if commits that ACTUALLY need reviews were
>> discussed on the list.
>>
>> I have done so every time I planned to push more than trivial code.
>>
>> But they dont do so, and have no wish to do so, because they want to
>> move fast. I know this when I developed a crypto API. I was contacted by
>> Xiaomi for questions and requests because I was too slow. Then they took
>> it from me and made it their own way and merged it without me. That is
>> not right. As a consequence I stopped doing anything on this topic.
>> Future TLS and smart card work coming in 2023 (finally funded) will be
>> kept private unless things change drastically.
>>
>>
>> Nathan said it much better than me, we NEED to know the roadmap of all
>> companies who want to push any amount of code to nuttx, and this HAS to
>> be done publicly.
>>
>>
>>
>> At this point I am considering this project has no wish to follow the
>> Apache foundation rules, and is actively violating them using false
>> justifications.
>>
>>
>>
>> Calling out people like me and asking for more contribution instead of
>> complaining is NOT RIGHT.
>>
>> I am using NuttX in my company, I fix the bugs I find and I submit the
>> useful contributions.
>>
>> I am not paid to contribute to NuttX. I am paid to develop products that
>> use NuttX, and as a consequence I make it work when needed.
>>
>> I have no plans to be a maintainer for this project, more so given the
>> current conditions.
>>
>> But as a user, I have the right to say that current maintenance is not
>> right.
>>
>>
>> Sebastien
>>
>>
>> Le 08/03/2023 à 15:54, Alan C. Assis a écrit :
>>
>>> Sebastien,
>>>
>>> If all the discussions that happens on github start to happen here,
>>> this mailing list will be just like the nuttx-commits mailing list.
>>>
>>> So, your point is a catch 22! (dilemma)... You are against using
>>> github and against have a mailing list with huge email messages.
>>>
>>> Also you cannot complain that more than 90% of commits are coming from
>> Xiaomi.
>>> And the only reason that many PRs are approved and merged by Xiaomi
>>> people is because we don't have enough reviewers to help.
>>>
>>> So, instead complain that the route is going to wrong direction, start
>>> to help to construct the route, simple like that!
>>>
>>>
>>> Also, what you can do as a NuttX advocate is ask the semiconductor
>>> company used on your project to support NuttX.
>>>
>>> If they don't agree, move for some semiconductor company that are
>>> contributing to NuttX (Espressif, Sony, NXP, etc).
>>>
>>> BR,
>>>
>>> Alan
>>>
>>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>>>> I dont think your point of view is very realistic. You seem to be
>>>> turning the situation into something that pleases you but is not really
>>>> compatible with what can be observed from outside.
>>>>
>>>> In the archive for 2023 there are 2035 topics, I just overlooked more
>>>> than 600 of them and ALL of them are just copies of github messages. And
>>>> this is normal, because this is unusable.
>>>>
>>>> Also, I cannot actively review ALL the hundreds of pull requests that
>>>> are regularly sent by large companies.
>>>>
>>>> I am primarily a user, that sometimes sends small contributions.
>>>>
>>>> And I am unhappy when I see that other people were careless with nice
>>>> code and do whatever they want for their own agenda without any
>>>> consideration for other users.
>>>>
>>>> To be honest I dont fully understand why SO MANY changes are required to
>>>> core OS features that should be stable.
>>>>
>>>> There need to be some triage when a new pull request is sent, its
>>>> severity evaluated by someone who is NOT in the company of the original
>>>> contributor, and if severe, it has to be approved on the mailing list. I
>>>> cannot do that alone, even if I try.
>>>>
>>>> At this point do you realize that more than !~90ish% of changes seem to
>>>> come from xiaomi developers and most of these are approved by xiaoxiang
>>>> alone?
>>>>
>>>> Because this HAS to be said. They send overwhelming numbers
>>>> contributions that cannot be possibly understood as a whole, there is no
>>>> clear agenda, they add whatever they like with no roadmap and no review
>>>> from other users that may have other uses.
>>>>
>>>> This has to be under control somehow. I believe even you Alan are not
>>>> aware of the amount of code that enters nuttx. No one can be now.
>>>>
>>>> Sebastien
>>>>
>>>>
>>>> Le 08/03/2023 à 14:39, Alan C. Assis a écrit :
>>>>> Hi Sebastien,
>>>>>
>>>>> Yes, that commit list is mostly for people who don't want to use
>>>>> github but still wanting to see what is going on.
>>>>>
>>>>> Sometimes when a very important PR raises some concern on GitHub PR,
>>>>> people post their concern he, it already happened many times.
>>>>>
>>>>> But again: the best way to guarantee that current changes please you
>>>>> is to keep actively reviewing the PRs and contributing to the project.
>>>>>
>>>>> BR,
>>>>>
>>>>> Alan
>>>>>
>>>>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>>>>>> Hi,
>>>>>>
>>>>>> I had a look and this mailing list is not made for human consumption.
>>>>>>
>>>>>> No one has ever sent a message on it manually, right?
>>>>>>
>>>>>> In practice, important changes are still NOT discussed on the DEV
>>>>>> mailing list.
>>>>>>
>>>>>> You said yourself that "all development has moved to github".
>>>>>>
>>>>>> As soon as automated tests are passed, every commit is considered
>> with a
>>>>>> similar level of importance, however this is clearly not the case.
>>>>>>
>>>>>> Sebastien
>>>>>>
>>>>>> Le 08/03/2023 à 13:21, Alan C. Assis a écrit :
>>>>>>> HI Sebastien,
>>>>>>>
>>>>>>> It is already done, you just need to subscribe to
>>>>>>> https://lists.apache.org/list.html?commits@nuttx.apache.org to
>> receive
>>>>>>> all commits messages and discussions.
>>>>>>>
>>>>>>> Everything is archived on apache side!
>>>>>>>
>>>>>>> BR,
>>>>>>>
>>>>>>> Alan
>>>>>>>
>>>>>>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>>>>>>>> Apache projects are required to use mailing lists for long term
>>>>>>>> archival
>>>>>>>> purposes.
>>>>>>>>
>>>>>>>> It seems to me that this project is avoiding that rule and moved all
>>>>>>>> development to github
>>>>>>>>
>>>>>>>> This is in contradiction with the Apache project rules.
>>>>>>>>
>>>>>>>>
>>>>>>>> I request clarification on this situation and requirement (instead
>> of
>>>>>>>> just asserting it), including a review by the apache boards.
>>>>>>>>
>>>>>>>>
>>>>>>>> If it is proved that development happens primarily in github and not
>>>>>>>> here I will request the following:
>>>>>>>>
>>>>>>>> -every people committing patches and submitting pull request to be
>>>>>>>> registered on the mailing list so they are able to reply to
>> questions
>>>>>>>> -forwarding of all pull requests traffic to the mailing list
>>>>>>>>
>>>>>>>> For two reasons: (1) Archival purposes, and (2) open discussions
>> with
>>>>>>>> members that follow Apache Foundation mailing list rules and do not
>>>>>>>> take
>>>>>>>> part in github.
>>>>>>>>
>>>>>>>>
>>>>>>>> Thank you
>>>>>>>>
>>>>>>>> Sebastien
>>>>>>>>
>>>>>>>>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Brennan Ashton <ba...@brennanashton.com>.
This whole thread really bums me out. We really should be assuming people
are acting with best intentions, rather than accusing of ulterior motives.
If there are changes that you have concerns about people tend to be very
reasonable about explaining and if we need to revert something or change
something, that's fine too.
Tossing around ideas on the mailing list is totally fine, but when it comes
to reviewing code I don't see anything wrong with that happening in PR
reviews next to the code. And to be honest using Issues is also a much much
more pleasant experience.
If you want the mailing list experience you can still get that by clicking
subscribe (which is what I do to get the open flood gates of content).
There is also the commit mailing list that does archive all of that
content.
People have been better about tagging things that may be breaking changes,
but things do slip though. This was even the case when Greg reviewed all
code. And sometimes things were reverted, sometimes not.
What I would like to see is that people put a little bit of though into the
testing box. For example Lup does an excellent job with this
https://github.com/apache/nuttx/pull/7944
We are still growing as a project and people being more active in the
review process will go a long way, but we need the people to do that. While
I have not committed much code in sometime, I still try to scan through the
PRs in my inbox for content of interest.
--Brennan
On Wed, Mar 8, 2023, 7:54 AM Sebastien Lorquet <se...@lorquet.fr> wrote:
> I tend to disagree.
>
>
> You have extreme views that all commits need to be discussed. That is
> false.
>
> What need to be discussed is much subtle.
>
> We need to have discussion whenever ANYONE has a doubt about something
> that is happening on github BEFORE this is committed.
>
> Xiaomi (and other companies, but xiaomi is very representative of this)
> would have more reviewers if commits that ACTUALLY need reviews were
> discussed on the list.
>
> I have done so every time I planned to push more than trivial code.
>
> But they dont do so, and have no wish to do so, because they want to
> move fast. I know this when I developed a crypto API. I was contacted by
> Xiaomi for questions and requests because I was too slow. Then they took
> it from me and made it their own way and merged it without me. That is
> not right. As a consequence I stopped doing anything on this topic.
> Future TLS and smart card work coming in 2023 (finally funded) will be
> kept private unless things change drastically.
>
>
> Nathan said it much better than me, we NEED to know the roadmap of all
> companies who want to push any amount of code to nuttx, and this HAS to
> be done publicly.
>
>
>
> At this point I am considering this project has no wish to follow the
> Apache foundation rules, and is actively violating them using false
> justifications.
>
>
>
> Calling out people like me and asking for more contribution instead of
> complaining is NOT RIGHT.
>
> I am using NuttX in my company, I fix the bugs I find and I submit the
> useful contributions.
>
> I am not paid to contribute to NuttX. I am paid to develop products that
> use NuttX, and as a consequence I make it work when needed.
>
> I have no plans to be a maintainer for this project, more so given the
> current conditions.
>
> But as a user, I have the right to say that current maintenance is not
> right.
>
>
> Sebastien
>
>
> Le 08/03/2023 à 15:54, Alan C. Assis a écrit :
>
> > Sebastien,
> >
> > If all the discussions that happens on github start to happen here,
> > this mailing list will be just like the nuttx-commits mailing list.
> >
> > So, your point is a catch 22! (dilemma)... You are against using
> > github and against have a mailing list with huge email messages.
> >
> > Also you cannot complain that more than 90% of commits are coming from
> Xiaomi.
> >
> > And the only reason that many PRs are approved and merged by Xiaomi
> > people is because we don't have enough reviewers to help.
> >
> > So, instead complain that the route is going to wrong direction, start
> > to help to construct the route, simple like that!
> >
> >
> > Also, what you can do as a NuttX advocate is ask the semiconductor
> > company used on your project to support NuttX.
> >
> > If they don't agree, move for some semiconductor company that are
> > contributing to NuttX (Espressif, Sony, NXP, etc).
> >
> > BR,
> >
> > Alan
> >
> > On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
> >> I dont think your point of view is very realistic. You seem to be
> >> turning the situation into something that pleases you but is not really
> >> compatible with what can be observed from outside.
> >>
> >> In the archive for 2023 there are 2035 topics, I just overlooked more
> >> than 600 of them and ALL of them are just copies of github messages. And
> >> this is normal, because this is unusable.
> >>
> >> Also, I cannot actively review ALL the hundreds of pull requests that
> >> are regularly sent by large companies.
> >>
> >> I am primarily a user, that sometimes sends small contributions.
> >>
> >> And I am unhappy when I see that other people were careless with nice
> >> code and do whatever they want for their own agenda without any
> >> consideration for other users.
> >>
> >> To be honest I dont fully understand why SO MANY changes are required to
> >> core OS features that should be stable.
> >>
> >> There need to be some triage when a new pull request is sent, its
> >> severity evaluated by someone who is NOT in the company of the original
> >> contributor, and if severe, it has to be approved on the mailing list. I
> >> cannot do that alone, even if I try.
> >>
> >> At this point do you realize that more than !~90ish% of changes seem to
> >> come from xiaomi developers and most of these are approved by xiaoxiang
> >> alone?
> >>
> >> Because this HAS to be said. They send overwhelming numbers
> >> contributions that cannot be possibly understood as a whole, there is no
> >> clear agenda, they add whatever they like with no roadmap and no review
> >> from other users that may have other uses.
> >>
> >> This has to be under control somehow. I believe even you Alan are not
> >> aware of the amount of code that enters nuttx. No one can be now.
> >>
> >> Sebastien
> >>
> >>
> >> Le 08/03/2023 à 14:39, Alan C. Assis a écrit :
> >>> Hi Sebastien,
> >>>
> >>> Yes, that commit list is mostly for people who don't want to use
> >>> github but still wanting to see what is going on.
> >>>
> >>> Sometimes when a very important PR raises some concern on GitHub PR,
> >>> people post their concern he, it already happened many times.
> >>>
> >>> But again: the best way to guarantee that current changes please you
> >>> is to keep actively reviewing the PRs and contributing to the project.
> >>>
> >>> BR,
> >>>
> >>> Alan
> >>>
> >>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
> >>>> Hi,
> >>>>
> >>>> I had a look and this mailing list is not made for human consumption.
> >>>>
> >>>> No one has ever sent a message on it manually, right?
> >>>>
> >>>> In practice, important changes are still NOT discussed on the DEV
> >>>> mailing list.
> >>>>
> >>>> You said yourself that "all development has moved to github".
> >>>>
> >>>> As soon as automated tests are passed, every commit is considered
> with a
> >>>> similar level of importance, however this is clearly not the case.
> >>>>
> >>>> Sebastien
> >>>>
> >>>> Le 08/03/2023 à 13:21, Alan C. Assis a écrit :
> >>>>> HI Sebastien,
> >>>>>
> >>>>> It is already done, you just need to subscribe to
> >>>>> https://lists.apache.org/list.html?commits@nuttx.apache.org to
> receive
> >>>>> all commits messages and discussions.
> >>>>>
> >>>>> Everything is archived on apache side!
> >>>>>
> >>>>> BR,
> >>>>>
> >>>>> Alan
> >>>>>
> >>>>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
> >>>>>> Apache projects are required to use mailing lists for long term
> >>>>>> archival
> >>>>>> purposes.
> >>>>>>
> >>>>>> It seems to me that this project is avoiding that rule and moved all
> >>>>>> development to github
> >>>>>>
> >>>>>> This is in contradiction with the Apache project rules.
> >>>>>>
> >>>>>>
> >>>>>> I request clarification on this situation and requirement (instead
> of
> >>>>>> just asserting it), including a review by the apache boards.
> >>>>>>
> >>>>>>
> >>>>>> If it is proved that development happens primarily in github and not
> >>>>>> here I will request the following:
> >>>>>>
> >>>>>> -every people committing patches and submitting pull request to be
> >>>>>> registered on the mailing list so they are able to reply to
> questions
> >>>>>>
> >>>>>> -forwarding of all pull requests traffic to the mailing list
> >>>>>>
> >>>>>> For two reasons: (1) Archival purposes, and (2) open discussions
> with
> >>>>>> members that follow Apache Foundation mailing list rules and do not
> >>>>>> take
> >>>>>> part in github.
> >>>>>>
> >>>>>>
> >>>>>> Thank you
> >>>>>>
> >>>>>> Sebastien
> >>>>>>
> >>>>>>
>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Matheus Castello <ma...@castello.eng.br>.
but, Github PRs and discussion there is not public?
And also the commits, messages and discussions are not being archived?
So, what exactly is the problem?
to me it seems more like you are trying to justify your failure to
follow the project and discuss it in the community.
Obs: I feel like I'm in 1990 having to respond to an email list.
On 3/8/2023 12:54 PM, Sebastien Lorquet wrote:
> I tend to disagree.
>
>
> You have extreme views that all commits need to be discussed. That is
> false.
>
> What need to be discussed is much subtle.
>
> We need to have discussion whenever ANYONE has a doubt about something
> that is happening on github BEFORE this is committed.
>
> Xiaomi (and other companies, but xiaomi is very representative of this)
> would have more reviewers if commits that ACTUALLY need reviews were
> discussed on the list.
>
> I have done so every time I planned to push more than trivial code.
>
> But they dont do so, and have no wish to do so, because they want to
> move fast. I know this when I developed a crypto API. I was contacted by
> Xiaomi for questions and requests because I was too slow. Then they took
> it from me and made it their own way and merged it without me. That is
> not right. As a consequence I stopped doing anything on this topic.
> Future TLS and smart card work coming in 2023 (finally funded) will be
> kept private unless things change drastically.
>
>
> Nathan said it much better than me, we NEED to know the roadmap of all
> companies who want to push any amount of code to nuttx, and this HAS to
> be done publicly.
>
>
>
> At this point I am considering this project has no wish to follow the
> Apache foundation rules, and is actively violating them using false
> justifications.
>
>
>
> Calling out people like me and asking for more contribution instead of
> complaining is NOT RIGHT.
>
> I am using NuttX in my company, I fix the bugs I find and I submit the
> useful contributions.
>
> I am not paid to contribute to NuttX. I am paid to develop products that
> use NuttX, and as a consequence I make it work when needed.
>
> I have no plans to be a maintainer for this project, more so given the
> current conditions.
>
> But as a user, I have the right to say that current maintenance is not
> right.
>
>
> Sebastien
>
>
> Le 08/03/2023 à 15:54, Alan C. Assis a écrit :
>
>> Sebastien,
>>
>> If all the discussions that happens on github start to happen here,
>> this mailing list will be just like the nuttx-commits mailing list.
>>
>> So, your point is a catch 22! (dilemma)... You are against using
>> github and against have a mailing list with huge email messages.
>>
>> Also you cannot complain that more than 90% of commits are coming from
>> Xiaomi.
>>
>> And the only reason that many PRs are approved and merged by Xiaomi
>> people is because we don't have enough reviewers to help.
>>
>> So, instead complain that the route is going to wrong direction, start
>> to help to construct the route, simple like that!
>>
>>
>> Also, what you can do as a NuttX advocate is ask the semiconductor
>> company used on your project to support NuttX.
>>
>> If they don't agree, move for some semiconductor company that are
>> contributing to NuttX (Espressif, Sony, NXP, etc).
>>
>> BR,
>>
>> Alan
>>
>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>>> I dont think your point of view is very realistic. You seem to be
>>> turning the situation into something that pleases you but is not really
>>> compatible with what can be observed from outside.
>>>
>>> In the archive for 2023 there are 2035 topics, I just overlooked more
>>> than 600 of them and ALL of them are just copies of github messages. And
>>> this is normal, because this is unusable.
>>>
>>> Also, I cannot actively review ALL the hundreds of pull requests that
>>> are regularly sent by large companies.
>>>
>>> I am primarily a user, that sometimes sends small contributions.
>>>
>>> And I am unhappy when I see that other people were careless with nice
>>> code and do whatever they want for their own agenda without any
>>> consideration for other users.
>>>
>>> To be honest I dont fully understand why SO MANY changes are required to
>>> core OS features that should be stable.
>>>
>>> There need to be some triage when a new pull request is sent, its
>>> severity evaluated by someone who is NOT in the company of the original
>>> contributor, and if severe, it has to be approved on the mailing list. I
>>> cannot do that alone, even if I try.
>>>
>>> At this point do you realize that more than !~90ish% of changes seem to
>>> come from xiaomi developers and most of these are approved by xiaoxiang
>>> alone?
>>>
>>> Because this HAS to be said. They send overwhelming numbers
>>> contributions that cannot be possibly understood as a whole, there is no
>>> clear agenda, they add whatever they like with no roadmap and no review
>>> from other users that may have other uses.
>>>
>>> This has to be under control somehow. I believe even you Alan are not
>>> aware of the amount of code that enters nuttx. No one can be now.
>>>
>>> Sebastien
>>>
>>>
>>> Le 08/03/2023 à 14:39, Alan C. Assis a écrit :
>>>> Hi Sebastien,
>>>>
>>>> Yes, that commit list is mostly for people who don't want to use
>>>> github but still wanting to see what is going on.
>>>>
>>>> Sometimes when a very important PR raises some concern on GitHub PR,
>>>> people post their concern he, it already happened many times.
>>>>
>>>> But again: the best way to guarantee that current changes please you
>>>> is to keep actively reviewing the PRs and contributing to the project.
>>>>
>>>> BR,
>>>>
>>>> Alan
>>>>
>>>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>>>>> Hi,
>>>>>
>>>>> I had a look and this mailing list is not made for human consumption.
>>>>>
>>>>> No one has ever sent a message on it manually, right?
>>>>>
>>>>> In practice, important changes are still NOT discussed on the DEV
>>>>> mailing list.
>>>>>
>>>>> You said yourself that "all development has moved to github".
>>>>>
>>>>> As soon as automated tests are passed, every commit is considered
>>>>> with a
>>>>> similar level of importance, however this is clearly not the case.
>>>>>
>>>>> Sebastien
>>>>>
>>>>> Le 08/03/2023 à 13:21, Alan C. Assis a écrit :
>>>>>> HI Sebastien,
>>>>>>
>>>>>> It is already done, you just need to subscribe to
>>>>>> https://lists.apache.org/list.html?commits@nuttx.apache.org to
>>>>>> receive
>>>>>> all commits messages and discussions.
>>>>>>
>>>>>> Everything is archived on apache side!
>>>>>>
>>>>>> BR,
>>>>>>
>>>>>> Alan
>>>>>>
>>>>>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>>>>>>> Apache projects are required to use mailing lists for long term
>>>>>>> archival
>>>>>>> purposes.
>>>>>>>
>>>>>>> It seems to me that this project is avoiding that rule and moved all
>>>>>>> development to github
>>>>>>>
>>>>>>> This is in contradiction with the Apache project rules.
>>>>>>>
>>>>>>>
>>>>>>> I request clarification on this situation and requirement
>>>>>>> (instead of
>>>>>>> just asserting it), including a review by the apache boards.
>>>>>>>
>>>>>>>
>>>>>>> If it is proved that development happens primarily in github and not
>>>>>>> here I will request the following:
>>>>>>>
>>>>>>> -every people committing patches and submitting pull request to be
>>>>>>> registered on the mailing list so they are able to reply to
>>>>>>> questions
>>>>>>>
>>>>>>> -forwarding of all pull requests traffic to the mailing list
>>>>>>>
>>>>>>> For two reasons: (1) Archival purposes, and (2) open discussions
>>>>>>> with
>>>>>>> members that follow Apache Foundation mailing list rules and do not
>>>>>>> take
>>>>>>> part in github.
>>>>>>>
>>>>>>>
>>>>>>> Thank you
>>>>>>>
>>>>>>> Sebastien
>>>>>>>
>>>>>>>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Gregory Nutt <sp...@gmail.com>.
I think that there are two different kinds of discussion that we need to
have and these are probably best done in different forums.
/*Black Box*/
By black box I mean the externally observed behavior and characteristics
of the OS: Interfaces, performance, driver facilities, build changes
etc. If you are writing a functional specification of NuttX, a users
manual, or a developer's guide, then you are dealing with the black box
behavior.
Changes to black box behavior effect all users. Everyone needs to know
these things; everyone needs the opportunity to weigh in on proposed
changes that affect the black box behavior. This is the kind of thing
that really needs be be exposed to the whole community in the dev list.
The commit list is overkill for this.
/*White Box*/
Then there is the low-level, detailed, discussion of the implementation
of features and bugfixes. This is also an important discussion but
really is only of interest to people maintaining and enhancing the OS,
the core OS developers. This kind of information usually does not
belong on the dev list because it is not generally of interest to the
whole community. Github notifications and PR/Issue discussions are well
suited for this.
/*Both*/
Lots of internal changes require both low-level, detailed discussion and
affect the black box behavior. In that case, it may be necessary to use
both.
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Sebastien Lorquet <se...@lorquet.fr>.
I tend to disagree.
You have extreme views that all commits need to be discussed. That is false.
What need to be discussed is much subtle.
We need to have discussion whenever ANYONE has a doubt about something
that is happening on github BEFORE this is committed.
Xiaomi (and other companies, but xiaomi is very representative of this)
would have more reviewers if commits that ACTUALLY need reviews were
discussed on the list.
I have done so every time I planned to push more than trivial code.
But they dont do so, and have no wish to do so, because they want to
move fast. I know this when I developed a crypto API. I was contacted by
Xiaomi for questions and requests because I was too slow. Then they took
it from me and made it their own way and merged it without me. That is
not right. As a consequence I stopped doing anything on this topic.
Future TLS and smart card work coming in 2023 (finally funded) will be
kept private unless things change drastically.
Nathan said it much better than me, we NEED to know the roadmap of all
companies who want to push any amount of code to nuttx, and this HAS to
be done publicly.
At this point I am considering this project has no wish to follow the
Apache foundation rules, and is actively violating them using false
justifications.
Calling out people like me and asking for more contribution instead of
complaining is NOT RIGHT.
I am using NuttX in my company, I fix the bugs I find and I submit the
useful contributions.
I am not paid to contribute to NuttX. I am paid to develop products that
use NuttX, and as a consequence I make it work when needed.
I have no plans to be a maintainer for this project, more so given the
current conditions.
But as a user, I have the right to say that current maintenance is not
right.
Sebastien
Le 08/03/2023 à 15:54, Alan C. Assis a écrit :
> Sebastien,
>
> If all the discussions that happens on github start to happen here,
> this mailing list will be just like the nuttx-commits mailing list.
>
> So, your point is a catch 22! (dilemma)... You are against using
> github and against have a mailing list with huge email messages.
>
> Also you cannot complain that more than 90% of commits are coming from Xiaomi.
>
> And the only reason that many PRs are approved and merged by Xiaomi
> people is because we don't have enough reviewers to help.
>
> So, instead complain that the route is going to wrong direction, start
> to help to construct the route, simple like that!
>
>
> Also, what you can do as a NuttX advocate is ask the semiconductor
> company used on your project to support NuttX.
>
> If they don't agree, move for some semiconductor company that are
> contributing to NuttX (Espressif, Sony, NXP, etc).
>
> BR,
>
> Alan
>
> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>> I dont think your point of view is very realistic. You seem to be
>> turning the situation into something that pleases you but is not really
>> compatible with what can be observed from outside.
>>
>> In the archive for 2023 there are 2035 topics, I just overlooked more
>> than 600 of them and ALL of them are just copies of github messages. And
>> this is normal, because this is unusable.
>>
>> Also, I cannot actively review ALL the hundreds of pull requests that
>> are regularly sent by large companies.
>>
>> I am primarily a user, that sometimes sends small contributions.
>>
>> And I am unhappy when I see that other people were careless with nice
>> code and do whatever they want for their own agenda without any
>> consideration for other users.
>>
>> To be honest I dont fully understand why SO MANY changes are required to
>> core OS features that should be stable.
>>
>> There need to be some triage when a new pull request is sent, its
>> severity evaluated by someone who is NOT in the company of the original
>> contributor, and if severe, it has to be approved on the mailing list. I
>> cannot do that alone, even if I try.
>>
>> At this point do you realize that more than !~90ish% of changes seem to
>> come from xiaomi developers and most of these are approved by xiaoxiang
>> alone?
>>
>> Because this HAS to be said. They send overwhelming numbers
>> contributions that cannot be possibly understood as a whole, there is no
>> clear agenda, they add whatever they like with no roadmap and no review
>> from other users that may have other uses.
>>
>> This has to be under control somehow. I believe even you Alan are not
>> aware of the amount of code that enters nuttx. No one can be now.
>>
>> Sebastien
>>
>>
>> Le 08/03/2023 à 14:39, Alan C. Assis a écrit :
>>> Hi Sebastien,
>>>
>>> Yes, that commit list is mostly for people who don't want to use
>>> github but still wanting to see what is going on.
>>>
>>> Sometimes when a very important PR raises some concern on GitHub PR,
>>> people post their concern he, it already happened many times.
>>>
>>> But again: the best way to guarantee that current changes please you
>>> is to keep actively reviewing the PRs and contributing to the project.
>>>
>>> BR,
>>>
>>> Alan
>>>
>>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>>>> Hi,
>>>>
>>>> I had a look and this mailing list is not made for human consumption.
>>>>
>>>> No one has ever sent a message on it manually, right?
>>>>
>>>> In practice, important changes are still NOT discussed on the DEV
>>>> mailing list.
>>>>
>>>> You said yourself that "all development has moved to github".
>>>>
>>>> As soon as automated tests are passed, every commit is considered with a
>>>> similar level of importance, however this is clearly not the case.
>>>>
>>>> Sebastien
>>>>
>>>> Le 08/03/2023 à 13:21, Alan C. Assis a écrit :
>>>>> HI Sebastien,
>>>>>
>>>>> It is already done, you just need to subscribe to
>>>>> https://lists.apache.org/list.html?commits@nuttx.apache.org to receive
>>>>> all commits messages and discussions.
>>>>>
>>>>> Everything is archived on apache side!
>>>>>
>>>>> BR,
>>>>>
>>>>> Alan
>>>>>
>>>>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>>>>>> Apache projects are required to use mailing lists for long term
>>>>>> archival
>>>>>> purposes.
>>>>>>
>>>>>> It seems to me that this project is avoiding that rule and moved all
>>>>>> development to github
>>>>>>
>>>>>> This is in contradiction with the Apache project rules.
>>>>>>
>>>>>>
>>>>>> I request clarification on this situation and requirement (instead of
>>>>>> just asserting it), including a review by the apache boards.
>>>>>>
>>>>>>
>>>>>> If it is proved that development happens primarily in github and not
>>>>>> here I will request the following:
>>>>>>
>>>>>> -every people committing patches and submitting pull request to be
>>>>>> registered on the mailing list so they are able to reply to questions
>>>>>>
>>>>>> -forwarding of all pull requests traffic to the mailing list
>>>>>>
>>>>>> For two reasons: (1) Archival purposes, and (2) open discussions with
>>>>>> members that follow Apache Foundation mailing list rules and do not
>>>>>> take
>>>>>> part in github.
>>>>>>
>>>>>>
>>>>>> Thank you
>>>>>>
>>>>>> Sebastien
>>>>>>
>>>>>>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Tomek CEDRO <to...@cedro.info>.
On Wed, Mar 8, 2023 at 6:08 PM Tomek CEDRO wrote:
> Master branch can have some things that will not work. No one is able
> to predict everything. It is still possible to revert changes or
> redirect them in a good "backward compatible" way with a new feature.
Just a note: There are two approaches to the subject:
1. Master is saint, all development is done on devel branch (I prefer
this one, but it works best in a small projects).
2. Master holds live code that have new features that may break
things, users should use a release package or a release branch to get
stable code (this one seems more popular).
KiCAD for instance uses approach 2, so it there is a fix I need, I
need to use master branch at the cost of formats change rendering my
design files useless for others until a release catches up in several
months.
FreeBSD uses CURRENT, STABLE, and RELEASE approach. CURRENT (has major
number next to a release) uses live code with all new features,
drivers, etc, but it breaks quite often, its mainly used by the kernel
developers. Code from CURRENT goes to STABLE (major number equal to a
release, or current minus one) after things are well tested, but here
things also happen to break sometimes. After code is even more tested
on a STABLE then a RELEASE is made (incremental minor number with a
STABLE major number).
I would say that staying backward and self compatible should be saint,
and that should be kept for a release.
Master seems to be the live code in NuttX, so new things may show up,
also problems, and time for a discussion and fixes.
With a constantly increasing popularity of the project more and more
situations like this will show up. It is also important how we deal
with and fix them as a team :-)
Have a good day folks! :-)
Tomek
--
CeDeROM, SQ7MHZ, http://www.tomek.cedro.info
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Tomek CEDRO <to...@cedro.info>.
On Wed, Mar 8, 2023 at 5:37 PM Lwazi Dube <lw...@gmail.com> wrote:
> On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
> >
> > Sebastien,
> >
> > If all the discussions that happens on github start to happen here,
> > this mailing list will be just like the nuttx-commits mailing list.
>
> I'll take this as sarcasm. Sebastien is making a lot of valid points,
> in good faith, and being dismissive does not help the community.
Folks, this seems to be getting personal, please stop, make a point,
suggest a solution, lets make it happen in a good old fashioned and
calm way, please :-)
Some interesting news (some of them really sad) showed up, and review
process suggestions has been made.
I am using BSD Unix not Linux because I do not like enforced changes
and I know that things from 10 years back will still work here and
will work in next 10 years. This discussion is somehow about "enforced
changes"^TM too. This comes from Linux world and I think more and more
people will turn back on Linux because of this (I did this around 2008
when kernel api started changing every minor release).
I like NuttX because there are no enforced changes here and I would
love things to stay that way. In a perfect situation code that runs on
a release 9 should also work on a release 13. Lets stay "self
compatible" :-)
Master branch can have some things that will not work. No one is able
to predict everything. It is still possible to revert changes or
redirect them in a good "backward compatible" way with a new feature.
I was also surprised by a silent build, but that did not push me to
swear on a mailing list :-) I like the reaction of the community here
with a constructive solution proposition to make this silent build
optional. Things will work as usual, but new functionality will be
available. What is the problem? We still have some time before a next
release. Lets use that critics to make a constructive solution and
keep discussions elegant :-)
Best regards :-)
Tomek
--
CeDeROM, SQ7MHZ, http://www.tomek.cedro.info
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Lwazi Dube <lw...@gmail.com>.
On Wed, 8 Mar 2023 at 13:16, Alan C. Assis <ac...@gmail.com> wrote:
>
>
> Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear
> from you again! You have a great knowledge of BLE can we need! I was
> expecting you to share that working example of BLE application using
> our BLE stack).
>
Thanks, I don't know about "great knowledge", but I am not sure I will
be doing any bt work this time. I checked. The current BLE stack is
broken when I run it on my board with a cc2564 BT chip. The bt command
fails to connect like it does on a 2019 tree that I have. I don't know
what the point of the changes being made to bluetooth is, if such a
basic feature remains broken after a merge. Is anyone really using or
testing the NuttX stack?
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Tomek CEDRO <to...@cedro.info>.
On Wed, Mar 8, 2023 at 7:16 PM Alan C. Assis wrote:
> Problem is that we don't have enough reviewers.
I was recently invited to the PMC, thank you, this is a great honour,
and obligation, I will try to act as best I can to support you folks..
but this is really lots of everyday work from what I can see now.. I
will try to get in sync! :-)
I started in the old-school 8-bit times, also I am more
long-term-maintenance fan of BSD Unix rather than enforced-changes of
Linux and Microsoft. Please send PM with hints and directions where
help is most needed :-)
--
CeDeROM, SQ7MHZ, http://www.tomek.cedro.info
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Sebastien Lorquet <se...@lorquet.fr>.
Hi,
Sounds like a good summary, and also a good improvement if implemented
as described here and actually enforced.
May I suggest just a bit more documentation than just official release
notes? For example, warnings in commit messages, so we get no nasty
surprise after an innocent git pull? Additionally, something should be
indicated when usual apps will be categorically incompatible, if possible?
Discussion about the status of the master branch is also interesting.
how many breakage should we expect on this branch? Should that be a
separate thread?
Sebastien
Le 09/03/2023 à 09:39, Alin.Jerpelea@sony.com a écrit :
> Hi all,
>
> I feel that this thread is getting too long without a real outcome
>
> Some observations from my daily interactions with the project:
> - I like doing reviews on github and I think that many people in this thread would agree that this flow is good.
> - I like to be able to see all bugs in one place and get statistics for the ASF reports
>
> What I don’t feel right
> - even if I spend time daily on reviewing patches there are still changes that I miss and it is hard to get the flow on release date
> - some breaking changes are not discussed enough with the community since there are some people that do not have time to review code on gihub.
>
> As a way going forward I propose that we improve in 2 aspects
> - All breaking commits should be discusses on dev so that people get enough time to digest the change and even better get involved int the flow
> - all breaking changes should be documented on the release confluence page before merging so that we don’t miss mentioning them on release date.
> - there should be at least 1 independent reviewer (not from the same company) so that a patch is merged except board changes (ex an employee from the same company merges a patch submitted by another employee from the same company, for a board provided by the same company)
>
> Thanks
> Alin
>
> -----Original Message-----
> From: Alan C. Assis <ac...@gmail.com>
> Sent: den 8 mars 2023 19:15
> To: dev@nuttx.apache.org
> Cc: Sebastien Lorquet <se...@lorquet.fr>
> Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
>
> Hi Lwazi,
>
> It is not sarcarm, I'm talking about facts.
>
> Also I didn't say Sebastien points aren't valid, but is diverting from the real issue.
>
> The issue is not if the discussion is happening here or there, the Problem is that we don't have enough reviewers.
>
> So, first step is that NuttX needs to increase the user base, but have few users really engaged with the project, reviewing patches every single day. Currently today he have few: Petro and Xiang are exceptional on this point. They are my inspiration to try do more!
>
> Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear from you again! You have a great knowledge of BLE can we need! I was expecting you to share that working example of BLE application using our BLE stack).
>
> BR,
>
> Alan
>
> On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
>> On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
>>> Sebastien,
>>>
>>> If all the discussions that happens on github start to happen here,
>>> this mailing list will be just like the nuttx-commits mailing list.
>> I'll take this as sarcasm. Sebastien is making a lot of valid points,
>> in good faith, and being dismissive does not help the community.
>>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Sebastien Lorquet <se...@lorquet.fr>.
+1 100% from me, too.
Sebastien
Le 09/03/2023 à 10:18, David Sidrane a écrit :
> +1 100%
>
> I think that the PR should have a summary as well to ensure it is all tied
> together. Unless we enable rebase/squash the information will be disjoint.
>
> David
>
>
> -----Original Message-----
> From: Alin.Jerpelea@sony.com <Al...@sony.com>
> Sent: Thursday, March 9, 2023 4:13 AM
> To: dev@nuttx.apache.org
> Cc: Sebastien Lorquet <se...@lorquet.fr>
> Subject: RE: DISCUSSION - Usage of mailing lists for apache projects
>
> Hi all,
>
> I agree with David but in my opinion this information should go in the
> commit message and no commit without message should be merged.
> Not all people will check the PR message but you will always see the reasons
> simply by typing "git log" if they are in the commit message
>
> What do you think ?
>
> Thanks
> Alin
>
>
> -----Original Message-----
> From: David Sidrane <da...@nscdg.com>
> Sent: den 9 mars 2023 10:00
> To: dev@nuttx.apache.org
> Cc: Sebastien Lorquet <se...@lorquet.fr>
> Subject: RE: DISCUSSION - Usage of mailing lists for apache projects
>
> I would add that all pull request must have a statement explaining the
> reason or motivation for the change(s).
>
> Just stating the "What" was done is not enough. There must be a "Why" the
> change is needed.
>
> David
>
> -----Original Message-----
> From: Alin.Jerpelea@sony.com <Al...@sony.com>
> Sent: Thursday, March 9, 2023 3:39 AM
> To: dev@nuttx.apache.org
> Cc: Sebastien Lorquet <se...@lorquet.fr>
> Subject: RE: DISCUSSION - Usage of mailing lists for apache projects
>
> Hi all,
>
> I feel that this thread is getting too long without a real outcome
>
> Some observations from my daily interactions with the project:
> - I like doing reviews on github and I think that many people in this thread
> would agree that this flow is good.
> - I like to be able to see all bugs in one place and get statistics for the
> ASF reports
>
> What I don’t feel right
> - even if I spend time daily on reviewing patches there are still changes
> that I miss and it is hard to get the flow on release date
> - some breaking changes are not discussed enough with the community since
> there are some people that do not have time to review code on gihub.
>
> As a way going forward I propose that we improve in 2 aspects
> - All breaking commits should be discusses on dev so that people get enough
> time to digest the change and even better get involved int the flow
> - all breaking changes should be documented on the release confluence page
> before merging so that we don’t miss mentioning them on release date.
> - there should be at least 1 independent reviewer (not from the same
> company) so that a patch is merged except board changes (ex an employee from
> the same company merges a patch submitted by another employee from the same
> company, for a board provided by the same company)
>
> Thanks
> Alin
>
> -----Original Message-----
> From: Alan C. Assis <ac...@gmail.com>
> Sent: den 8 mars 2023 19:15
> To: dev@nuttx.apache.org
> Cc: Sebastien Lorquet <se...@lorquet.fr>
> Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
>
> Hi Lwazi,
>
> It is not sarcarm, I'm talking about facts.
>
> Also I didn't say Sebastien points aren't valid, but is diverting from the
> real issue.
>
> The issue is not if the discussion is happening here or there, the Problem
> is that we don't have enough reviewers.
>
> So, first step is that NuttX needs to increase the user base, but have few
> users really engaged with the project, reviewing patches every single day.
> Currently today he have few: Petro and Xiang are exceptional on this point.
> They are my inspiration to try do more!
>
> Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear from
> you again! You have a great knowledge of BLE can we need! I was expecting
> you to share that working example of BLE application using our BLE stack).
>
> BR,
>
> Alan
>
> On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
>> On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
>>> Sebastien,
>>>
>>> If all the discussions that happens on github start to happen here,
>>> this mailing list will be just like the nuttx-commits mailing list.
>> I'll take this as sarcasm. Sebastien is making a lot of valid points,
>> in good faith, and being dismissive does not help the community.
>>
RE: DISCUSSION - Usage of mailing lists for apache projects
Posted by David Sidrane <da...@nscdg.com>.
+1 100%
I think that the PR should have a summary as well to ensure it is all tied
together. Unless we enable rebase/squash the information will be disjoint.
David
-----Original Message-----
From: Alin.Jerpelea@sony.com <Al...@sony.com>
Sent: Thursday, March 9, 2023 4:13 AM
To: dev@nuttx.apache.org
Cc: Sebastien Lorquet <se...@lorquet.fr>
Subject: RE: DISCUSSION - Usage of mailing lists for apache projects
Hi all,
I agree with David but in my opinion this information should go in the
commit message and no commit without message should be merged.
Not all people will check the PR message but you will always see the reasons
simply by typing "git log" if they are in the commit message
What do you think ?
Thanks
Alin
-----Original Message-----
From: David Sidrane <da...@nscdg.com>
Sent: den 9 mars 2023 10:00
To: dev@nuttx.apache.org
Cc: Sebastien Lorquet <se...@lorquet.fr>
Subject: RE: DISCUSSION - Usage of mailing lists for apache projects
I would add that all pull request must have a statement explaining the
reason or motivation for the change(s).
Just stating the "What" was done is not enough. There must be a "Why" the
change is needed.
David
-----Original Message-----
From: Alin.Jerpelea@sony.com <Al...@sony.com>
Sent: Thursday, March 9, 2023 3:39 AM
To: dev@nuttx.apache.org
Cc: Sebastien Lorquet <se...@lorquet.fr>
Subject: RE: DISCUSSION - Usage of mailing lists for apache projects
Hi all,
I feel that this thread is getting too long without a real outcome
Some observations from my daily interactions with the project:
- I like doing reviews on github and I think that many people in this thread
would agree that this flow is good.
- I like to be able to see all bugs in one place and get statistics for the
ASF reports
What I don’t feel right
- even if I spend time daily on reviewing patches there are still changes
that I miss and it is hard to get the flow on release date
- some breaking changes are not discussed enough with the community since
there are some people that do not have time to review code on gihub.
As a way going forward I propose that we improve in 2 aspects
- All breaking commits should be discusses on dev so that people get enough
time to digest the change and even better get involved int the flow
- all breaking changes should be documented on the release confluence page
before merging so that we don’t miss mentioning them on release date.
- there should be at least 1 independent reviewer (not from the same
company) so that a patch is merged except board changes (ex an employee from
the same company merges a patch submitted by another employee from the same
company, for a board provided by the same company)
Thanks
Alin
-----Original Message-----
From: Alan C. Assis <ac...@gmail.com>
Sent: den 8 mars 2023 19:15
To: dev@nuttx.apache.org
Cc: Sebastien Lorquet <se...@lorquet.fr>
Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
Hi Lwazi,
It is not sarcarm, I'm talking about facts.
Also I didn't say Sebastien points aren't valid, but is diverting from the
real issue.
The issue is not if the discussion is happening here or there, the Problem
is that we don't have enough reviewers.
So, first step is that NuttX needs to increase the user base, but have few
users really engaged with the project, reviewing patches every single day.
Currently today he have few: Petro and Xiang are exceptional on this point.
They are my inspiration to try do more!
Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear from
you again! You have a great knowledge of BLE can we need! I was expecting
you to share that working example of BLE application using our BLE stack).
BR,
Alan
On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
> On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
>>
>> Sebastien,
>>
>> If all the discussions that happens on github start to happen here,
>> this mailing list will be just like the nuttx-commits mailing list.
>
> I'll take this as sarcasm. Sebastien is making a lot of valid points,
> in good faith, and being dismissive does not help the community.
>
RE: DISCUSSION - Usage of mailing lists for apache projects
Posted by "Alin.Jerpelea@sony.com" <Al...@sony.com>.
Hi all,
I agree with David but in my opinion this information should go in the commit message and no commit without message should be merged.
Not all people will check the PR message but you will always see the reasons simply by typing "git log" if they are in the commit message
What do you think ?
Thanks
Alin
-----Original Message-----
From: David Sidrane <da...@nscdg.com>
Sent: den 9 mars 2023 10:00
To: dev@nuttx.apache.org
Cc: Sebastien Lorquet <se...@lorquet.fr>
Subject: RE: DISCUSSION - Usage of mailing lists for apache projects
I would add that all pull request must have a statement explaining the reason or motivation for the change(s).
Just stating the "What" was done is not enough. There must be a "Why" the change is needed.
David
-----Original Message-----
From: Alin.Jerpelea@sony.com <Al...@sony.com>
Sent: Thursday, March 9, 2023 3:39 AM
To: dev@nuttx.apache.org
Cc: Sebastien Lorquet <se...@lorquet.fr>
Subject: RE: DISCUSSION - Usage of mailing lists for apache projects
Hi all,
I feel that this thread is getting too long without a real outcome
Some observations from my daily interactions with the project:
- I like doing reviews on github and I think that many people in this thread would agree that this flow is good.
- I like to be able to see all bugs in one place and get statistics for the ASF reports
What I don’t feel right
- even if I spend time daily on reviewing patches there are still changes that I miss and it is hard to get the flow on release date
- some breaking changes are not discussed enough with the community since there are some people that do not have time to review code on gihub.
As a way going forward I propose that we improve in 2 aspects
- All breaking commits should be discusses on dev so that people get enough time to digest the change and even better get involved int the flow
- all breaking changes should be documented on the release confluence page before merging so that we don’t miss mentioning them on release date.
- there should be at least 1 independent reviewer (not from the same
company) so that a patch is merged except board changes (ex an employee from the same company merges a patch submitted by another employee from the same company, for a board provided by the same company)
Thanks
Alin
-----Original Message-----
From: Alan C. Assis <ac...@gmail.com>
Sent: den 8 mars 2023 19:15
To: dev@nuttx.apache.org
Cc: Sebastien Lorquet <se...@lorquet.fr>
Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
Hi Lwazi,
It is not sarcarm, I'm talking about facts.
Also I didn't say Sebastien points aren't valid, but is diverting from the real issue.
The issue is not if the discussion is happening here or there, the Problem is that we don't have enough reviewers.
So, first step is that NuttX needs to increase the user base, but have few users really engaged with the project, reviewing patches every single day.
Currently today he have few: Petro and Xiang are exceptional on this point.
They are my inspiration to try do more!
Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear from you again! You have a great knowledge of BLE can we need! I was expecting you to share that working example of BLE application using our BLE stack).
BR,
Alan
On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
> On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
>>
>> Sebastien,
>>
>> If all the discussions that happens on github start to happen here,
>> this mailing list will be just like the nuttx-commits mailing list.
>
> I'll take this as sarcasm. Sebastien is making a lot of valid points,
> in good faith, and being dismissive does not help the community.
>
RE: DISCUSSION - Usage of mailing lists for apache projects
Posted by David Sidrane <da...@nscdg.com>.
I would add that all pull request must have a statement explaining the
reason or motivation for the change(s).
Just stating the "What" was done is not enough. There must be a "Why" the
change is needed.
David
-----Original Message-----
From: Alin.Jerpelea@sony.com <Al...@sony.com>
Sent: Thursday, March 9, 2023 3:39 AM
To: dev@nuttx.apache.org
Cc: Sebastien Lorquet <se...@lorquet.fr>
Subject: RE: DISCUSSION - Usage of mailing lists for apache projects
Hi all,
I feel that this thread is getting too long without a real outcome
Some observations from my daily interactions with the project:
- I like doing reviews on github and I think that many people in this thread
would agree that this flow is good.
- I like to be able to see all bugs in one place and get statistics for the
ASF reports
What I don’t feel right
- even if I spend time daily on reviewing patches there are still changes
that I miss and it is hard to get the flow on release date
- some breaking changes are not discussed enough with the community since
there are some people that do not have time to review code on gihub.
As a way going forward I propose that we improve in 2 aspects
- All breaking commits should be discusses on dev so that people get enough
time to digest the change and even better get involved int the flow
- all breaking changes should be documented on the release confluence page
before merging so that we don’t miss mentioning them on release date.
- there should be at least 1 independent reviewer (not from the same
company) so that a patch is merged except board changes (ex an employee from
the same company merges a patch submitted by another employee from the same
company, for a board provided by the same company)
Thanks
Alin
-----Original Message-----
From: Alan C. Assis <ac...@gmail.com>
Sent: den 8 mars 2023 19:15
To: dev@nuttx.apache.org
Cc: Sebastien Lorquet <se...@lorquet.fr>
Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
Hi Lwazi,
It is not sarcarm, I'm talking about facts.
Also I didn't say Sebastien points aren't valid, but is diverting from the
real issue.
The issue is not if the discussion is happening here or there, the Problem
is that we don't have enough reviewers.
So, first step is that NuttX needs to increase the user base, but have few
users really engaged with the project, reviewing patches every single day.
Currently today he have few: Petro and Xiang are exceptional on this point.
They are my inspiration to try do more!
Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear from
you again! You have a great knowledge of BLE can we need! I was expecting
you to share that working example of BLE application using our BLE stack).
BR,
Alan
On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
> On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
>>
>> Sebastien,
>>
>> If all the discussions that happens on github start to happen here,
>> this mailing list will be just like the nuttx-commits mailing list.
>
> I'll take this as sarcasm. Sebastien is making a lot of valid points,
> in good faith, and being dismissive does not help the community.
>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Sebastien Lorquet <se...@lorquet.fr>.
sorry wrong calculation, I meant 7 days * 0.5 hour * 50% * 4 weeks = 7
hours per month.
Still a lot, which could be saved by a few minutes of your company time
per week for specific PRs. Cause not all them need careful review.
Sebastien
Le 09/03/2023 à 11:49, Sebastien Lorquet a écrit :
> I understand that, but also, you should not force your high-speed
> development pace on other developers :)
>
> Because it also consumes a huge resource to review your requests :-)
>
> You asked me to spend half an hour a day on PR review, but you send
> 50% of all PRs, so this amounts to (7*0.5)*4 = 14 hours of free hard
> work for Xiaomi each month! This is not possible without a commercial
> contract.
>
> You are the large company, you have employees and financial resources,
> you should be doing the work, not project volunteers.
>
> Sebastien
>
> Le 09/03/2023 à 11:42, Xiang Xiao a écrit :
>> If so, most likely xiaomi will fork nuttx like Samuang and make our own
>> change. We don't want to spend the time to prepare the patch but no
>> feedback guarantee, since it consumes a huge resource to prepare the
>> patch.
>>
>> On Thu, Mar 9, 2023 at 6:15 PM Sebastien Lorquet <se...@lorquet.fr>
>> wrote:
>>
>>> Hi,
>>>
>>> This sounds like a corporate rule, does it? Not being critical here,
>>> this is just to understand.
>>>
>>>
>>> There should be no clear limit for a shared project, we just need time
>>> to take the best decisions.
>>>
>>> I feel that you cant force progress if there are no resources to do it.
>>>
>>> Remember, most of us are volunteers, right?
>>>
>>> That means you should not try to overcome volunteer availability by
>>> enforcing decisions.
>>>
>>> That also means you could have a company managed "staging
>>> repository" to
>>> match the speed you need for your internal products and roadmap, while
>>> upstream contributions are discussed and validated.
>>>
>>>
>>> I believe progress should happen more naturally if the issue is
>>> presented to us with an explanation that you actually need decisions on
>>> a point.
>>>
>>>
>>> Sebastien
>>>
>>> Le 09/03/2023 à 10:52, Xiang Xiao a écrit :
>>>> Yes, this is how I do normally, but we need the rule to ensure the PR
>>> gets
>>>> progress. e.g. the reviewer needs to give the feedback in one week,
>>>> one
>>>> month or one year.
>>>> The reviewer has the rights to approve the change and also has
>>>> duties to
>>>> make progress.
>>>>
>>>>
>>>> On Thu, Mar 9, 2023 at 5:14 PM Alin.Jerpelea@sony.com <
>>>> Alin.Jerpelea@sony.com> wrote:
>>>>
>>>>> Hi Xiang,
>>>>>
>>>>> Simply add some reviewers on the right side and they will be notified
>>> that
>>>>> someone asks them to step up
>>>>>
>>>>> Best regards
>>>>> Alin
>>>>>
>>>>>
>>>>> -----Original Message-----
>>>>> From: Xiang Xiao <xi...@gmail.com>
>>>>> Sent: den 9 mars 2023 10:12
>>>>> To: dev@nuttx.apache.org
>>>>> Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
>>>>>
>>>>> If some PR waits for a long time without any review, how to make
>>> progress?
>>>>> For example, this PR sent two weaks ago:
>>>>> https://github.com/apache/nuttx/pull/8610
>>>>>
>>>>> On Thu, Mar 9, 2023 at 4:40 PM Alin.Jerpelea@sony.com <
>>>>> Alin.Jerpelea@sony.com> wrote:
>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> I feel that this thread is getting too long without a real outcome
>>>>>>
>>>>>> Some observations from my daily interactions with the project:
>>>>>> - I like doing reviews on github and I think that many people in
>>>>>> this
>>>>>> thread would agree that this flow is good.
>>>>>> - I like to be able to see all bugs in one place and get statistics
>>>>>> for the ASF reports
>>>>>>
>>>>>> What I don’t feel right
>>>>>> - even if I spend time daily on reviewing patches there are still
>>>>>> changes that I miss and it is hard to get the flow on release date
>>>>>> - some breaking changes are not discussed enough with the community
>>>>>> since there are some people that do not have time to review code on
>>>>> gihub.
>>>>>> As a way going forward I propose that we improve in 2 aspects
>>>>>> - All breaking commits should be discusses on dev so that people get
>>>>>> enough time to digest the change and even better get involved int
>>>>>> the
>>>>>> flow
>>>>>> - all breaking changes should be documented on the release
>>>>>> confluence
>>>>>> page before merging so that we don’t miss mentioning them on release
>>>>> date.
>>>>>> - there should be at least 1 independent reviewer (not from the same
>>>>>> company) so that a patch is merged except board changes (ex an
>>>>>> employee from the same company merges a patch submitted by another
>>>>>> employee from the same company, for a board provided by the same
>>>>>> company)
>>>>>>
>>>>>> Thanks
>>>>>> Alin
>>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Alan C. Assis <ac...@gmail.com>
>>>>>> Sent: den 8 mars 2023 19:15
>>>>>> To: dev@nuttx.apache.org
>>>>>> Cc: Sebastien Lorquet <se...@lorquet.fr>
>>>>>> Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
>>>>>>
>>>>>> Hi Lwazi,
>>>>>>
>>>>>> It is not sarcarm, I'm talking about facts.
>>>>>>
>>>>>> Also I didn't say Sebastien points aren't valid, but is diverting
>>>>>> from
>>>>>> the real issue.
>>>>>>
>>>>>> The issue is not if the discussion is happening here or there, the
>>>>>> Problem is that we don't have enough reviewers.
>>>>>>
>>>>>> So, first step is that NuttX needs to increase the user base, but
>>>>>> have
>>>>>> few users really engaged with the project, reviewing patches every
>>>>> single day.
>>>>>> Currently today he have few: Petro and Xiang are exceptional on this
>>>>> point.
>>>>>> They are my inspiration to try do more!
>>>>>>
>>>>>> Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to
>>>>>> hear
>>>>>> from you again! You have a great knowledge of BLE can we need! I was
>>>>>> expecting you to share that working example of BLE application using
>>>>>> our BLE stack).
>>>>>>
>>>>>> BR,
>>>>>>
>>>>>> Alan
>>>>>>
>>>>>> On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
>>>>>>> On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com>
>>>>>>> wrote:
>>>>>>>> Sebastien,
>>>>>>>>
>>>>>>>> If all the discussions that happens on github start to happen
>>>>>>>> here,
>>>>>>>> this mailing list will be just like the nuttx-commits mailing
>>>>>>>> list.
>>>>>>> I'll take this as sarcasm. Sebastien is making a lot of valid
>>>>>>> points, in good faith, and being dismissive does not help the
>>>>> community.
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Sebastien Lorquet <se...@lorquet.fr>.
I understand that, but also, you should not force your high-speed
development pace on other developers :)
Because it also consumes a huge resource to review your requests :-)
You asked me to spend half an hour a day on PR review, but you send 50%
of all PRs, so this amounts to (7*0.5)*4 = 14 hours of free hard work
for Xiaomi each month! This is not possible without a commercial contract.
You are the large company, you have employees and financial resources,
you should be doing the work, not project volunteers.
Sebastien
Le 09/03/2023 à 11:42, Xiang Xiao a écrit :
> If so, most likely xiaomi will fork nuttx like Samuang and make our own
> change. We don't want to spend the time to prepare the patch but no
> feedback guarantee, since it consumes a huge resource to prepare the patch.
>
> On Thu, Mar 9, 2023 at 6:15 PM Sebastien Lorquet <se...@lorquet.fr>
> wrote:
>
>> Hi,
>>
>> This sounds like a corporate rule, does it? Not being critical here,
>> this is just to understand.
>>
>>
>> There should be no clear limit for a shared project, we just need time
>> to take the best decisions.
>>
>> I feel that you cant force progress if there are no resources to do it.
>>
>> Remember, most of us are volunteers, right?
>>
>> That means you should not try to overcome volunteer availability by
>> enforcing decisions.
>>
>> That also means you could have a company managed "staging repository" to
>> match the speed you need for your internal products and roadmap, while
>> upstream contributions are discussed and validated.
>>
>>
>> I believe progress should happen more naturally if the issue is
>> presented to us with an explanation that you actually need decisions on
>> a point.
>>
>>
>> Sebastien
>>
>> Le 09/03/2023 à 10:52, Xiang Xiao a écrit :
>>> Yes, this is how I do normally, but we need the rule to ensure the PR
>> gets
>>> progress. e.g. the reviewer needs to give the feedback in one week, one
>>> month or one year.
>>> The reviewer has the rights to approve the change and also has duties to
>>> make progress.
>>>
>>>
>>> On Thu, Mar 9, 2023 at 5:14 PM Alin.Jerpelea@sony.com <
>>> Alin.Jerpelea@sony.com> wrote:
>>>
>>>> Hi Xiang,
>>>>
>>>> Simply add some reviewers on the right side and they will be notified
>> that
>>>> someone asks them to step up
>>>>
>>>> Best regards
>>>> Alin
>>>>
>>>>
>>>> -----Original Message-----
>>>> From: Xiang Xiao <xi...@gmail.com>
>>>> Sent: den 9 mars 2023 10:12
>>>> To: dev@nuttx.apache.org
>>>> Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
>>>>
>>>> If some PR waits for a long time without any review, how to make
>> progress?
>>>> For example, this PR sent two weaks ago:
>>>> https://github.com/apache/nuttx/pull/8610
>>>>
>>>> On Thu, Mar 9, 2023 at 4:40 PM Alin.Jerpelea@sony.com <
>>>> Alin.Jerpelea@sony.com> wrote:
>>>>
>>>>> Hi all,
>>>>>
>>>>> I feel that this thread is getting too long without a real outcome
>>>>>
>>>>> Some observations from my daily interactions with the project:
>>>>> - I like doing reviews on github and I think that many people in this
>>>>> thread would agree that this flow is good.
>>>>> - I like to be able to see all bugs in one place and get statistics
>>>>> for the ASF reports
>>>>>
>>>>> What I don’t feel right
>>>>> - even if I spend time daily on reviewing patches there are still
>>>>> changes that I miss and it is hard to get the flow on release date
>>>>> - some breaking changes are not discussed enough with the community
>>>>> since there are some people that do not have time to review code on
>>>> gihub.
>>>>> As a way going forward I propose that we improve in 2 aspects
>>>>> - All breaking commits should be discusses on dev so that people get
>>>>> enough time to digest the change and even better get involved int the
>>>>> flow
>>>>> - all breaking changes should be documented on the release confluence
>>>>> page before merging so that we don’t miss mentioning them on release
>>>> date.
>>>>> - there should be at least 1 independent reviewer (not from the same
>>>>> company) so that a patch is merged except board changes (ex an
>>>>> employee from the same company merges a patch submitted by another
>>>>> employee from the same company, for a board provided by the same
>>>>> company)
>>>>>
>>>>> Thanks
>>>>> Alin
>>>>>
>>>>> -----Original Message-----
>>>>> From: Alan C. Assis <ac...@gmail.com>
>>>>> Sent: den 8 mars 2023 19:15
>>>>> To: dev@nuttx.apache.org
>>>>> Cc: Sebastien Lorquet <se...@lorquet.fr>
>>>>> Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
>>>>>
>>>>> Hi Lwazi,
>>>>>
>>>>> It is not sarcarm, I'm talking about facts.
>>>>>
>>>>> Also I didn't say Sebastien points aren't valid, but is diverting from
>>>>> the real issue.
>>>>>
>>>>> The issue is not if the discussion is happening here or there, the
>>>>> Problem is that we don't have enough reviewers.
>>>>>
>>>>> So, first step is that NuttX needs to increase the user base, but have
>>>>> few users really engaged with the project, reviewing patches every
>>>> single day.
>>>>> Currently today he have few: Petro and Xiang are exceptional on this
>>>> point.
>>>>> They are my inspiration to try do more!
>>>>>
>>>>> Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear
>>>>> from you again! You have a great knowledge of BLE can we need! I was
>>>>> expecting you to share that working example of BLE application using
>>>>> our BLE stack).
>>>>>
>>>>> BR,
>>>>>
>>>>> Alan
>>>>>
>>>>> On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
>>>>>> On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
>>>>>>> Sebastien,
>>>>>>>
>>>>>>> If all the discussions that happens on github start to happen here,
>>>>>>> this mailing list will be just like the nuttx-commits mailing list.
>>>>>> I'll take this as sarcasm. Sebastien is making a lot of valid
>>>>>> points, in good faith, and being dismissive does not help the
>>>> community.
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Xiang Xiao <xi...@gmail.com>.
If so, most likely xiaomi will fork nuttx like Samuang and make our own
change. We don't want to spend the time to prepare the patch but no
feedback guarantee, since it consumes a huge resource to prepare the patch.
On Thu, Mar 9, 2023 at 6:15 PM Sebastien Lorquet <se...@lorquet.fr>
wrote:
> Hi,
>
> This sounds like a corporate rule, does it? Not being critical here,
> this is just to understand.
>
>
> There should be no clear limit for a shared project, we just need time
> to take the best decisions.
>
> I feel that you cant force progress if there are no resources to do it.
>
> Remember, most of us are volunteers, right?
>
> That means you should not try to overcome volunteer availability by
> enforcing decisions.
>
> That also means you could have a company managed "staging repository" to
> match the speed you need for your internal products and roadmap, while
> upstream contributions are discussed and validated.
>
>
> I believe progress should happen more naturally if the issue is
> presented to us with an explanation that you actually need decisions on
> a point.
>
>
> Sebastien
>
> Le 09/03/2023 à 10:52, Xiang Xiao a écrit :
> > Yes, this is how I do normally, but we need the rule to ensure the PR
> gets
> > progress. e.g. the reviewer needs to give the feedback in one week, one
> > month or one year.
> > The reviewer has the rights to approve the change and also has duties to
> > make progress.
> >
> >
> > On Thu, Mar 9, 2023 at 5:14 PM Alin.Jerpelea@sony.com <
> > Alin.Jerpelea@sony.com> wrote:
> >
> >> Hi Xiang,
> >>
> >> Simply add some reviewers on the right side and they will be notified
> that
> >> someone asks them to step up
> >>
> >> Best regards
> >> Alin
> >>
> >>
> >> -----Original Message-----
> >> From: Xiang Xiao <xi...@gmail.com>
> >> Sent: den 9 mars 2023 10:12
> >> To: dev@nuttx.apache.org
> >> Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
> >>
> >> If some PR waits for a long time without any review, how to make
> progress?
> >> For example, this PR sent two weaks ago:
> >> https://github.com/apache/nuttx/pull/8610
> >>
> >> On Thu, Mar 9, 2023 at 4:40 PM Alin.Jerpelea@sony.com <
> >> Alin.Jerpelea@sony.com> wrote:
> >>
> >>> Hi all,
> >>>
> >>> I feel that this thread is getting too long without a real outcome
> >>>
> >>> Some observations from my daily interactions with the project:
> >>> - I like doing reviews on github and I think that many people in this
> >>> thread would agree that this flow is good.
> >>> - I like to be able to see all bugs in one place and get statistics
> >>> for the ASF reports
> >>>
> >>> What I don’t feel right
> >>> - even if I spend time daily on reviewing patches there are still
> >>> changes that I miss and it is hard to get the flow on release date
> >>> - some breaking changes are not discussed enough with the community
> >>> since there are some people that do not have time to review code on
> >> gihub.
> >>> As a way going forward I propose that we improve in 2 aspects
> >>> - All breaking commits should be discusses on dev so that people get
> >>> enough time to digest the change and even better get involved int the
> >>> flow
> >>> - all breaking changes should be documented on the release confluence
> >>> page before merging so that we don’t miss mentioning them on release
> >> date.
> >>> - there should be at least 1 independent reviewer (not from the same
> >>> company) so that a patch is merged except board changes (ex an
> >>> employee from the same company merges a patch submitted by another
> >>> employee from the same company, for a board provided by the same
> >>> company)
> >>>
> >>> Thanks
> >>> Alin
> >>>
> >>> -----Original Message-----
> >>> From: Alan C. Assis <ac...@gmail.com>
> >>> Sent: den 8 mars 2023 19:15
> >>> To: dev@nuttx.apache.org
> >>> Cc: Sebastien Lorquet <se...@lorquet.fr>
> >>> Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
> >>>
> >>> Hi Lwazi,
> >>>
> >>> It is not sarcarm, I'm talking about facts.
> >>>
> >>> Also I didn't say Sebastien points aren't valid, but is diverting from
> >>> the real issue.
> >>>
> >>> The issue is not if the discussion is happening here or there, the
> >>> Problem is that we don't have enough reviewers.
> >>>
> >>> So, first step is that NuttX needs to increase the user base, but have
> >>> few users really engaged with the project, reviewing patches every
> >> single day.
> >>> Currently today he have few: Petro and Xiang are exceptional on this
> >> point.
> >>> They are my inspiration to try do more!
> >>>
> >>> Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear
> >>> from you again! You have a great knowledge of BLE can we need! I was
> >>> expecting you to share that working example of BLE application using
> >>> our BLE stack).
> >>>
> >>> BR,
> >>>
> >>> Alan
> >>>
> >>> On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
> >>>> On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
> >>>>> Sebastien,
> >>>>>
> >>>>> If all the discussions that happens on github start to happen here,
> >>>>> this mailing list will be just like the nuttx-commits mailing list.
> >>>> I'll take this as sarcasm. Sebastien is making a lot of valid
> >>>> points, in good faith, and being dismissive does not help the
> >> community.
>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Sebastien Lorquet <se...@lorquet.fr>.
Hi,
This sounds like a corporate rule, does it? Not being critical here,
this is just to understand.
There should be no clear limit for a shared project, we just need time
to take the best decisions.
I feel that you cant force progress if there are no resources to do it.
Remember, most of us are volunteers, right?
That means you should not try to overcome volunteer availability by
enforcing decisions.
That also means you could have a company managed "staging repository" to
match the speed you need for your internal products and roadmap, while
upstream contributions are discussed and validated.
I believe progress should happen more naturally if the issue is
presented to us with an explanation that you actually need decisions on
a point.
Sebastien
Le 09/03/2023 à 10:52, Xiang Xiao a écrit :
> Yes, this is how I do normally, but we need the rule to ensure the PR gets
> progress. e.g. the reviewer needs to give the feedback in one week, one
> month or one year.
> The reviewer has the rights to approve the change and also has duties to
> make progress.
>
>
> On Thu, Mar 9, 2023 at 5:14 PM Alin.Jerpelea@sony.com <
> Alin.Jerpelea@sony.com> wrote:
>
>> Hi Xiang,
>>
>> Simply add some reviewers on the right side and they will be notified that
>> someone asks them to step up
>>
>> Best regards
>> Alin
>>
>>
>> -----Original Message-----
>> From: Xiang Xiao <xi...@gmail.com>
>> Sent: den 9 mars 2023 10:12
>> To: dev@nuttx.apache.org
>> Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
>>
>> If some PR waits for a long time without any review, how to make progress?
>> For example, this PR sent two weaks ago:
>> https://github.com/apache/nuttx/pull/8610
>>
>> On Thu, Mar 9, 2023 at 4:40 PM Alin.Jerpelea@sony.com <
>> Alin.Jerpelea@sony.com> wrote:
>>
>>> Hi all,
>>>
>>> I feel that this thread is getting too long without a real outcome
>>>
>>> Some observations from my daily interactions with the project:
>>> - I like doing reviews on github and I think that many people in this
>>> thread would agree that this flow is good.
>>> - I like to be able to see all bugs in one place and get statistics
>>> for the ASF reports
>>>
>>> What I don’t feel right
>>> - even if I spend time daily on reviewing patches there are still
>>> changes that I miss and it is hard to get the flow on release date
>>> - some breaking changes are not discussed enough with the community
>>> since there are some people that do not have time to review code on
>> gihub.
>>> As a way going forward I propose that we improve in 2 aspects
>>> - All breaking commits should be discusses on dev so that people get
>>> enough time to digest the change and even better get involved int the
>>> flow
>>> - all breaking changes should be documented on the release confluence
>>> page before merging so that we don’t miss mentioning them on release
>> date.
>>> - there should be at least 1 independent reviewer (not from the same
>>> company) so that a patch is merged except board changes (ex an
>>> employee from the same company merges a patch submitted by another
>>> employee from the same company, for a board provided by the same
>>> company)
>>>
>>> Thanks
>>> Alin
>>>
>>> -----Original Message-----
>>> From: Alan C. Assis <ac...@gmail.com>
>>> Sent: den 8 mars 2023 19:15
>>> To: dev@nuttx.apache.org
>>> Cc: Sebastien Lorquet <se...@lorquet.fr>
>>> Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
>>>
>>> Hi Lwazi,
>>>
>>> It is not sarcarm, I'm talking about facts.
>>>
>>> Also I didn't say Sebastien points aren't valid, but is diverting from
>>> the real issue.
>>>
>>> The issue is not if the discussion is happening here or there, the
>>> Problem is that we don't have enough reviewers.
>>>
>>> So, first step is that NuttX needs to increase the user base, but have
>>> few users really engaged with the project, reviewing patches every
>> single day.
>>> Currently today he have few: Petro and Xiang are exceptional on this
>> point.
>>> They are my inspiration to try do more!
>>>
>>> Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear
>>> from you again! You have a great knowledge of BLE can we need! I was
>>> expecting you to share that working example of BLE application using
>>> our BLE stack).
>>>
>>> BR,
>>>
>>> Alan
>>>
>>> On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
>>>> On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
>>>>> Sebastien,
>>>>>
>>>>> If all the discussions that happens on github start to happen here,
>>>>> this mailing list will be just like the nuttx-commits mailing list.
>>>> I'll take this as sarcasm. Sebastien is making a lot of valid
>>>> points, in good faith, and being dismissive does not help the
>> community.
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Xiang Xiao <xi...@gmail.com>.
Yes, this is how I do normally, but we need the rule to ensure the PR gets
progress. e.g. the reviewer needs to give the feedback in one week, one
month or one year.
The reviewer has the rights to approve the change and also has duties to
make progress.
On Thu, Mar 9, 2023 at 5:14 PM Alin.Jerpelea@sony.com <
Alin.Jerpelea@sony.com> wrote:
> Hi Xiang,
>
> Simply add some reviewers on the right side and they will be notified that
> someone asks them to step up
>
> Best regards
> Alin
>
>
> -----Original Message-----
> From: Xiang Xiao <xi...@gmail.com>
> Sent: den 9 mars 2023 10:12
> To: dev@nuttx.apache.org
> Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
>
> If some PR waits for a long time without any review, how to make progress?
> For example, this PR sent two weaks ago:
> https://github.com/apache/nuttx/pull/8610
>
> On Thu, Mar 9, 2023 at 4:40 PM Alin.Jerpelea@sony.com <
> Alin.Jerpelea@sony.com> wrote:
>
> > Hi all,
> >
> > I feel that this thread is getting too long without a real outcome
> >
> > Some observations from my daily interactions with the project:
> > - I like doing reviews on github and I think that many people in this
> > thread would agree that this flow is good.
> > - I like to be able to see all bugs in one place and get statistics
> > for the ASF reports
> >
> > What I don’t feel right
> > - even if I spend time daily on reviewing patches there are still
> > changes that I miss and it is hard to get the flow on release date
> > - some breaking changes are not discussed enough with the community
> > since there are some people that do not have time to review code on
> gihub.
> >
> > As a way going forward I propose that we improve in 2 aspects
> > - All breaking commits should be discusses on dev so that people get
> > enough time to digest the change and even better get involved int the
> > flow
> > - all breaking changes should be documented on the release confluence
> > page before merging so that we don’t miss mentioning them on release
> date.
> > - there should be at least 1 independent reviewer (not from the same
> > company) so that a patch is merged except board changes (ex an
> > employee from the same company merges a patch submitted by another
> > employee from the same company, for a board provided by the same
> > company)
> >
> > Thanks
> > Alin
> >
> > -----Original Message-----
> > From: Alan C. Assis <ac...@gmail.com>
> > Sent: den 8 mars 2023 19:15
> > To: dev@nuttx.apache.org
> > Cc: Sebastien Lorquet <se...@lorquet.fr>
> > Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
> >
> > Hi Lwazi,
> >
> > It is not sarcarm, I'm talking about facts.
> >
> > Also I didn't say Sebastien points aren't valid, but is diverting from
> > the real issue.
> >
> > The issue is not if the discussion is happening here or there, the
> > Problem is that we don't have enough reviewers.
> >
> > So, first step is that NuttX needs to increase the user base, but have
> > few users really engaged with the project, reviewing patches every
> single day.
> > Currently today he have few: Petro and Xiang are exceptional on this
> point.
> > They are my inspiration to try do more!
> >
> > Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear
> > from you again! You have a great knowledge of BLE can we need! I was
> > expecting you to share that working example of BLE application using
> > our BLE stack).
> >
> > BR,
> >
> > Alan
> >
> > On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
> > > On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
> > >>
> > >> Sebastien,
> > >>
> > >> If all the discussions that happens on github start to happen here,
> > >> this mailing list will be just like the nuttx-commits mailing list.
> > >
> > > I'll take this as sarcasm. Sebastien is making a lot of valid
> > > points, in good faith, and being dismissive does not help the
> community.
> > >
> >
>
RE: DISCUSSION - Usage of mailing lists for apache projects
Posted by "Alin.Jerpelea@sony.com" <Al...@sony.com>.
Hi Xiang,
Simply add some reviewers on the right side and they will be notified that someone asks them to step up
Best regards
Alin
-----Original Message-----
From: Xiang Xiao <xi...@gmail.com>
Sent: den 9 mars 2023 10:12
To: dev@nuttx.apache.org
Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
If some PR waits for a long time without any review, how to make progress?
For example, this PR sent two weaks ago:
https://github.com/apache/nuttx/pull/8610
On Thu, Mar 9, 2023 at 4:40 PM Alin.Jerpelea@sony.com < Alin.Jerpelea@sony.com> wrote:
> Hi all,
>
> I feel that this thread is getting too long without a real outcome
>
> Some observations from my daily interactions with the project:
> - I like doing reviews on github and I think that many people in this
> thread would agree that this flow is good.
> - I like to be able to see all bugs in one place and get statistics
> for the ASF reports
>
> What I don’t feel right
> - even if I spend time daily on reviewing patches there are still
> changes that I miss and it is hard to get the flow on release date
> - some breaking changes are not discussed enough with the community
> since there are some people that do not have time to review code on gihub.
>
> As a way going forward I propose that we improve in 2 aspects
> - All breaking commits should be discusses on dev so that people get
> enough time to digest the change and even better get involved int the
> flow
> - all breaking changes should be documented on the release confluence
> page before merging so that we don’t miss mentioning them on release date.
> - there should be at least 1 independent reviewer (not from the same
> company) so that a patch is merged except board changes (ex an
> employee from the same company merges a patch submitted by another
> employee from the same company, for a board provided by the same
> company)
>
> Thanks
> Alin
>
> -----Original Message-----
> From: Alan C. Assis <ac...@gmail.com>
> Sent: den 8 mars 2023 19:15
> To: dev@nuttx.apache.org
> Cc: Sebastien Lorquet <se...@lorquet.fr>
> Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
>
> Hi Lwazi,
>
> It is not sarcarm, I'm talking about facts.
>
> Also I didn't say Sebastien points aren't valid, but is diverting from
> the real issue.
>
> The issue is not if the discussion is happening here or there, the
> Problem is that we don't have enough reviewers.
>
> So, first step is that NuttX needs to increase the user base, but have
> few users really engaged with the project, reviewing patches every single day.
> Currently today he have few: Petro and Xiang are exceptional on this point.
> They are my inspiration to try do more!
>
> Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear
> from you again! You have a great knowledge of BLE can we need! I was
> expecting you to share that working example of BLE application using
> our BLE stack).
>
> BR,
>
> Alan
>
> On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
> > On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
> >>
> >> Sebastien,
> >>
> >> If all the discussions that happens on github start to happen here,
> >> this mailing list will be just like the nuttx-commits mailing list.
> >
> > I'll take this as sarcasm. Sebastien is making a lot of valid
> > points, in good faith, and being dismissive does not help the community.
> >
>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Gregory Nutt <sp...@gmail.com>.
> First of all, people never respect pull request formats if this is not
> enforced. So enforcement is required as well.
No member of the PMC has authority over any other. An Apache project is
ultra democratic bordering on anarchistic. Each member is basically a
"sovereign citizen."
So we cannot command anyone to do anything. We cannot assign anyone to
do anything. We cannot enforce anything other than through processes
and tools. Good arguments with a little social pressure are the only
available tools to manage the project.
In order to accomplish anything, there really has to be discussion (like
this), consensus, and agreement. Achieving that is painful and slow --
and quickly exceeds my ability to be patience.
That is what you have to work with.
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Sebastien Lorquet <se...@lorquet.fr>.
First of all, people never respect pull request formats if this is not
enforced. So enforcement is required as well.
But this is not sufficient by itself, since a programmer's initial
impression of a change can be widely and underestimated.
Often times you *really need* that pull request integrated asap, so you
will minimize its impact.
No tool can catch that. Impact evaluation is the responsibility of the
busy committer, and it cannot be trusted. This will lead to important
problems filtering right through without anyone noticing.
So as a conclusion I dont think that it would help a lot.
Sebastien
Le 09/03/2023 à 10:34, raiden00pl a écrit :
>> - All breaking commits should be discusses on dev so that people get
> enough time to digest the change and even better get involved int the flow
>
> I think "all breaking commits" is too broad and impractical.
> What about code guarded with CONFIG_EXPERIMENTAL? What about the features
> just added or fresh architectures?
> Maybe we should limit this statement to breaking changes in relation to the
> previous release and not marked as EXPERIMENTAL.
>
> Another thing, can we add a simple comment in the "Impact" section of the
> Nuttx PR template about notifying the list in the case of a breakage change.
>
> czw., 9 mar 2023 o 10:24 Sebastien Lorquet <se...@lorquet.fr>
> napisał(a):
>
>> Notify the list!
>>
>> Simple as that.
>>
>> If there is no progress, it means this is a complex PR that needs
>> attention.
>>
>> Just adding reviewers keep the issue github-centric.
>>
>> Sebastien
>>
>> Le 09/03/2023 à 10:11, Xiang Xiao a écrit :
>>> If some PR waits for a long time without any review, how to make
>> progress?
>>> For example, this PR sent two weaks ago:
>>> https://github.com/apache/nuttx/pull/8610
>>>
>>> On Thu, Mar 9, 2023 at 4:40 PM Alin.Jerpelea@sony.com <
>>> Alin.Jerpelea@sony.com> wrote:
>>>
>>>> Hi all,
>>>>
>>>> I feel that this thread is getting too long without a real outcome
>>>>
>>>> Some observations from my daily interactions with the project:
>>>> - I like doing reviews on github and I think that many people in this
>>>> thread would agree that this flow is good.
>>>> - I like to be able to see all bugs in one place and get statistics for
>>>> the ASF reports
>>>>
>>>> What I don’t feel right
>>>> - even if I spend time daily on reviewing patches there are still
>> changes
>>>> that I miss and it is hard to get the flow on release date
>>>> - some breaking changes are not discussed enough with the community
>> since
>>>> there are some people that do not have time to review code on gihub.
>>>>
>>>> As a way going forward I propose that we improve in 2 aspects
>>>> - All breaking commits should be discusses on dev so that people get
>>>> enough time to digest the change and even better get involved int the
>> flow
>>>> - all breaking changes should be documented on the release confluence
>> page
>>>> before merging so that we don’t miss mentioning them on release date.
>>>> - there should be at least 1 independent reviewer (not from the same
>>>> company) so that a patch is merged except board changes (ex an employee
>>>> from the same company merges a patch submitted by another employee from
>> the
>>>> same company, for a board provided by the same company)
>>>>
>>>> Thanks
>>>> Alin
>>>>
>>>> -----Original Message-----
>>>> From: Alan C. Assis <ac...@gmail.com>
>>>> Sent: den 8 mars 2023 19:15
>>>> To: dev@nuttx.apache.org
>>>> Cc: Sebastien Lorquet <se...@lorquet.fr>
>>>> Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
>>>>
>>>> Hi Lwazi,
>>>>
>>>> It is not sarcarm, I'm talking about facts.
>>>>
>>>> Also I didn't say Sebastien points aren't valid, but is diverting from
>> the
>>>> real issue.
>>>>
>>>> The issue is not if the discussion is happening here or there, the
>> Problem
>>>> is that we don't have enough reviewers.
>>>>
>>>> So, first step is that NuttX needs to increase the user base, but have
>> few
>>>> users really engaged with the project, reviewing patches every single
>> day.
>>>> Currently today he have few: Petro and Xiang are exceptional on this
>> point.
>>>> They are my inspiration to try do more!
>>>>
>>>> Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear
>>>> from you again! You have a great knowledge of BLE can we need! I was
>>>> expecting you to share that working example of BLE application using our
>>>> BLE stack).
>>>>
>>>> BR,
>>>>
>>>> Alan
>>>>
>>>> On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
>>>>> On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
>>>>>> Sebastien,
>>>>>>
>>>>>> If all the discussions that happens on github start to happen here,
>>>>>> this mailing list will be just like the nuttx-commits mailing list.
>>>>> I'll take this as sarcasm. Sebastien is making a lot of valid points,
>>>>> in good faith, and being dismissive does not help the community.
>>>>>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by raiden00pl <ra...@gmail.com>.
> - All breaking commits should be discusses on dev so that people get
enough time to digest the change and even better get involved int the flow
I think "all breaking commits" is too broad and impractical.
What about code guarded with CONFIG_EXPERIMENTAL? What about the features
just added or fresh architectures?
Maybe we should limit this statement to breaking changes in relation to the
previous release and not marked as EXPERIMENTAL.
Another thing, can we add a simple comment in the "Impact" section of the
Nuttx PR template about notifying the list in the case of a breakage change.
czw., 9 mar 2023 o 10:24 Sebastien Lorquet <se...@lorquet.fr>
napisał(a):
> Notify the list!
>
> Simple as that.
>
> If there is no progress, it means this is a complex PR that needs
> attention.
>
> Just adding reviewers keep the issue github-centric.
>
> Sebastien
>
> Le 09/03/2023 à 10:11, Xiang Xiao a écrit :
> > If some PR waits for a long time without any review, how to make
> progress?
> > For example, this PR sent two weaks ago:
> > https://github.com/apache/nuttx/pull/8610
> >
> > On Thu, Mar 9, 2023 at 4:40 PM Alin.Jerpelea@sony.com <
> > Alin.Jerpelea@sony.com> wrote:
> >
> >> Hi all,
> >>
> >> I feel that this thread is getting too long without a real outcome
> >>
> >> Some observations from my daily interactions with the project:
> >> - I like doing reviews on github and I think that many people in this
> >> thread would agree that this flow is good.
> >> - I like to be able to see all bugs in one place and get statistics for
> >> the ASF reports
> >>
> >> What I don’t feel right
> >> - even if I spend time daily on reviewing patches there are still
> changes
> >> that I miss and it is hard to get the flow on release date
> >> - some breaking changes are not discussed enough with the community
> since
> >> there are some people that do not have time to review code on gihub.
> >>
> >> As a way going forward I propose that we improve in 2 aspects
> >> - All breaking commits should be discusses on dev so that people get
> >> enough time to digest the change and even better get involved int the
> flow
> >> - all breaking changes should be documented on the release confluence
> page
> >> before merging so that we don’t miss mentioning them on release date.
> >> - there should be at least 1 independent reviewer (not from the same
> >> company) so that a patch is merged except board changes (ex an employee
> >> from the same company merges a patch submitted by another employee from
> the
> >> same company, for a board provided by the same company)
> >>
> >> Thanks
> >> Alin
> >>
> >> -----Original Message-----
> >> From: Alan C. Assis <ac...@gmail.com>
> >> Sent: den 8 mars 2023 19:15
> >> To: dev@nuttx.apache.org
> >> Cc: Sebastien Lorquet <se...@lorquet.fr>
> >> Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
> >>
> >> Hi Lwazi,
> >>
> >> It is not sarcarm, I'm talking about facts.
> >>
> >> Also I didn't say Sebastien points aren't valid, but is diverting from
> the
> >> real issue.
> >>
> >> The issue is not if the discussion is happening here or there, the
> Problem
> >> is that we don't have enough reviewers.
> >>
> >> So, first step is that NuttX needs to increase the user base, but have
> few
> >> users really engaged with the project, reviewing patches every single
> day.
> >> Currently today he have few: Petro and Xiang are exceptional on this
> point.
> >> They are my inspiration to try do more!
> >>
> >> Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear
> >> from you again! You have a great knowledge of BLE can we need! I was
> >> expecting you to share that working example of BLE application using our
> >> BLE stack).
> >>
> >> BR,
> >>
> >> Alan
> >>
> >> On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
> >>> On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
> >>>> Sebastien,
> >>>>
> >>>> If all the discussions that happens on github start to happen here,
> >>>> this mailing list will be just like the nuttx-commits mailing list.
> >>> I'll take this as sarcasm. Sebastien is making a lot of valid points,
> >>> in good faith, and being dismissive does not help the community.
> >>>
>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Sebastien Lorquet <se...@lorquet.fr>.
Notify the list!
Simple as that.
If there is no progress, it means this is a complex PR that needs attention.
Just adding reviewers keep the issue github-centric.
Sebastien
Le 09/03/2023 à 10:11, Xiang Xiao a écrit :
> If some PR waits for a long time without any review, how to make progress?
> For example, this PR sent two weaks ago:
> https://github.com/apache/nuttx/pull/8610
>
> On Thu, Mar 9, 2023 at 4:40 PM Alin.Jerpelea@sony.com <
> Alin.Jerpelea@sony.com> wrote:
>
>> Hi all,
>>
>> I feel that this thread is getting too long without a real outcome
>>
>> Some observations from my daily interactions with the project:
>> - I like doing reviews on github and I think that many people in this
>> thread would agree that this flow is good.
>> - I like to be able to see all bugs in one place and get statistics for
>> the ASF reports
>>
>> What I don’t feel right
>> - even if I spend time daily on reviewing patches there are still changes
>> that I miss and it is hard to get the flow on release date
>> - some breaking changes are not discussed enough with the community since
>> there are some people that do not have time to review code on gihub.
>>
>> As a way going forward I propose that we improve in 2 aspects
>> - All breaking commits should be discusses on dev so that people get
>> enough time to digest the change and even better get involved int the flow
>> - all breaking changes should be documented on the release confluence page
>> before merging so that we don’t miss mentioning them on release date.
>> - there should be at least 1 independent reviewer (not from the same
>> company) so that a patch is merged except board changes (ex an employee
>> from the same company merges a patch submitted by another employee from the
>> same company, for a board provided by the same company)
>>
>> Thanks
>> Alin
>>
>> -----Original Message-----
>> From: Alan C. Assis <ac...@gmail.com>
>> Sent: den 8 mars 2023 19:15
>> To: dev@nuttx.apache.org
>> Cc: Sebastien Lorquet <se...@lorquet.fr>
>> Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
>>
>> Hi Lwazi,
>>
>> It is not sarcarm, I'm talking about facts.
>>
>> Also I didn't say Sebastien points aren't valid, but is diverting from the
>> real issue.
>>
>> The issue is not if the discussion is happening here or there, the Problem
>> is that we don't have enough reviewers.
>>
>> So, first step is that NuttX needs to increase the user base, but have few
>> users really engaged with the project, reviewing patches every single day.
>> Currently today he have few: Petro and Xiang are exceptional on this point.
>> They are my inspiration to try do more!
>>
>> Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear
>> from you again! You have a great knowledge of BLE can we need! I was
>> expecting you to share that working example of BLE application using our
>> BLE stack).
>>
>> BR,
>>
>> Alan
>>
>> On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
>>> On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
>>>> Sebastien,
>>>>
>>>> If all the discussions that happens on github start to happen here,
>>>> this mailing list will be just like the nuttx-commits mailing list.
>>> I'll take this as sarcasm. Sebastien is making a lot of valid points,
>>> in good faith, and being dismissive does not help the community.
>>>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Xiang Xiao <xi...@gmail.com>.
If some PR waits for a long time without any review, how to make progress?
For example, this PR sent two weaks ago:
https://github.com/apache/nuttx/pull/8610
On Thu, Mar 9, 2023 at 4:40 PM Alin.Jerpelea@sony.com <
Alin.Jerpelea@sony.com> wrote:
> Hi all,
>
> I feel that this thread is getting too long without a real outcome
>
> Some observations from my daily interactions with the project:
> - I like doing reviews on github and I think that many people in this
> thread would agree that this flow is good.
> - I like to be able to see all bugs in one place and get statistics for
> the ASF reports
>
> What I don’t feel right
> - even if I spend time daily on reviewing patches there are still changes
> that I miss and it is hard to get the flow on release date
> - some breaking changes are not discussed enough with the community since
> there are some people that do not have time to review code on gihub.
>
> As a way going forward I propose that we improve in 2 aspects
> - All breaking commits should be discusses on dev so that people get
> enough time to digest the change and even better get involved int the flow
> - all breaking changes should be documented on the release confluence page
> before merging so that we don’t miss mentioning them on release date.
> - there should be at least 1 independent reviewer (not from the same
> company) so that a patch is merged except board changes (ex an employee
> from the same company merges a patch submitted by another employee from the
> same company, for a board provided by the same company)
>
> Thanks
> Alin
>
> -----Original Message-----
> From: Alan C. Assis <ac...@gmail.com>
> Sent: den 8 mars 2023 19:15
> To: dev@nuttx.apache.org
> Cc: Sebastien Lorquet <se...@lorquet.fr>
> Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
>
> Hi Lwazi,
>
> It is not sarcarm, I'm talking about facts.
>
> Also I didn't say Sebastien points aren't valid, but is diverting from the
> real issue.
>
> The issue is not if the discussion is happening here or there, the Problem
> is that we don't have enough reviewers.
>
> So, first step is that NuttX needs to increase the user base, but have few
> users really engaged with the project, reviewing patches every single day.
> Currently today he have few: Petro and Xiang are exceptional on this point.
> They are my inspiration to try do more!
>
> Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear
> from you again! You have a great knowledge of BLE can we need! I was
> expecting you to share that working example of BLE application using our
> BLE stack).
>
> BR,
>
> Alan
>
> On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
> > On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
> >>
> >> Sebastien,
> >>
> >> If all the discussions that happens on github start to happen here,
> >> this mailing list will be just like the nuttx-commits mailing list.
> >
> > I'll take this as sarcasm. Sebastien is making a lot of valid points,
> > in good faith, and being dismissive does not help the community.
> >
>
RE: DISCUSSION - Usage of mailing lists for apache projects
Posted by "Alin.Jerpelea@sony.com" <Al...@sony.com>.
Hi all,
I feel that this thread is getting too long without a real outcome
Some observations from my daily interactions with the project:
- I like doing reviews on github and I think that many people in this thread would agree that this flow is good.
- I like to be able to see all bugs in one place and get statistics for the ASF reports
What I don’t feel right
- even if I spend time daily on reviewing patches there are still changes that I miss and it is hard to get the flow on release date
- some breaking changes are not discussed enough with the community since there are some people that do not have time to review code on gihub.
As a way going forward I propose that we improve in 2 aspects
- All breaking commits should be discusses on dev so that people get enough time to digest the change and even better get involved int the flow
- all breaking changes should be documented on the release confluence page before merging so that we don’t miss mentioning them on release date.
- there should be at least 1 independent reviewer (not from the same company) so that a patch is merged except board changes (ex an employee from the same company merges a patch submitted by another employee from the same company, for a board provided by the same company)
Thanks
Alin
-----Original Message-----
From: Alan C. Assis <ac...@gmail.com>
Sent: den 8 mars 2023 19:15
To: dev@nuttx.apache.org
Cc: Sebastien Lorquet <se...@lorquet.fr>
Subject: Re: DISCUSSION - Usage of mailing lists for apache projects
Hi Lwazi,
It is not sarcarm, I'm talking about facts.
Also I didn't say Sebastien points aren't valid, but is diverting from the real issue.
The issue is not if the discussion is happening here or there, the Problem is that we don't have enough reviewers.
So, first step is that NuttX needs to increase the user base, but have few users really engaged with the project, reviewing patches every single day. Currently today he have few: Petro and Xiang are exceptional on this point. They are my inspiration to try do more!
Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear from you again! You have a great knowledge of BLE can we need! I was expecting you to share that working example of BLE application using our BLE stack).
BR,
Alan
On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
> On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
>>
>> Sebastien,
>>
>> If all the discussions that happens on github start to happen here,
>> this mailing list will be just like the nuttx-commits mailing list.
>
> I'll take this as sarcasm. Sebastien is making a lot of valid points,
> in good faith, and being dismissive does not help the community.
>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by "Alan C. Assis" <ac...@gmail.com>.
Hi Lwazi,
It is not sarcarm, I'm talking about facts.
Also I didn't say Sebastien points aren't valid, but is diverting from
the real issue.
The issue is not if the discussion is happening here or there, the
Problem is that we don't have enough reviewers.
So, first step is that NuttX needs to increase the user base, but have
few users really engaged with the project, reviewing patches every
single day. Currently today he have few: Petro and Xiang are
exceptional on this point. They are my inspiration to try do more!
Welcome back go NuttX Lwazi (I'm not been sarcastic, I'm happy to hear
from you again! You have a great knowledge of BLE can we need! I was
expecting you to share that working example of BLE application using
our BLE stack).
BR,
Alan
On 3/8/23, Lwazi Dube <lw...@gmail.com> wrote:
> On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
>>
>> Sebastien,
>>
>> If all the discussions that happens on github start to happen here,
>> this mailing list will be just like the nuttx-commits mailing list.
>
> I'll take this as sarcasm. Sebastien is making a lot of valid points,
> in good faith, and being dismissive does not help the community.
>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Lwazi Dube <lw...@gmail.com>.
On Wed, 8 Mar 2023 at 09:55, Alan C. Assis <ac...@gmail.com> wrote:
>
> Sebastien,
>
> If all the discussions that happens on github start to happen here,
> this mailing list will be just like the nuttx-commits mailing list.
I'll take this as sarcasm. Sebastien is making a lot of valid points,
in good faith, and being dismissive does not help the community.
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by "Alan C. Assis" <ac...@gmail.com>.
Sebastien,
If all the discussions that happens on github start to happen here,
this mailing list will be just like the nuttx-commits mailing list.
So, your point is a catch 22! (dilemma)... You are against using
github and against have a mailing list with huge email messages.
Also you cannot complain that more than 90% of commits are coming from Xiaomi.
And the only reason that many PRs are approved and merged by Xiaomi
people is because we don't have enough reviewers to help.
So, instead complain that the route is going to wrong direction, start
to help to construct the route, simple like that!
Also, what you can do as a NuttX advocate is ask the semiconductor
company used on your project to support NuttX.
If they don't agree, move for some semiconductor company that are
contributing to NuttX (Espressif, Sony, NXP, etc).
BR,
Alan
On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
> I dont think your point of view is very realistic. You seem to be
> turning the situation into something that pleases you but is not really
> compatible with what can be observed from outside.
>
> In the archive for 2023 there are 2035 topics, I just overlooked more
> than 600 of them and ALL of them are just copies of github messages. And
> this is normal, because this is unusable.
>
> Also, I cannot actively review ALL the hundreds of pull requests that
> are regularly sent by large companies.
>
> I am primarily a user, that sometimes sends small contributions.
>
> And I am unhappy when I see that other people were careless with nice
> code and do whatever they want for their own agenda without any
> consideration for other users.
>
> To be honest I dont fully understand why SO MANY changes are required to
> core OS features that should be stable.
>
> There need to be some triage when a new pull request is sent, its
> severity evaluated by someone who is NOT in the company of the original
> contributor, and if severe, it has to be approved on the mailing list. I
> cannot do that alone, even if I try.
>
> At this point do you realize that more than !~90ish% of changes seem to
> come from xiaomi developers and most of these are approved by xiaoxiang
> alone?
>
> Because this HAS to be said. They send overwhelming numbers
> contributions that cannot be possibly understood as a whole, there is no
> clear agenda, they add whatever they like with no roadmap and no review
> from other users that may have other uses.
>
> This has to be under control somehow. I believe even you Alan are not
> aware of the amount of code that enters nuttx. No one can be now.
>
> Sebastien
>
>
> Le 08/03/2023 à 14:39, Alan C. Assis a écrit :
>> Hi Sebastien,
>>
>> Yes, that commit list is mostly for people who don't want to use
>> github but still wanting to see what is going on.
>>
>> Sometimes when a very important PR raises some concern on GitHub PR,
>> people post their concern he, it already happened many times.
>>
>> But again: the best way to guarantee that current changes please you
>> is to keep actively reviewing the PRs and contributing to the project.
>>
>> BR,
>>
>> Alan
>>
>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>>> Hi,
>>>
>>> I had a look and this mailing list is not made for human consumption.
>>>
>>> No one has ever sent a message on it manually, right?
>>>
>>> In practice, important changes are still NOT discussed on the DEV
>>> mailing list.
>>>
>>> You said yourself that "all development has moved to github".
>>>
>>> As soon as automated tests are passed, every commit is considered with a
>>> similar level of importance, however this is clearly not the case.
>>>
>>> Sebastien
>>>
>>> Le 08/03/2023 à 13:21, Alan C. Assis a écrit :
>>>> HI Sebastien,
>>>>
>>>> It is already done, you just need to subscribe to
>>>> https://lists.apache.org/list.html?commits@nuttx.apache.org to receive
>>>> all commits messages and discussions.
>>>>
>>>> Everything is archived on apache side!
>>>>
>>>> BR,
>>>>
>>>> Alan
>>>>
>>>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>>>>> Apache projects are required to use mailing lists for long term
>>>>> archival
>>>>> purposes.
>>>>>
>>>>> It seems to me that this project is avoiding that rule and moved all
>>>>> development to github
>>>>>
>>>>> This is in contradiction with the Apache project rules.
>>>>>
>>>>>
>>>>> I request clarification on this situation and requirement (instead of
>>>>> just asserting it), including a review by the apache boards.
>>>>>
>>>>>
>>>>> If it is proved that development happens primarily in github and not
>>>>> here I will request the following:
>>>>>
>>>>> -every people committing patches and submitting pull request to be
>>>>> registered on the mailing list so they are able to reply to questions
>>>>>
>>>>> -forwarding of all pull requests traffic to the mailing list
>>>>>
>>>>> For two reasons: (1) Archival purposes, and (2) open discussions with
>>>>> members that follow Apache Foundation mailing list rules and do not
>>>>> take
>>>>> part in github.
>>>>>
>>>>>
>>>>> Thank you
>>>>>
>>>>> Sebastien
>>>>>
>>>>>
>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Sebastien Lorquet <se...@lorquet.fr>.
I dont think your point of view is very realistic. You seem to be
turning the situation into something that pleases you but is not really
compatible with what can be observed from outside.
In the archive for 2023 there are 2035 topics, I just overlooked more
than 600 of them and ALL of them are just copies of github messages. And
this is normal, because this is unusable.
Also, I cannot actively review ALL the hundreds of pull requests that
are regularly sent by large companies.
I am primarily a user, that sometimes sends small contributions.
And I am unhappy when I see that other people were careless with nice
code and do whatever they want for their own agenda without any
consideration for other users.
To be honest I dont fully understand why SO MANY changes are required to
core OS features that should be stable.
There need to be some triage when a new pull request is sent, its
severity evaluated by someone who is NOT in the company of the original
contributor, and if severe, it has to be approved on the mailing list. I
cannot do that alone, even if I try.
At this point do you realize that more than !~90ish% of changes seem to
come from xiaomi developers and most of these are approved by xiaoxiang
alone?
Because this HAS to be said. They send overwhelming numbers
contributions that cannot be possibly understood as a whole, there is no
clear agenda, they add whatever they like with no roadmap and no review
from other users that may have other uses.
This has to be under control somehow. I believe even you Alan are not
aware of the amount of code that enters nuttx. No one can be now.
Sebastien
Le 08/03/2023 à 14:39, Alan C. Assis a écrit :
> Hi Sebastien,
>
> Yes, that commit list is mostly for people who don't want to use
> github but still wanting to see what is going on.
>
> Sometimes when a very important PR raises some concern on GitHub PR,
> people post their concern he, it already happened many times.
>
> But again: the best way to guarantee that current changes please you
> is to keep actively reviewing the PRs and contributing to the project.
>
> BR,
>
> Alan
>
> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>> Hi,
>>
>> I had a look and this mailing list is not made for human consumption.
>>
>> No one has ever sent a message on it manually, right?
>>
>> In practice, important changes are still NOT discussed on the DEV
>> mailing list.
>>
>> You said yourself that "all development has moved to github".
>>
>> As soon as automated tests are passed, every commit is considered with a
>> similar level of importance, however this is clearly not the case.
>>
>> Sebastien
>>
>> Le 08/03/2023 à 13:21, Alan C. Assis a écrit :
>>> HI Sebastien,
>>>
>>> It is already done, you just need to subscribe to
>>> https://lists.apache.org/list.html?commits@nuttx.apache.org to receive
>>> all commits messages and discussions.
>>>
>>> Everything is archived on apache side!
>>>
>>> BR,
>>>
>>> Alan
>>>
>>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>>>> Apache projects are required to use mailing lists for long term archival
>>>> purposes.
>>>>
>>>> It seems to me that this project is avoiding that rule and moved all
>>>> development to github
>>>>
>>>> This is in contradiction with the Apache project rules.
>>>>
>>>>
>>>> I request clarification on this situation and requirement (instead of
>>>> just asserting it), including a review by the apache boards.
>>>>
>>>>
>>>> If it is proved that development happens primarily in github and not
>>>> here I will request the following:
>>>>
>>>> -every people committing patches and submitting pull request to be
>>>> registered on the mailing list so they are able to reply to questions
>>>>
>>>> -forwarding of all pull requests traffic to the mailing list
>>>>
>>>> For two reasons: (1) Archival purposes, and (2) open discussions with
>>>> members that follow Apache Foundation mailing list rules and do not take
>>>> part in github.
>>>>
>>>>
>>>> Thank you
>>>>
>>>> Sebastien
>>>>
>>>>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by "Alan C. Assis" <ac...@gmail.com>.
s/he/here/
On 3/8/23, Alan C. Assis <ac...@gmail.com> wrote:
> Hi Sebastien,
>
> Yes, that commit list is mostly for people who don't want to use
> github but still wanting to see what is going on.
>
> Sometimes when a very important PR raises some concern on GitHub PR,
> people post their concern he, it already happened many times.
>
> But again: the best way to guarantee that current changes please you
> is to keep actively reviewing the PRs and contributing to the project.
>
> BR,
>
> Alan
>
> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>> Hi,
>>
>> I had a look and this mailing list is not made for human consumption.
>>
>> No one has ever sent a message on it manually, right?
>>
>> In practice, important changes are still NOT discussed on the DEV
>> mailing list.
>>
>> You said yourself that "all development has moved to github".
>>
>> As soon as automated tests are passed, every commit is considered with a
>> similar level of importance, however this is clearly not the case.
>>
>> Sebastien
>>
>> Le 08/03/2023 à 13:21, Alan C. Assis a écrit :
>>> HI Sebastien,
>>>
>>> It is already done, you just need to subscribe to
>>> https://lists.apache.org/list.html?commits@nuttx.apache.org to receive
>>> all commits messages and discussions.
>>>
>>> Everything is archived on apache side!
>>>
>>> BR,
>>>
>>> Alan
>>>
>>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>>>> Apache projects are required to use mailing lists for long term
>>>> archival
>>>> purposes.
>>>>
>>>> It seems to me that this project is avoiding that rule and moved all
>>>> development to github
>>>>
>>>> This is in contradiction with the Apache project rules.
>>>>
>>>>
>>>> I request clarification on this situation and requirement (instead of
>>>> just asserting it), including a review by the apache boards.
>>>>
>>>>
>>>> If it is proved that development happens primarily in github and not
>>>> here I will request the following:
>>>>
>>>> -every people committing patches and submitting pull request to be
>>>> registered on the mailing list so they are able to reply to questions
>>>>
>>>> -forwarding of all pull requests traffic to the mailing list
>>>>
>>>> For two reasons: (1) Archival purposes, and (2) open discussions with
>>>> members that follow Apache Foundation mailing list rules and do not
>>>> take
>>>> part in github.
>>>>
>>>>
>>>> Thank you
>>>>
>>>> Sebastien
>>>>
>>>>
>>
>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by "Alan C. Assis" <ac...@gmail.com>.
Hi Sebastien,
Yes, that commit list is mostly for people who don't want to use
github but still wanting to see what is going on.
Sometimes when a very important PR raises some concern on GitHub PR,
people post their concern he, it already happened many times.
But again: the best way to guarantee that current changes please you
is to keep actively reviewing the PRs and contributing to the project.
BR,
Alan
On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
> Hi,
>
> I had a look and this mailing list is not made for human consumption.
>
> No one has ever sent a message on it manually, right?
>
> In practice, important changes are still NOT discussed on the DEV
> mailing list.
>
> You said yourself that "all development has moved to github".
>
> As soon as automated tests are passed, every commit is considered with a
> similar level of importance, however this is clearly not the case.
>
> Sebastien
>
> Le 08/03/2023 à 13:21, Alan C. Assis a écrit :
>> HI Sebastien,
>>
>> It is already done, you just need to subscribe to
>> https://lists.apache.org/list.html?commits@nuttx.apache.org to receive
>> all commits messages and discussions.
>>
>> Everything is archived on apache side!
>>
>> BR,
>>
>> Alan
>>
>> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>>> Apache projects are required to use mailing lists for long term archival
>>> purposes.
>>>
>>> It seems to me that this project is avoiding that rule and moved all
>>> development to github
>>>
>>> This is in contradiction with the Apache project rules.
>>>
>>>
>>> I request clarification on this situation and requirement (instead of
>>> just asserting it), including a review by the apache boards.
>>>
>>>
>>> If it is proved that development happens primarily in github and not
>>> here I will request the following:
>>>
>>> -every people committing patches and submitting pull request to be
>>> registered on the mailing list so they are able to reply to questions
>>>
>>> -forwarding of all pull requests traffic to the mailing list
>>>
>>> For two reasons: (1) Archival purposes, and (2) open discussions with
>>> members that follow Apache Foundation mailing list rules and do not take
>>> part in github.
>>>
>>>
>>> Thank you
>>>
>>> Sebastien
>>>
>>>
>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by Sebastien Lorquet <se...@lorquet.fr>.
Hi,
I had a look and this mailing list is not made for human consumption.
No one has ever sent a message on it manually, right?
In practice, important changes are still NOT discussed on the DEV
mailing list.
You said yourself that "all development has moved to github".
As soon as automated tests are passed, every commit is considered with a
similar level of importance, however this is clearly not the case.
Sebastien
Le 08/03/2023 à 13:21, Alan C. Assis a écrit :
> HI Sebastien,
>
> It is already done, you just need to subscribe to
> https://lists.apache.org/list.html?commits@nuttx.apache.org to receive
> all commits messages and discussions.
>
> Everything is archived on apache side!
>
> BR,
>
> Alan
>
> On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
>> Apache projects are required to use mailing lists for long term archival
>> purposes.
>>
>> It seems to me that this project is avoiding that rule and moved all
>> development to github
>>
>> This is in contradiction with the Apache project rules.
>>
>>
>> I request clarification on this situation and requirement (instead of
>> just asserting it), including a review by the apache boards.
>>
>>
>> If it is proved that development happens primarily in github and not
>> here I will request the following:
>>
>> -every people committing patches and submitting pull request to be
>> registered on the mailing list so they are able to reply to questions
>>
>> -forwarding of all pull requests traffic to the mailing list
>>
>> For two reasons: (1) Archival purposes, and (2) open discussions with
>> members that follow Apache Foundation mailing list rules and do not take
>> part in github.
>>
>>
>> Thank you
>>
>> Sebastien
>>
>>
Re: DISCUSSION - Usage of mailing lists for apache projects
Posted by "Alan C. Assis" <ac...@gmail.com>.
HI Sebastien,
It is already done, you just need to subscribe to
https://lists.apache.org/list.html?commits@nuttx.apache.org to receive
all commits messages and discussions.
Everything is archived on apache side!
BR,
Alan
On 3/8/23, Sebastien Lorquet <se...@lorquet.fr> wrote:
> Apache projects are required to use mailing lists for long term archival
> purposes.
>
> It seems to me that this project is avoiding that rule and moved all
> development to github
>
> This is in contradiction with the Apache project rules.
>
>
> I request clarification on this situation and requirement (instead of
> just asserting it), including a review by the apache boards.
>
>
> If it is proved that development happens primarily in github and not
> here I will request the following:
>
> -every people committing patches and submitting pull request to be
> registered on the mailing list so they are able to reply to questions
>
> -forwarding of all pull requests traffic to the mailing list
>
> For two reasons: (1) Archival purposes, and (2) open discussions with
> members that follow Apache Foundation mailing list rules and do not take
> part in github.
>
>
> Thank you
>
> Sebastien
>
>