You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2007/02/26 09:06:42 UTC
[Bug 5353] New: meta rules can't be correctly parsed when '!=' included
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5353
Summary: meta rules can't be correctly parsed when '!=' included
Product: Spamassassin
Version: 3.1.7
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P5
Component: spamassassin
AssignedTo: dev@spamassassin.apache.org
ReportedBy: winnuxcn@hotmail.com
when '!=' appeared in a meta rule,the regular expression used to parse tokens
can't correctly do its job.For example,it produces tokens '0','!','0' for
expression '0 != 0' instead of '0','!=','0',I think a little change should be
made to that regular expression(ARITH_EXPRESSION_LEXER in Constants.pm).
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5353] meta rules can't be correctly parsed when '!=' included
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5353
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
Target Milestone|Undefined |3.1.9
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5353] [review] meta rules can't be correctly parsed when '!=' included
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5353
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED
Status Whiteboard|needs 1 |
------- Additional Comments From sidney@sidney.com 2007-06-03 03:06 -------
Actually, since it only needs one vote to commit anyway, I'll give it a +1 and
commit it to the 3.1 branch. If there ever is a reason for a 3.1.9 build, this
will be in it.
Committed revision 543870.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5353] [review] meta rules can't be correctly parsed when '!=' included
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5353
------- Additional Comments From sidney@sidney.com 2007-06-03 01:19 -------
Should this bug be closed now? As far as I can tell it is only open waiting for
a vote for the 3.1 branch for 3.1.9 but it did get in to 3.2.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5353] [review] meta rules can't be correctly parsed when '!=' included
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5353
winnuxcn@hotmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From winnuxcn@hotmail.com 2007-02-27 19:31 -------
It works.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5353] [review] meta rules can't be correctly parsed when '!=' included
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5353
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1
------- Additional Comments From jm@jmason.org 2007-02-28 11:44 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5353] [review] meta rules can't be correctly parsed when '!=' included
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5353
------- Additional Comments From felicity@apache.org 2007-02-26 08:25 -------
Created an attachment (id=3872)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3872&action=view)
suggested patch
The problem is that Boolean NOT has higher precedence than NEQ, and therefore
'!' matches before '!='.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5353] [review] meta rules can't be correctly parsed when '!=' included
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5353
------- Additional Comments From jm@jmason.org 2007-06-03 02:13 -------
well, it's got a Target Milestone of 3.1.9, so it's not visible for the 3.2.x
queue anyway -- so it's kind of harmless that it's still open.
personally, however, I'd be happy to close it -- I don't think it needs to go
into 3.1.x.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5353] [review] meta rules can't be correctly parsed when '!=' included
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5353
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|meta rules can't be |[review] meta rules can't be
|correctly parsed when '!=' |correctly parsed when '!='
|included |included
Status Whiteboard| |needs 2 votes
------- Additional Comments From felicity@apache.org 2007-02-26 08:24 -------
patch committed to 3.2:
Sending lib/Mail/SpamAssassin/Constants.pm
Transmitting file data .
Committed revision 511876.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5353] [review] meta rules can't be correctly parsed when '!=' included
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5353
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
------- Additional Comments From felicity@apache.org 2007-02-28 08:55 -------
Please don't resolve tickets prematurely. :)
The patch hasn't been applied to 3.1.9, which is what is currently being tracked.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.