You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "jrmccluskey (via GitHub)" <gi...@apache.org> on 2025/09/16 13:39:19 UTC

[PR] Move Vertex LLM Inference IT Test to new Endpoint [beam]

jrmccluskey opened a new pull request, #36172:
URL: https://github.com/apache/beam/pull/36172

   The Python PostCommit run for 3.10 was failing because the old LLM model deployed on GCP was no longer supported. This routes to a new endpoint serving Gemini Flash 2.5. 
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/actions/workflows/build_wheels.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/actions/workflows/python_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/actions/workflows/java_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/actions/workflows/go_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move Vertex LLM Inference IT Test to new Endpoint [beam]

Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #36172:
URL: https://github.com/apache/beam/pull/36172#issuecomment-3298827769

   Run Python PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove Vertex LLM Inference Integration Test [beam]

Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey merged PR #36172:
URL: https://github.com/apache/beam/pull/36172


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove Vertex LLM Inference Integration Test [beam]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #36172:
URL: https://github.com/apache/beam/pull/36172#issuecomment-3313144006

   ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/36172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 54.90%. Comparing base ([`117042c`](https://app.codecov.io/gh/apache/beam/commit/117042c4ca5e99c256b52d80b2b6c43c347a5ac9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ec86fec`](https://app.codecov.io/gh/apache/beam/commit/ec86fec2e9fbed7298abcc3a516608c81dbba1b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 23 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #36172   +/-   ##
   =========================================
     Coverage     54.90%   54.90%           
     Complexity     1618     1618           
   =========================================
     Files          1057     1057           
     Lines        164311   164355   +44     
     Branches       1165     1165           
   =========================================
   + Hits          90214    90246   +32     
   - Misses        71944    71956   +12     
     Partials       2153     2153           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/beam/pull/36172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [python](https://app.codecov.io/gh/apache/beam/pull/36172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `80.90% <ø> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/36172?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove Vertex LLM Inference Integration Test [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36172:
URL: https://github.com/apache/beam/pull/36172#issuecomment-3308791613

   Assigning reviewers:
   
   R: @damccorm for label python.
   
   
   Note: If you would like to opt out of this review, comment `assign to next reviewer`.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move Vertex LLM Inference IT Test to new Endpoint [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36172:
URL: https://github.com/apache/beam/pull/36172#issuecomment-3299552369

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove Vertex LLM Inference Integration Test [beam]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #36172:
URL: https://github.com/apache/beam/pull/36172#discussion_r2359597878


##########
sdks/python/apache_beam/ml/inference/vertex_ai_inference_it_test.py:
##########
@@ -37,7 +37,7 @@
 _INPUT = "gs://apache-beam-ml/testing/inputs/vertex_images/*/*.jpg"
 _OUTPUT_DIR = "gs://apache-beam-ml/testing/outputs/vertex_images"
 _FLOWER_ENDPOINT_ID = "5384055553544683520"
-_LLM_ENDPOINT_ID = "9157860935048626176"
+_LLM_ENDPOINT_ID = "1273985431406379008"

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   Since the test `test_vertex_ai_run_llm_text_classification` which used this constant is being removed, `_LLM_ENDPOINT_ID` is no longer used. It should be removed to avoid dead code.



##########
sdks/python/apache_beam/examples/inference/vertex_ai_llm_text_classification.py:
##########
@@ -21,6 +21,14 @@
 model can be generated by fine tuning the text-bison model or another similar
 model (see
 https://cloud.google.com/vertex-ai/docs/generative-ai/models/tune-models#supervised-fine-tuning)
+
+**NOTE**
+Google has deprecated non-Gemini LLMs and no longer supports querying them on
+Vertex AI endpoints. Separately, the use of the Vertex AI Predict API is not
+supported for Gemini models in favor of use of the google-genai API. As a
+result, this example no longer works. To perform inference with remote LLMs
+deployed on Google infrastructure, please see the GeminiModelHandler and
+the gemini_text_classification.py example.

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   To improve clarity and help users find the recommended alternatives more easily, consider adding backticks for code elements and providing the module path for `GeminiModelHandler`.
   
   ```suggestion
   deployed on Google infrastructure, please see the `GeminiModelHandler` (in `apache_beam.ml.inference.gemini_inference`) and
   the `gemini_text_classification.py` example.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove Vertex LLM Inference Integration Test [beam]

Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #36172:
URL: https://github.com/apache/beam/pull/36172#issuecomment-3308787156

   assign set of reviewers


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove Vertex LLM Inference Integration Test [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #36172:
URL: https://github.com/apache/beam/pull/36172#discussion_r2360784895


##########
sdks/python/apache_beam/examples/inference/vertex_ai_llm_text_classification.py:
##########
@@ -21,6 +21,15 @@
 model can be generated by fine tuning the text-bison model or another similar
 model (see
 https://cloud.google.com/vertex-ai/docs/generative-ai/models/tune-models#supervised-fine-tuning)
+
+**NOTE**
+Google has deprecated non-Gemini LLMs and no longer supports querying them on
+Vertex AI endpoints. Separately, the use of the Vertex AI Predict API is not
+supported for Gemini models in favor of use of the google-genai API. As a
+result, this example no longer works. To perform inference with remote LLMs
+deployed on Google infrastructure, please see the `GeminiModelHandler`
+(in `apache_beam.ml.inference.gemini_inference`) and the
+`gemini_text_classification.py` example.

Review Comment:
   Should we update https://github.com/apache/beam/tree/f27eec717b9b7e78954f97cae7bda8680382bd91/sdks/python/apache_beam/examples/inference#text-classifcation-with-a-vertex-ai-llm ? Also, I assume this would still work if you deployed your own LLM, right, its just generally not the path we'd recommend?
   
   Overall, the change looks good but we probably want to update the readme and soften the language a little bit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove Vertex LLM Inference Integration Test [beam]

Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #36172:
URL: https://github.com/apache/beam/pull/36172#issuecomment-3307761463

   @gemini-code-assist review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove Vertex LLM Inference Integration Test [beam]

Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #36172:
URL: https://github.com/apache/beam/pull/36172#issuecomment-3319472951

   failing precommit is unrelated, merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move Vertex LLM Inference IT Test to new Endpoint [beam]

Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #36172:
URL: https://github.com/apache/beam/pull/36172#issuecomment-3299245497

   Run Python PostCommit 3.10


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org