You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/04 13:19:20 UTC
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
bisakhmondal commented on a change in pull request #1689:
URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606800956
##########
File path: docs/en/latest/USER_GUIDE.md
##########
@@ -23,31 +23,31 @@ title: User Guide
The following are parts of the modules' snapshot.
-## Metrics
+## Dashboard
We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies.
-
+
Review comment:
Hii all, want to add something. We could also go for `git lfs` (faster pull). The CDN approach is okay until we need to update those static files in future releases where pinpointing the content through its CDN URL will be a huge pain in the neck. On the other hand, relative links .... (you know, just update the static file, that's it, hehe) :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org