[jira] [Commented] (AIRFLOW-6504) KubernetesExecutor: Allow specifying configmap for Airflow Local Setting

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010212#comment-17010212 ] 

ASF GitHub Bot commented on AIRFLOW-6504:
-----------------------------------------

kaxil commented on pull request #7097: [AIRFLOW-6504] Allow specifying configmap for Airflow Local Setting
URL: https://github.com/apache/airflow/pull/7097
 
 
   Currently `airflow.cfg` file can be passed via ConfigMap using `airflow_configmap` under `[kubernetes]` section setting.
   
   We want to be able to specify `airflow_local_settings.py` via configmap too so that the Kubernetes Worker has this file. We need `airflow_local_settings.py` to specify pod_mutation_hook. 
   
   Without that currently, if we are using `KubernetesExecutor` and have a task with `KubernetesPodOperator`, it will inherit and change Pod using `pod_mutation_hook`
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> KubernetesExecutor: Allow specifying configmap for Airflow Local Setting
> ------------------------------------------------------------------------
>
>                 Key: AIRFLOW-6504
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6504
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.10.7
>            Reporter: Kaxil Naik
>            Assignee: Kaxil Naik
>            Priority: Major
>             Fix For: 1.10.8
>
>
> Currently airflow.cfg file can be passed via ConfigMap to `airflow_configmap` setting.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)