You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "farmmamba (Jira)" <ji...@apache.org> on 2024/01/26 12:28:00 UTC

[jira] [Created] (HDFS-17359) EC: recheck failed streamers should only after flushing all packets.

farmmamba created HDFS-17359:
--------------------------------

             Summary: EC: recheck failed streamers should only after flushing all packets.
                 Key: HDFS-17359
                 URL: https://issues.apache.org/jira/browse/HDFS-17359
             Project: Hadoop HDFS
          Issue Type: Improvement
          Components: ec
            Reporter: farmmamba
            Assignee: farmmamba


In method DFSStripedOutputStream#checkStreamerFailures, we have below codes:
{code:java}
    Set<StripedDataStreamer> newFailed = checkStreamers();
    if (newFailed.size() == 0) {
      return;
    }    if (isNeedFlushAllPackets) {
      // for healthy streamers, wait till all of them have fetched the new block
      // and flushed out all the enqueued packets.
      flushAllInternals();
    }
    // recheck failed streamers again after the flush
    newFailed = checkStreamers(); {code}
We should better move the re-check logic into if condition to reduce useless invocation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org