You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "szehon-ho (via GitHub)" <gi...@apache.org> on 2026/06/23 23:23:52 UTC

[PR] [SPARK-57644][SQL][TEST] TxnTableCatalog should delegate capabilities to underlying catalog [spark]

szehon-ho opened a new pull request, #56713:
URL: https://github.com/apache/spark/pull/56713

   ### What changes were proposed in this pull request?
   
   `TxnTableCatalog` (test infrastructure for transactional row-level operations) wraps `InMemoryRowLevelOperationTableCatalog` but does not delegate `capabilities()`. This means capability-gated features are invisible through the transactional wrapper.
   
   Fix by adding: `override def capabilities = delegate.capabilities`
   
   ### Why are the changes needed?
   
   Without this, any capability check on the catalog through the transactional wrapper returns an empty set. This blocks testing of capability-gated features (like generated column write support) in transactional contexts.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. Test infrastructure only.
   
   ### How was this patch tested?
   
   Existing tests pass. This is a prerequisite for testing generated column MERGE/UPDATE blocking in SPARK-57644.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (claude-opus-4-6)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57644][SQL] TxnTableCatalog should delegate capabilities to underlying catalog [spark]

Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #56713:
URL: https://github.com/apache/spark/pull/56713#issuecomment-4793544974

   Merged, thanks all for reviews!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57644][SQL] TxnTableCatalog should delegate capabilities to underlying catalog [spark]

Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho closed pull request #56713: [SPARK-57644][SQL] TxnTableCatalog should delegate capabilities to underlying catalog
URL: https://github.com/apache/spark/pull/56713


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org