[GitHub] [geode-benchmarks] upthewaterspout commented on a change in pull request #149: GEODE-9176: Automatically pass properties to benchmark JVMs

[GitBox <gi...@apache.org>]

upthewaterspout commented on a change in pull request #149:
URL: https://github.com/apache/geode-benchmarks/pull/149#discussion_r617788460



##########
File path: infrastructure/src/main/java/org/apache/geode/infrastructure/aws/LaunchCluster.java
##########
@@ -241,19 +241,21 @@ private static void createKeyPair(String benchmarkTag) throws IOException {
   private static void createMetadata(String benchmarkTag, List<String> publicIps)
       throws IOException {
     UUID instanceId = UUID.randomUUID();
-    JSONObject metadataJSON = new JSONObject();
-
-    metadataJSON.put("instanceId", instanceId.toString());
-    metadataJSON.put("publicIps", new JSONArray(publicIps));
+    // TODO - Filter out only benchmark properties from system properties? Maybe not necessary.

Review comment:
       Done! Thanks for catching that. I just removed the TODO. This file is just metadata to look at later to see the entire test configuration. , So it's actually not a bad thing that it's dumping all the system properties and not just the benchmark ones.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org