[GitHub] [tvm] jcf94 commented on a change in pull request #7168: [AutoScheduler] Enable winograd for conv2d and layout rewrite for conv3d

[GitBox <gi...@apache.org>]

jcf94 commented on a change in pull request #7168:
URL: https://github.com/apache/tvm/pull/7168#discussion_r548834418



##########
File path: python/tvm/topi/nn/conv3d.py
##########
@@ -178,7 +207,12 @@ def conv3d_ndhwc(Input, Filter, stride, padding, dilation, out_dtype="float32"):
         ),
         name="Conv3dOutput",
         tag="conv3d_ndhwc",
+        attrs={"layout_free_placeholders": [Filter]},
     )
+
+    if auto_scheduler_rewritten_layout:
+        Output = auto_scheduler.rewrite_compute_body(Output, auto_scheduler_rewritten_layout)
+
     return Output

Review comment:
       How about we move the `auto_scheduler_rewritten_layout` to be checked inside the `rewrite_compute_body`?
   If it is empty, return the original compute.
   ```suggestion
       return auto_scheduler.rewrite_compute_body(Output, auto_scheduler_rewritten_layout)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org