You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "ctubbsii (via GitHub)" <gi...@apache.org> on 2026/02/05 00:40:08 UTC
[PR] Fix DigestUtils usage [accumulo-classloaders]
ctubbsii opened a new pull request, #64:
URL: https://github.com/apache/accumulo-classloaders/pull/64
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix DigestUtils usage [accumulo-classloaders]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #64:
URL: https://github.com/apache/accumulo-classloaders/pull/64#issuecomment-3850447666
@keith-turner found this while writing a test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix DigestUtils usage [accumulo-classloaders]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii merged PR #64:
URL: https://github.com/apache/accumulo-classloaders/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix DigestUtils usage [accumulo-classloaders]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #64:
URL: https://github.com/apache/accumulo-classloaders/pull/64#issuecomment-3854828547
> This is going to create a lot of DigestUtils instances, which means a lot of MessageDigest instances. I think a ThreadLocal<Map<AlgorithName,DigestUtils>> could help reduce the number of DigestUtil instances created overall.
Message digest are used in a loop over files, looked into creating a single one outside the loops in the code and that does not work well. Thread local could reduce the number of creations but it would also leave one of these objects on any thread that ever touches it. Maybe we do not need to do anything, it depends on how expensive creating the digest is vs hashing the file. If hashing the file takes way more time it may not be helpful to optimize this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix DigestUtils usage [accumulo-classloaders]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #64:
URL: https://github.com/apache/accumulo-classloaders/pull/64#issuecomment-3853637722
This is going to create a lot of DigestUtils instances, which means a lot of MessageDigest instances. I think a `ThreadLocal<Map<AlgorithName,DigestUtils>>` could help reduce the number of DigestUtil instances created overall.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org