You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rayees Namathponnan <ra...@citrix.com> on 2014/05/27 23:49:10 UTC
Review Request 21946: CLOUDSTACK-6392 system template always create with
name "master" instead of specific branch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21946/
-----------------------------------------------------------
Review request for cloudstack and Abhinandan Prateek.
Bugs: CLOUDSTACK-6392
https://issues.apache.org/jira/browse/CLOUDSTACK-6392
Repository: cloudstack-git
Description
-------
Create system vm from jenkins.buildacloud.org
in 4.4 System vm always create with same name "systemvm64template-master-xen.vhd"
it should be create with name "systemvm64template-4.4-xen.vhd"
Diffs
-----
tools/appliance/build.sh a228e26
Diff: https://reviews.apache.org/r/21946/diff/
Testing
-------
Tested below piece of code from source tree
branch=
if [ -z "$branch" ] ; then
branch=`git status | grep '# On branch' | awk '{print $4}'`
fi
if [ -z "$branch" ] ; then
branch=unknown
fi
echo "Branch"
echo $branch
Thanks,
Rayees Namathponnan
Re: Review Request 21946: CLOUDSTACK-6392 system template always create with
name "master" instead of specific branch
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21946/#review44108
-----------------------------------------------------------
Ship it!
Ship It!
- Rajesh Battala
On May 27, 2014, 9:49 p.m., Rayees Namathponnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21946/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 9:49 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Bugs: CLOUDSTACK-6392
> https://issues.apache.org/jira/browse/CLOUDSTACK-6392
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Create system vm from jenkins.buildacloud.org
> in 4.4 System vm always create with same name "systemvm64template-master-xen.vhd"
> it should be create with name "systemvm64template-4.4-xen.vhd"
>
>
> Diffs
> -----
>
> tools/appliance/build.sh a228e26
>
> Diff: https://reviews.apache.org/r/21946/diff/
>
>
> Testing
> -------
>
> Tested below piece of code from source tree
>
> branch=
>
> if [ -z "$branch" ] ; then
> branch=`git status | grep '# On branch' | awk '{print $4}'`
> fi
>
> if [ -z "$branch" ] ; then
> branch=unknown
> fi
>
> echo "Branch"
> echo $branch
>
>
> Thanks,
>
> Rayees Namathponnan
>
>
Re: Review Request 21946: CLOUDSTACK-6392 system template always create with
name "master" instead of specific branch
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21946/#review44098
-----------------------------------------------------------
Commit 63090434b1cb4e7b87f0e024fbbc644faee863f7 in cloudstack's branch refs/heads/4.4-forward from rayeesn
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6309043 ]
CLOUDSTACK-6392: system template always create with name master instead of specific branch
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On May 27, 2014, 9:49 p.m., Rayees Namathponnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21946/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 9:49 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Bugs: CLOUDSTACK-6392
> https://issues.apache.org/jira/browse/CLOUDSTACK-6392
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Create system vm from jenkins.buildacloud.org
> in 4.4 System vm always create with same name "systemvm64template-master-xen.vhd"
> it should be create with name "systemvm64template-4.4-xen.vhd"
>
>
> Diffs
> -----
>
> tools/appliance/build.sh a228e26
>
> Diff: https://reviews.apache.org/r/21946/diff/
>
>
> Testing
> -------
>
> Tested below piece of code from source tree
>
> branch=
>
> if [ -z "$branch" ] ; then
> branch=`git status | grep '# On branch' | awk '{print $4}'`
> fi
>
> if [ -z "$branch" ] ; then
> branch=unknown
> fi
>
> echo "Branch"
> echo $branch
>
>
> Thanks,
>
> Rayees Namathponnan
>
>
Re: Review Request 21946: CLOUDSTACK-6392 system template always create with
name "master" instead of specific branch
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21946/#review44096
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On May 27, 2014, 9:49 p.m., Rayees Namathponnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21946/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 9:49 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Bugs: CLOUDSTACK-6392
> https://issues.apache.org/jira/browse/CLOUDSTACK-6392
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Create system vm from jenkins.buildacloud.org
> in 4.4 System vm always create with same name "systemvm64template-master-xen.vhd"
> it should be create with name "systemvm64template-4.4-xen.vhd"
>
>
> Diffs
> -----
>
> tools/appliance/build.sh a228e26
>
> Diff: https://reviews.apache.org/r/21946/diff/
>
>
> Testing
> -------
>
> Tested below piece of code from source tree
>
> branch=
>
> if [ -z "$branch" ] ; then
> branch=`git status | grep '# On branch' | awk '{print $4}'`
> fi
>
> if [ -z "$branch" ] ; then
> branch=unknown
> fi
>
> echo "Branch"
> echo $branch
>
>
> Thanks,
>
> Rayees Namathponnan
>
>
Re: Review Request 21946: CLOUDSTACK-6392 system template always create with
name "master" instead of specific branch
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21946/#review44097
-----------------------------------------------------------
Commit 5f11c2e0be06ff1580ee7898b6316a4d61412db8 in cloudstack's branch refs/heads/master from rayeesn
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5f11c2e ]
CLOUDSTACK-6392: system template always create with name master instead of specific branch
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On May 27, 2014, 9:49 p.m., Rayees Namathponnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21946/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 9:49 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Bugs: CLOUDSTACK-6392
> https://issues.apache.org/jira/browse/CLOUDSTACK-6392
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Create system vm from jenkins.buildacloud.org
> in 4.4 System vm always create with same name "systemvm64template-master-xen.vhd"
> it should be create with name "systemvm64template-4.4-xen.vhd"
>
>
> Diffs
> -----
>
> tools/appliance/build.sh a228e26
>
> Diff: https://reviews.apache.org/r/21946/diff/
>
>
> Testing
> -------
>
> Tested below piece of code from source tree
>
> branch=
>
> if [ -z "$branch" ] ; then
> branch=`git status | grep '# On branch' | awk '{print $4}'`
> fi
>
> if [ -z "$branch" ] ; then
> branch=unknown
> fi
>
> echo "Branch"
> echo $branch
>
>
> Thanks,
>
> Rayees Namathponnan
>
>
Re: Review Request 21946: CLOUDSTACK-6392 system template always create with
name "master" instead of specific branch
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21946/#review44343
-----------------------------------------------------------
Commit b4021284b853362f414e68e52deb5ba92734a7e2 in cloudstack's branch refs/heads/4.4 from rayeesn
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b402128 ]
CLOUDSTACK-6392: system template always create with name master instead of specific branch
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On May 27, 2014, 9:49 p.m., Rayees Namathponnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21946/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 9:49 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Bugs: CLOUDSTACK-6392
> https://issues.apache.org/jira/browse/CLOUDSTACK-6392
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Create system vm from jenkins.buildacloud.org
> in 4.4 System vm always create with same name "systemvm64template-master-xen.vhd"
> it should be create with name "systemvm64template-4.4-xen.vhd"
>
>
> Diffs
> -----
>
> tools/appliance/build.sh a228e26
>
> Diff: https://reviews.apache.org/r/21946/diff/
>
>
> Testing
> -------
>
> Tested below piece of code from source tree
>
> branch=
>
> if [ -z "$branch" ] ; then
> branch=`git status | grep '# On branch' | awk '{print $4}'`
> fi
>
> if [ -z "$branch" ] ; then
> branch=unknown
> fi
>
> echo "Branch"
> echo $branch
>
>
> Thanks,
>
> Rayees Namathponnan
>
>