You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/04/14 05:46:00 UTC
[jira] [Work logged] (GOBBLIN-1116) Avoid registering schema with
schema registry during MetricReporting initialization from cluster workers
[ https://issues.apache.org/jira/browse/GOBBLIN-1116?focusedWorklogId=421865&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-421865 ]
ASF GitHub Bot logged work on GOBBLIN-1116:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/20 05:45
Start Date: 14/Apr/20 05:45
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2956: GOBBLIN-1116: Avoid registering schema with schema registry during Me…
URL: https://github.com/apache/incubator-gobblin/pull/2956
…tricReporting initialization from cluster workers
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1116
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
This PR avoids having to register schema with schema registry on Kafka metric reporter initialization from cluster workers. This avoids a potentially large number of connections that may be initiated with Kafka Schema registry on Gobblin on Yarn application launch.
In addition, this PR cleans up existing code in SchemaRegistryVersionWriter and Kafka reporters, and refactors existing unit tests.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
This PR adds new unit tests for each of the metric reporter types. In addition, we add a new unit test in GobblinYarnAppLauncherTest.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 421865)
Remaining Estimate: 0h
Time Spent: 10m
> Avoid registering schema with schema registry during MetricReporting initialization from cluster workers
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1116
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1116
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This PR avoids having to register schema with schema registry on Kafka metric reporter initialization from cluster workers. This avoids a potentially large number of connections that may be initiated with Kafka Schema registry on Gobblin on Yarn application launch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)