You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/09 00:59:59 UTC
[GitHub] [beam] robertwb opened a new pull request #11358: [BEAM-9729]
Runner-side bundle registration cleanup.
robertwb opened a new pull request #11358: [BEAM-9729] Runner-side bundle registration cleanup.
URL: https://github.com/apache/beam/pull/11358
Client-side cleanup to come later once dataflow service is up to date.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] robertwb commented on issue #11358: [BEAM-9729] Runner-side
bundle registration cleanup.
Posted by GitBox <gi...@apache.org>.
robertwb commented on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup.
URL: https://github.com/apache/beam/pull/11358#issuecomment-612246262
Run Python2_PVR_Flink PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] robertwb commented on issue #11358: [BEAM-9729] Runner-side
bundle registration cleanup.
Posted by GitBox <gi...@apache.org>.
robertwb commented on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup.
URL: https://github.com/apache/beam/pull/11358#issuecomment-612246232
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on a change in pull request #11358:
[BEAM-9729] Runner-side bundle registration cleanup.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #11358: [BEAM-9729] Runner-side bundle registration cleanup.
URL: https://github.com/apache/beam/pull/11358#discussion_r408935328
##########
File path: runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/SdkHarnessClientTest.java
##########
@@ -573,7 +577,7 @@ public void handleCleanupWithStateWhenAwaitingOnClosingOutputReceivers() throws
@Test
public void verifyCacheTokensAreUsedInNewBundleRequest() throws InterruptedException {
when(fnApiControlClient.handle(any(BeamFnApi.InstructionRequest.class)))
- .thenReturn(createRegisterResponse());
+ .thenReturn(createAnyResponse());
Review comment:
Since this function is only used once, you might want to inline the contents of the function here for readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] robertwb commented on issue #11358: [BEAM-9729] Runner-side
bundle registration cleanup.
Posted by GitBox <gi...@apache.org>.
robertwb commented on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup.
URL: https://github.com/apache/beam/pull/11358#issuecomment-613002829
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11358: [BEAM-9729,
BEAM-8486] Runner-side bundle registration cleanup.
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11358: [BEAM-9729, BEAM-8486] Runner-side bundle registration cleanup.
URL: https://github.com/apache/beam/pull/11358#issuecomment-614935695
> For my edification - what happened here? Are bundles registered with the process bundle request?
Robert has since informed me that this is pull-based now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11358: [BEAM-9729,
BEAM-8486] Runner-side bundle registration cleanup.
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11358: [BEAM-9729, BEAM-8486] Runner-side bundle registration cleanup.
URL: https://github.com/apache/beam/pull/11358#issuecomment-614345351
For my edification - what happened here? Are bundles registered with the process bundle request?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11358: [BEAM-9729] Runner-side
bundle registration cleanup.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup.
URL: https://github.com/apache/beam/pull/11358#issuecomment-611743908
Run Python PreCommit"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] robertwb commented on issue #11358: [BEAM-9729] Runner-side
bundle registration cleanup.
Posted by GitBox <gi...@apache.org>.
robertwb commented on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup.
URL: https://github.com/apache/beam/pull/11358#issuecomment-612246441
R: @lukecwik
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] robertwb merged pull request #11358: [BEAM-9729,
BEAM-8486] Runner-side bundle registration cleanup.
Posted by GitBox <gi...@apache.org>.
robertwb merged pull request #11358: [BEAM-9729, BEAM-8486] Runner-side bundle registration cleanup.
URL: https://github.com/apache/beam/pull/11358
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11358: [BEAM-9729] Runner-side
bundle registration cleanup.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup.
URL: https://github.com/apache/beam/pull/11358#issuecomment-611743983
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik removed a comment on issue #11358: [BEAM-9729]
Runner-side bundle registration cleanup.
Posted by GitBox <gi...@apache.org>.
lukecwik removed a comment on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup.
URL: https://github.com/apache/beam/pull/11358#issuecomment-611743908
Run Python PreCommit"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] robertwb commented on a change in pull request #11358:
[BEAM-9729, BEAM-8486] Runner-side bundle registration cleanup.
Posted by GitBox <gi...@apache.org>.
robertwb commented on a change in pull request #11358: [BEAM-9729, BEAM-8486] Runner-side bundle registration cleanup.
URL: https://github.com/apache/beam/pull/11358#discussion_r409020580
##########
File path: runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/SdkHarnessClientTest.java
##########
@@ -573,7 +577,7 @@ public void handleCleanupWithStateWhenAwaitingOnClosingOutputReceivers() throws
@Test
public void verifyCacheTokensAreUsedInNewBundleRequest() throws InterruptedException {
when(fnApiControlClient.handle(any(BeamFnApi.InstructionRequest.class)))
- .thenReturn(createRegisterResponse());
+ .thenReturn(createAnyResponse());
Review comment:
Makes sense. Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services