You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/06/04 01:20:43 UTC
Review Request 35038: Updated slave to query resource estimator
whenever it wants to forward an update.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35038/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Jie Yu, and Niklas Nielsen.
Bugs: MESOS-2808
https://issues.apache.org/jira/browse/MESOS-2808
Repository: mesos
Description
-------
Instead of 2 loops, we just use one loop now. See the bug for additonal details.
Diffs
-----
src/slave/slave.hpp 245ea062a56461d96ee3055be1c93ec508d1bec7
src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05
src/tests/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b
Diff: https://reviews.apache.org/r/35038/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 35038: Updated slave to query resource estimator
whenever it wants to forward an update.
Posted by Jie Yu <yu...@gmail.com>.
> On June 3, 2015, 11:44 p.m., Jie Yu wrote:
> >
Also, could you please adjust the comments above the public resource estimator 'oversubscribable()' interface since we incur a minimal interval in the slave?
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35038/#review86514
-----------------------------------------------------------
On June 3, 2015, 11:20 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35038/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 11:20 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Niklas Nielsen.
>
>
> Bugs: MESOS-2808
> https://issues.apache.org/jira/browse/MESOS-2808
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of 2 loops, we just use one loop now. See the bug for additonal details.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 245ea062a56461d96ee3055be1c93ec508d1bec7
> src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05
> src/tests/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b
>
> Diff: https://reviews.apache.org/r/35038/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 35038: Updated slave to query resource estimator
whenever it wants to forward an update.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35038/#review86514
-----------------------------------------------------------
Ship it!
src/slave/slave.cpp
<https://reviews.apache.org/r/35038/#comment138572>
Why CHECK instead of logging and retry? So returning a failure in the resource estimator will crash the slave?
- Jie Yu
On June 3, 2015, 11:20 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35038/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 11:20 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Niklas Nielsen.
>
>
> Bugs: MESOS-2808
> https://issues.apache.org/jira/browse/MESOS-2808
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of 2 loops, we just use one loop now. See the bug for additonal details.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 245ea062a56461d96ee3055be1c93ec508d1bec7
> src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05
> src/tests/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b
>
> Diff: https://reviews.apache.org/r/35038/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 35038: Updated slave to query resource estimator
whenever it wants to forward an update.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35038/
-----------------------------------------------------------
(Updated June 4, 2015, 12:03 a.m.)
Review request for mesos, Ben Mahler, Jie Yu, and Niklas Nielsen.
Changes
-------
instead of CHECK we log an error and retry. also updated the estimator::oversubscribable() documentation.
Bugs: MESOS-2808
https://issues.apache.org/jira/browse/MESOS-2808
Repository: mesos
Description
-------
Instead of 2 loops, we just use one loop now. See the bug for additonal details.
Diffs (updated)
-----
include/mesos/slave/resource_estimator.hpp e7f5decdabdfc75587d784a08a98c62ffdfc2909
src/slave/slave.hpp 245ea062a56461d96ee3055be1c93ec508d1bec7
src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05
src/tests/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b
Diff: https://reviews.apache.org/r/35038/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 35038: Updated slave to query resource estimator
whenever it wants to forward an update.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35038/#review86518
-----------------------------------------------------------
LGTM modulo Jie's comment on the hard check
- Niklas Nielsen
On June 3, 2015, 4:20 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35038/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 4:20 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Niklas Nielsen.
>
>
> Bugs: MESOS-2808
> https://issues.apache.org/jira/browse/MESOS-2808
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of 2 loops, we just use one loop now. See the bug for additonal details.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 245ea062a56461d96ee3055be1c93ec508d1bec7
> src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05
> src/tests/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b
>
> Diff: https://reviews.apache.org/r/35038/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>