You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/12/18 18:44:33 UTC
[GitHub] [guacamole-client] BojanZelic opened a new pull request #581: GUACAMOLE-1218: Add auth-json config & extension to docker
BojanZelic opened a new pull request #581:
URL: https://github.com/apache/guacamole-client/pull/581
The Docker file is currently missing the auth-json extension & configuration.
This allows us to enable the extension by defining the $JSON_SECRET_KEY environmental variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] BojanZelic commented on a change in pull request #581: GUACAMOLE-1218: Add auth-json config & extension to docker
Posted by GitBox <gi...@apache.org>.
BojanZelic commented on a change in pull request #581:
URL: https://github.com/apache/guacamole-client/pull/581#discussion_r546064539
##########
File path: guacamole-docker/bin/start.sh
##########
@@ -687,6 +687,18 @@ END
ln -s /opt/guacamole/cas/guacamole-auth-*.jar "$GUACAMOLE_EXT"
}
+##
+## Adds properties to guacamole.properties which configure the json
+## authentication provider.
+##
+associate_json() {
+ # Update config file
+ set_optional_property "json-secret-key" "$JSON_SECRET_KEY"
Review comment:
Good catch. should be fixed now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on a change in pull request #581: GUACAMOLE-1218: Add auth-json config & extension to docker
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #581:
URL: https://github.com/apache/guacamole-client/pull/581#discussion_r546053229
##########
File path: guacamole-docker/bin/start.sh
##########
@@ -687,6 +687,18 @@ END
ln -s /opt/guacamole/cas/guacamole-auth-*.jar "$GUACAMOLE_EXT"
}
+##
+## Adds properties to guacamole.properties which configure the json
+## authentication provider.
+##
+associate_json() {
+ # Update config file
+ set_optional_property "json-secret-key" "$JSON_SECRET_KEY"
Review comment:
Is this an optional property? Isn't this required if the JSON extension is used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman merged pull request #581: GUACAMOLE-1218: Add auth-json config & extension to docker
Posted by GitBox <gi...@apache.org>.
necouchman merged pull request #581:
URL: https://github.com/apache/guacamole-client/pull/581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] BojanZelic commented on a change in pull request #581: GUACAMOLE-1218: Add auth-json config & extension to docker
Posted by GitBox <gi...@apache.org>.
BojanZelic commented on a change in pull request #581:
URL: https://github.com/apache/guacamole-client/pull/581#discussion_r546069122
##########
File path: guacamole-docker/bin/start.sh
##########
@@ -687,6 +687,18 @@ END
ln -s /opt/guacamole/cas/guacamole-auth-*.jar "$GUACAMOLE_EXT"
}
+##
+## Adds properties to guacamole.properties which configure the json
+## authentication provider.
+##
+associate_json() {
+ # Update config file
+ set_property "json-secret-key" "$JSON_SECRET_KEY"
Review comment:
Good point, that property wasn't documented and I wasn't aware it existed. Should be fixed now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on a change in pull request #581: GUACAMOLE-1218: Add auth-json config & extension to docker
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #581:
URL: https://github.com/apache/guacamole-client/pull/581#discussion_r546065767
##########
File path: guacamole-docker/bin/start.sh
##########
@@ -687,6 +687,18 @@ END
ln -s /opt/guacamole/cas/guacamole-auth-*.jar "$GUACAMOLE_EXT"
}
+##
+## Adds properties to guacamole.properties which configure the json
+## authentication provider.
+##
+associate_json() {
+ # Update config file
+ set_property "json-secret-key" "$JSON_SECRET_KEY"
Review comment:
While we're at it, should we also make the optional property "json-trusted-networks" available, here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org