[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #25049: Support for substring, DUAL , Spatial function

["strongduanmu (via GitHub)" <gi...@apache.org>]

strongduanmu commented on code in PR #25049:
URL: https://github.com/apache/shardingsphere/pull/25049#discussion_r1164982280


##########
sql-parser/dialect/mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/impl/MySQLStatementSQLVisitor.java:
##########
@@ -942,7 +949,13 @@ public final ASTNode visitPositionFunction(final PositionFunctionContext ctx) {
     @Override
     public final ASTNode visitSubstringFunction(final SubstringFunctionContext ctx) {
         calculateParameterCount(Collections.singleton(ctx.expr()));

Review Comment:
   Can you push your code to this pr? `calculateParameterCount` is still here.



##########
test/it/optimizer/src/test/java/org/apache/shardingsphere/test/it/optimize/SQLNodeConverterEngineIT.java:
##########
@@ -193,6 +193,9 @@ private Set<String> getSupportedSQLCaseIDs() {
             result.add("select_order_by_for_nulls_last");
             result.add("select_char");
             result.add("select_weight_string");
+            result.add("select_substring");

Review Comment:
   In addition, I recommend supporting only one new SQL CASE at a time, which can help solve the problem.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org