You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/31 21:23:15 UTC

[GitHub] [airflow] coopergillan opened a new pull request #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

coopergillan opened a new pull request #7316: [AIRFLOW-6699] Parameterize weekday sensor tests
URL: https://github.com/apache/airflow/pull/7316
 
 
   Using the `parameterized` library, consolidate the "true" or so-called "happy path" tests, reducing overall code to maintain and showing each test case in one list of tuples.
   
   This makes it faster to add any other true test cases if need be.
   
   For now, the "false" tests are different enough to remain as-is.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

Posted by GitBox <gi...@apache.org>.
coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-581182457
 
 
   @mik-laj - is there already an Apache JIRA ticket for reorganizing those Hive tests? If not, I am happy to create one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

Posted by GitBox <gi...@apache.org>.
coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-586815669
 
 
   @mik-laj - I did start some of that work on organizing the Hive tests. Here is what I have so far:
   
   https://github.com/apache/airflow/compare/master...coopergillan:AIRFLOW-6721-organize-hive-tests?expand=1
   
   Do you think this is the right idea? Would love any other feedback on that. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-580933199
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=h1) Report
   > Merging [#7316](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/65b524a6a571b6b3510d10672b3c7cd075323d07?src=pr&el=desc) will **decrease** coverage by `0.24%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7316/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7316      +/-   ##
   ==========================================
   - Coverage   85.59%   85.34%   -0.25%     
   ==========================================
     Files         863      863              
     Lines       40484    40484              
   ==========================================
   - Hits        34651    34552      -99     
   - Misses       5833     5932      +99
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
   | [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0%> (-32.36%)` | :arrow_down: |
   | [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `77.46% <0%> (-16.91%)` | :arrow_down: |
   | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `93.33% <0%> (-3.34%)` | :arrow_down: |
   | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `85.63% <0%> (-2.5%)` | :arrow_down: |
   | [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `88.42% <0%> (-2.48%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `90.43% <0%> (-1.45%)` | :arrow_down: |
   | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `88.75% <0%> (-0.44%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=footer). Last update [65b524a...2fecab1](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

Posted by GitBox <gi...@apache.org>.
coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-580919009
 
 
   Note: I noticed [usage of `parameterized` in `tests/providers/sftp/hooks/test_sftp.py`](https://github.com/coopergillan/airflow/blob/d97fe949c8dfd888abf27a4254ef0d27388f63bb/tests/providers/sftp/hooks/test_sftp.py#L210) among other spots.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-580946162
 
 
   @coopergillan  I see that you like order in tests. Wouldn't you like to organize one file?  
   https://github.com/apache/airflow/blob/master/tests/providers/apache/hive/operators/test_hive.py#L29-L40
   This file contains tests for many unrelated components. I think it would be useful to transfer some tests to other files.
   Here is an example: https://github.com/PolideaInternal/airflow/commit/a91b61222a7790c6daeb59f3bb2d90f1a2cc1c40
   To avoid conflicts you can do it in one PR, but it would be useful for each move to be in a separate commit. This will facilitate the review. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-580933199
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=h1) Report
   > Merging [#7316](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/65b524a6a571b6b3510d10672b3c7cd075323d07?src=pr&el=desc) will **decrease** coverage by `0.69%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7316/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #7316     +/-   ##
   =========================================
   - Coverage   85.59%   84.89%   -0.7%     
   =========================================
     Files         863      863             
     Lines       40484    40484             
   =========================================
   - Hits        34651    34369    -282     
   - Misses       5833     6115    +282
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
   | [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0%> (-72.16%)` | :arrow_down: |
   | [airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=) | `28.16% <0%> (-54.93%)` | :arrow_down: |
   | [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50% <0%> (-50%)` | :arrow_down: |
   | [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0%> (-46.67%)` | :arrow_down: |
   | [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `49.65% <0%> (-38.78%)` | :arrow_down: |
   | [airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=) | `61.53% <0%> (-38.47%)` | :arrow_down: |
   | [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0%> (-32.36%)` | :arrow_down: |
   | [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `77.46% <0%> (-16.91%)` | :arrow_down: |
   | ... and [7 more](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=footer). Last update [65b524a...2fecab1](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

Posted by GitBox <gi...@apache.org>.
coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-581185092
 
 
   Done: https://issues.apache.org/jira/browse/AIRFLOW-6721
   
   Let me know if that is accurate based on what you mentioned.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

Posted by GitBox <gi...@apache.org>.
coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-580932930
 
 
   Pushed up two fixup commits and then squashed them into one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

Posted by GitBox <gi...@apache.org>.
coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-580951357
 
 
   Sure, I would love to give that a shot. Thanks!
   
   On Fri, Jan 31, 2020 at 16:53 Kamil Breguła <no...@github.com>
   wrote:
   
   > @coopergillan <https://github.com/coopergillan> I see that you like order
   > in tests. Wouldn't you like to organize one file?
   >
   > https://github.com/apache/airflow/blob/master/tests/providers/apache/hive/operators/test_hive.py#L29-L40
   > This file contains tests for many unrelated components. I think it would
   > be useful to transfer some tests to other files.
   > Here is an example: PolideaInternal@a91b612
   > <https://github.com/PolideaInternal/airflow/commit/a91b61222a7790c6daeb59f3bb2d90f1a2cc1c40>
   > To avoid conflicts you can do it in one PR, but it would be useful for
   > each move to be in a separate commit. This will facilitate the review.
   >
   > —
   > You are receiving this because you were mentioned.
   >
   >
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/airflow/pull/7316?email_source=notifications&email_token=ACSELCXBOLPFPD3ENLHDQOLRASTU3A5CNFSM4KONYK72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKQIR4Q#issuecomment-580946162>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ACSELCQ5GLIHM547JBRVIXDRASTU3ANCNFSM4KONYK7Q>
   > .
   >
   -- 
   
   Cooper
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-581183419
 
 
   @coopergillan  Not yet. You must create a new ticket.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-580933199
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=h1) Report
   > Merging [#7316](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/65b524a6a571b6b3510d10672b3c7cd075323d07?src=pr&el=desc) will **increase** coverage by `0.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7316/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7316      +/-   ##
   ==========================================
   + Coverage   85.82%   85.96%   +0.14%     
   ==========================================
     Files         863      866       +3     
     Lines       40484    41420     +936     
   ==========================================
   + Hits        34744    35608     +864     
   - Misses       5740     5812      +72
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `79.71% <0%> (-8.73%)` | :arrow_down: |
   | [airflow/executors/executor\_loader.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZXhlY3V0b3JfbG9hZGVyLnB5) | `75% <0%> (-3.95%)` | :arrow_down: |
   | [airflow/providers/papermill/operators/papermill.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcGFwZXJtaWxsL29wZXJhdG9ycy9wYXBlcm1pbGwucHk=) | `96.42% <0%> (-3.58%)` | :arrow_down: |
   | [airflow/utils/decorators.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kZWNvcmF0b3JzLnB5) | `89.36% <0%> (-1.12%)` | :arrow_down: |
   | [airflow/www/validators.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmFsaWRhdG9ycy5weQ==) | `100% <0%> (ø)` | :arrow_up: |
   | [airflow/www/forms.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZm9ybXMucHk=) | `100% <0%> (ø)` | :arrow_up: |
   | [.../providers/amazon/aws/operators/cloud\_formation.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvY2xvdWRfZm9ybWF0aW9uLnB5) | `100% <0%> (ø)` | |
   | [...flow/providers/amazon/aws/hooks/cloud\_formation.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9jbG91ZF9mb3JtYXRpb24ucHk=) | `96.77% <0%> (ø)` | |
   | [...ow/providers/amazon/aws/sensors/cloud\_formation.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZW5zb3JzL2Nsb3VkX2Zvcm1hdGlvbi5weQ==) | `100% <0%> (ø)` | |
   | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.97% <0%> (+0.25%)` | :arrow_up: |
   | ... and [9 more](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=footer). Last update [65b524a...2fecab1](https://codecov.io/gh/apache/airflow/pull/7316?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7316: [AIRFLOW-6699] Parameterize weekday sensor tests
URL: https://github.com/apache/airflow/pull/7316
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services