You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/11/03 16:11:17 UTC

[GitHub] [beam] lukecwik commented on a change in pull request #15836: [BEAM-13099] Use vendored Calcite 1.28.0 in SQL extensions

lukecwik commented on a change in pull request #15836:
URL: https://github.com/apache/beam/pull/15836#discussion_r742104648



##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -53,10 +53,12 @@ def hadoopVersions = [
 hadoopVersions.each {kv -> configurations.create("hadoopVersion$kv.key")}
 
 dependencies {
+  // Required for processing Calcite's immutable annotations

Review comment:
       If its only necessary for annotation processing consider adding it under `annotationProcessor` and possibly `compileOnly` (only if its a dep as well) like [BeamModulePlugin.groovy](https://github.com/apache/beam/blob/48318dd3aedeb208648149eca36165bbfff09e1a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L966) does.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org