You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/24 18:48:31 UTC

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #18116: [PIP-214][broker]Add broker level metrics statistics and expose to prometheus

michaeljmarshall commented on code in PR #18116:
URL: https://github.com/apache/pulsar/pull/18116#discussion_r1003641182


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/NamespaceStatsAggregator.java:
##########
@@ -70,7 +71,19 @@ public static void generate(PulsarService pulsar, boolean includeTopicMetrics, b
         LongAdder topicsCount = new LongAdder();

Review Comment:
   I think it would make sense to rename this variable as part of this work so that it is clear what the `topicsCount` is counting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org