You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/31 08:22:14 UTC

[GitHub] fhueske commented on a change in pull request #6625: [hotfix][docs] Fix some error about the example of stateful source function in state documentatition

fhueske commented on a change in pull request #6625: [hotfix][docs] Fix some error about the example of stateful source function in state documentatition
URL: https://github.com/apache/flink/pull/6625#discussion_r214277888
 
 

 ##########
 File path: docs/dev/stream/state/state.md
 ##########
 @@ -668,7 +668,7 @@ public static class CounterSource
     @Override
     public void restoreState(List<Long> state) {
         for (Long s : state)
-            offset = s;
+            offset += s;
 
 Review comment:
   I don't think this is necessary. It depends on the semantics of the source how to deal with multiple states. This cannot be inferred from the example. I would keep it as it is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services