You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "TezQA (Jira)" <ji...@apache.org> on 2020/06/05 14:39:00 UTC
[jira] [Commented] (TEZ-4169) Decouple from Hadoop's jackson
version and shade the latest in Tez
[ https://issues.apache.org/jira/browse/TEZ-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126836#comment-17126836 ]
TezQA commented on TEZ-4169:
----------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 9m 58s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m 7s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 6m 47s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 6m 41s{color} | {color:red} root in master has 3 extant findbugs warnings. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 15s{color} | {color:red} tez-ext-service-tests in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 13s{color} | {color:red} tez-yarn-timeline-history in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 14s{color} | {color:red} tez-history-parser in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m 35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 14s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m 11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 14m 11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 57s{color} | {color:green} tez-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 21s{color} | {color:green} tez-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 35m 57s{color} | {color:green} tez-tests in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 58s{color} | {color:green} tez-ext-service-tests in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 28s{color} | {color:green} tez-protobuf-history-plugin in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 37s{color} | {color:green} tez-yarn-timeline-history in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 45s{color} | {color:green} tez-yarn-timeline-history-with-acls in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 31s{color} | {color:green} tez-yarn-timeline-history-with-fs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 23s{color} | {color:green} tez-history-parser in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 13m 44s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m 54s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}147m 31s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | tez.dag.app.TestSpeculation |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/PreCommit-TEZ-Build/460/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4169 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13004918/TEZ-4169.08.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle |
| uname | Linux 0c01bbe0fc61 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 2c94033 |
| Default Java | 1.8.0_252 |
| findbugs | https://builds.apache.org/job/PreCommit-TEZ-Build/460/artifact/out/branch-findbugs-root-warnings.html |
| mvninstall | https://builds.apache.org/job/PreCommit-TEZ-Build/460/artifact/out/patch-mvninstall-tez-ext-service-tests.txt |
| mvninstall | https://builds.apache.org/job/PreCommit-TEZ-Build/460/artifact/out/patch-mvninstall-tez-plugins_tez-yarn-timeline-history.txt |
| mvninstall | https://builds.apache.org/job/PreCommit-TEZ-Build/460/artifact/out/patch-mvninstall-tez-plugins_tez-history-parser.txt |
| unit | https://builds.apache.org/job/PreCommit-TEZ-Build/460/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/460/testReport/ |
| Max. process+thread count | 1249 (vs. ulimit of 5500) |
| modules | C: tez-api tez-mapreduce tez-tests tez-ext-service-tests tez-plugins/tez-protobuf-history-plugin tez-plugins/tez-yarn-timeline-history tez-plugins/tez-yarn-timeline-history-with-acls tez-plugins/tez-yarn-timeline-history-with-fs tez-plugins/tez-history-parser . U: . |
| Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/460/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
> Decouple from Hadoop's jackson version and shade the latest in Tez
> ------------------------------------------------------------------
>
> Key: TEZ-4169
> URL: https://issues.apache.org/jira/browse/TEZ-4169
> Project: Apache Tez
> Issue Type: Bug
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Attachments: TEZ-4169.01.patch, TEZ-4169.02.patch, TEZ-4169.03.patch, TEZ-4169.04.patch, TEZ-4169.05.patch, TEZ-4169.06.patch, TEZ-4169.07.patch, TEZ-4169.07.patch, TEZ-4169.08.patch
>
>
> Tez has many occurrences of jackson dependencies in its dep tree, however none of them is direct:
> {code}
> lbodor@HW12459 ~/apache/tez master mvn dependency:tree | grep jackson | wc -l
> 204
> {code}
> This is misleading, because tez protobuf history plugin does depend on jackson mapper, so it should have jackson as a direct dependency.
> Similarly to other dependencies, transitive deps can also trigger security scan alerts, complaining about outdated jackson dependencies. It would be cleaner to:
> 1. completely remove unused transitive jackson depdendencies and re-add them in test scope where it's needed for clarity's sake
> 2. include jackson as direct dependency where it's used (this could move focus to that place when there is a need for an upgrade)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)