You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/08/04 02:40:42 UTC

[GitHub] [trafficserver] maskit commented on a change in pull request #7079: const-ify quic/http3 code

maskit commented on a change in pull request #7079:
URL: https://github.com/apache/trafficserver/pull/7079#discussion_r464765044



##########
File path: iocore/net/quic/QUICFrame.h
##########
@@ -234,7 +234,7 @@ class QUICAckFrame : public QUICFrame
     size_t size() const;
     Ptr<IOBufferBlock> to_io_buffer_block(size_t limit) const;
     uint64_t first_ack_block() const;
-    void add_ack_block(const AckBlock block);
+    void add_ack_block(const AckBlock &block);

Review comment:
       Was this change made by hand or some tools?
   While I want to make Ack processing fast as possible as we can, I also want to take the advantage of auto-correct (if it was done by tools). I guess it beats the unfortunate case that we accidentally copy big objects.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org