You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "wangyang0918 (via GitHub)" <gi...@apache.org> on 2023/04/27 09:21:43 UTC

[GitHub] [flink] wangyang0918 commented on a diff in pull request #22491: [FLINK-31947] enable stdout for flink-console.sh

wangyang0918 commented on code in PR #22491:
URL: https://github.com/apache/flink/pull/22491#discussion_r1178864770


##########
flink-dist/src/main/flink-bin/bin/flink-console.sh:
##########
@@ -116,4 +117,5 @@ echo $$ >> "$pid" 2>/dev/null
 # Evaluate user options for local variable expansion
 FLINK_ENV_JAVA_OPTS=$(eval echo ${FLINK_ENV_JAVA_OPTS})
 
+exec 1>"${out}"

Review Comment:
   Given that we are using `log4j-console.properties` for the log configuration, all the Flink logs will also be mirrored to the stdout. Then we will have duplicated logs for `*.log` and `*.out`.
   
   Actually, we already have some discussion about the `.out` file in this PR https://github.com/apache/flink/pull/11839.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org