You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/06 19:34:45 UTC
[GitHub] [incubator-nuttx] adamfeuer opened a new pull request #464: restore
lines from bad nxstyle fixes
adamfeuer opened a new pull request #464: restore lines from bad nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/464
### Summary
* Fix for SAMA5D3 build break introduced in #444
* Lines were mistakenly deleted during nxstyle fixes or a bad merge
### Impact
* SAMA5D3 build is unbroken
### Detail
* arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h file is restored to its previous state
### Testing
* Compiled and ran the build on a SAMA5D3-Xplained board
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #464: restore lines
from bad nxstyle fixes
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #464: restore lines from bad nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#464: restore lines from bad nxstyle fixes
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #464: restore lines from bad nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/464#discussion_r389118727
##########
File path: arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h
##########
@@ -103,6 +103,8 @@
# define SAM_ISI_OFFSET 0x00034000 /* 0x00034000-0x00037fff: ISI */
# define SAM_SFR_OFFSET 0x00038000 /* 0x00038000-0x0003bfff: SFR */
/* 0x0003c000-0x07ffffff: Reserved */
+
Review comment:
Note that the spaces added after the right comments are incorrect. They should be removed.
This is documented bug in nxstyle. It is reporting that a blank line is needed, but that is a bug. No blank line should be added: See Issue #120
Please remove these extra blank lines. You are corrupted an otherwise correct file due to an error in nxstyle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#464: restore lines from bad nxstyle fixes
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #464: restore lines from bad nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/464#discussion_r389118727
##########
File path: arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h
##########
@@ -103,6 +103,8 @@
# define SAM_ISI_OFFSET 0x00034000 /* 0x00034000-0x00037fff: ISI */
# define SAM_SFR_OFFSET 0x00038000 /* 0x00038000-0x0003bfff: SFR */
/* 0x0003c000-0x07ffffff: Reserved */
+
Review comment:
No that the spaces adder after the right commcomments are incorrect. They should be removed.
This is documented bug in nxstyle. It is reporting that a blank line is needed, but that is a bug. No blank line should be added: See Issue #120
Please remove these extra blank lines. You are corrupted an otherwise correct file due to an error in nxstyle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request
#464: restore lines from bad nxstyle fixes
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on a change in pull request #464: restore lines from bad nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/464#discussion_r389176623
##########
File path: arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h
##########
@@ -103,6 +103,8 @@
# define SAM_ISI_OFFSET 0x00034000 /* 0x00034000-0x00037fff: ISI */
# define SAM_SFR_OFFSET 0x00038000 /* 0x00038000-0x0003bfff: SFR */
/* 0x0003c000-0x07ffffff: Reserved */
+
Review comment:
@patacongo Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request
#464: restore lines from bad nxstyle fixes
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on a change in pull request #464: restore lines from bad nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/464#discussion_r389175201
##########
File path: arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h
##########
@@ -103,6 +103,8 @@
# define SAM_ISI_OFFSET 0x00034000 /* 0x00034000-0x00037fff: ISI */
# define SAM_SFR_OFFSET 0x00038000 /* 0x00038000-0x0003bfff: SFR */
/* 0x0003c000-0x07ffffff: Reserved */
+
Review comment:
@patacongo Will fix.
Re: nxstyle bug, I'm confused about what nxstyle errors to fix or not fix. It seems like if we are going to use a tool, it should report correctly. Is there someone in the nuttx community who knows the best way to fix this bug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on issue #464: restore lines
from bad nxstyle fixes
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on issue #464: restore lines from bad nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/464#issuecomment-595926745
@liuguo09 @patacongo This is the fix for the SAMA5D3 build break.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services