You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kk...@apache.org on 2009/06/24 18:40:02 UTC

svn commit: r788077 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: kkolinko
Date: Wed Jun 24 16:40:02 2009
New Revision: 788077

URL: http://svn.apache.org/viewvc?rev=788077&view=rev
Log:
votes

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=788077&r1=788076&r2=788077&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Jun 24 16:40:02 2009
@@ -153,7 +153,7 @@
   and fixes nsi installer script.
   Patch for 6.0.x is available at:
   http://people.apache.org/~mturk/tomcat/tomcat6-package-winzip-2.patch
-  +1: mturk
+  +1: mturk, kkolinko
   -1:
 
 * When throwing Non-serializable exception, mark which argument was
@@ -163,6 +163,13 @@
   6.0.x version of the patch:
   http://people.apache.org/~mturk/tomcat/setAttribute.iae.patch
   +1: mturk
+  -1: kkolinko: (
+      good in general, but
+      1) please use native2ascii for LocalStrings_fr.properties
+      s/ e / \u00nn /
+      2) o.a.c.session.ha.session.LocalString*.properties files also have this string.
+      Should it be removed from there, or updated there also?
+     )
   -1:
 
 * Change default value of compilerTargetVM, compilerSourceVM options in JspC,



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r788077 - /tomcat/tc6.0.x/trunk/STATUS.txt

Posted by Mladen Turk <mt...@apache.org>.
kkolinko@apache.org wrote:
> Author: kkolinko
>  
>  * When throwing Non-serializable exception, mark which argument was
> @@ -163,6 +163,13 @@
>    6.0.x version of the patch:
>    http://people.apache.org/~mturk/tomcat/setAttribute.iae.patch
>    +1: mturk
> +  -1: kkolinko: (
> +      good in general, but
> +      1) please use native2ascii for LocalStrings_fr.properties
> +      s/ e / \u00nn /

I made the patch before all that native2ascii stuff changed.
However I updated the patch.

> +      2) o.a.c.session.ha.session.LocalString*.properties files also have this string.
> +      Should it be removed from there, or updated there also?

This has nothing to do with the patch.
It's a separate issue that requires cleanup of o.a.c.session.ha which has
lots of unused entries probably due to copy/paste.
At least the standardSession.setAttribute.iae is never used inside
the o.a.c.session.ha package.

Regards
-- 
^(TM)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org